Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: break up _record_utterance() into focused helpers #573

Closed
kimi wants to merge 0 commits from kimi/issue-570 into main
pull from: kimi/issue-570
merge into: Rockachopa:main
Conversation 3 Commits - Files Changed -
kimi commented 2026-03-20 01:41:15 +00:00
Collaborator
Copy Link

Extract _capture_audio_blocks() and _finalize_utterance() from the 73-line _record_utterance() method, and promote _rms() to a module-level function.

Fixes #570

Extract `_capture_audio_blocks()` and `_finalize_utterance()` from the 73-line `_record_utterance()` method, and promote `_rms()` to a module-level function. Fixes #570
kimi added 1 commit 2026-03-20 01:41:16 +00:00
refactor: break up _record_utterance() into focused helpers
All checks were successful
Tests / lint (pull_request) Successful in 4s
Details
Tests / test (pull_request) Successful in 1m10s
Details
cd62c61cd6 
Extract _capture_audio_blocks() and _finalize_utterance() from the 73-line
_record_utterance() method, and promote _rms() to a module-level function.

Fixes #570

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Timmy commented 2026-03-20 15:21:46 +00:00
Owner
Copy Link

This PR has merge conflicts with main and cannot be rebased automatically. @kimi please rebase onto main and resolve conflicts, or I will close this and re-delegate.

This PR has merge conflicts with main and cannot be rebased automatically. @kimi please rebase onto main and resolve conflicts, or I will close this and re-delegate.
Timmy commented 2026-03-20 15:44:23 +00:00
Owner
Copy Link

@kimi This PR has merge conflicts with main. Please rebase your branch kimi/issue-570 onto latest main and force-push.

@kimi This PR has merge conflicts with main. Please rebase your branch `kimi/issue-570` onto latest main and force-push.
Timmy reviewed 2026-03-20 15:51:18 +00:00
Timmy left a comment
Owner
Copy Link

Closing — this refactor was already merged in 9f244ff via PR #572. This PR has merge conflicts and is redundant.

Closing — this refactor was already merged in 9f244ff via PR #572. This PR has merge conflicts and is redundant.
Timmy closed this pull request 2026-03-20 15:51:19 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Timmy
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#573
Delete Branch "kimi/issue-570"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?