Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [test-coverage] Tests for spark modules — advisor.py, eidos.py, memory.py (900+ lines, zero coverage) #659

New Issue
Closed
opened 2026-03-20 23:13:13 +00:00 by Timmy · 1 comment
Timmy commented 2026-03-20 23:13:13 +00:00
Owner
Copy Link

Problem

Three spark modules have zero test coverage:

  • src/spark/advisor.py (297 lines)
  • src/spark/eidos.py (297 lines)
  • src/spark/memory.py (313 lines)

Total: 907 lines untested.

Scope

Can be split per-module. Start with advisor.py as it likely has the simplest interface.

Verification

tox -e unit -- tests/spark/ -v
## Problem Three spark modules have zero test coverage: - `src/spark/advisor.py` (297 lines) - `src/spark/eidos.py` (297 lines) - `src/spark/memory.py` (313 lines) Total: 907 lines untested. ## Scope Can be split per-module. Start with `advisor.py` as it likely has the simplest interface. ## Verification ``` tox -e unit -- tests/spark/ -v ```
kimi was assigned by Timmy 2026-03-21 01:57:08 +00:00
kimi commented 2026-03-21 13:32:37 +00:00
Collaborator
Copy Link

PR created. Added 95 comprehensive tests across 3 new test files:

  • test_advisor.py (30 tests) — all advisory helpers and integration
  • test_eidos.py (30 tests) — predictions, evaluations, accuracy, queries
  • test_memory.py (35 tests) — events, memories, importance scoring, DB schema

All tests pass: tox -e unit (2376 passed), tox -e lint (clean), tox -e pre-push (2393 passed).

PR created. Added 95 comprehensive tests across 3 new test files: - `test_advisor.py` (30 tests) — all advisory helpers and integration - `test_eidos.py` (30 tests) — predictions, evaluations, accuracy, queries - `test_memory.py` (35 tests) — events, memories, importance scoring, DB schema All tests pass: `tox -e unit` (2376 passed), `tox -e lint` (clean), `tox -e pre-push` (2393 passed).
kimi closed this issue 2026-03-21 13:32:54 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees kimi
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#659
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?