[kimi] test: add comprehensive tests for spark modules (#659) #695

kimi · 2026-03-21T13:32:34Z

kimi commented

2026-03-21 13:32:34 +00:00

Fixes #659

Summary

Added tests/spark/test_advisor.py (30 tests) covering all advisory helpers: _check_failure_patterns, _check_agent_performance, _check_bid_patterns, _check_prediction_accuracy, _check_system_activity, and generate_advisories integration tests
Added tests/spark/test_eidos.py (30 tests) covering predict_task_outcome, evaluate_prediction, _compute_accuracy, get_predictions filters, and get_accuracy_stats
Added tests/spark/test_memory.py (35 tests) covering score_importance, record_event, get_events, store_memory, get_memories, count_events, count_memories, and _get_conn schema verification

Test plan

tox -e unit — 2376 passed, 1 skipped
tox -e lint — clean
tox -e pre-push — 2393 passed (full CI mirror)

🤖 Generated with Claude Code

Fixes #659 ## Summary - Added `tests/spark/test_advisor.py` (30 tests) covering all advisory helpers: `_check_failure_patterns`, `_check_agent_performance`, `_check_bid_patterns`, `_check_prediction_accuracy`, `_check_system_activity`, and `generate_advisories` integration tests - Added `tests/spark/test_eidos.py` (30 tests) covering `predict_task_outcome`, `evaluate_prediction`, `_compute_accuracy`, `get_predictions` filters, and `get_accuracy_stats` - Added `tests/spark/test_memory.py` (35 tests) covering `score_importance`, `record_event`, `get_events`, `store_memory`, `get_memories`, `count_events`, `count_memories`, and `_get_conn` schema verification ## Test plan - [x] `tox -e unit` — 2376 passed, 1 skipped - [x] `tox -e lint` — clean - [x] `tox -e pre-push` — 2393 passed (full CI mirror) 🤖 Generated with [Claude Code](https://claude.com/claude-code)

kimi added 1 commit 2026-03-21 13:32:34 +00:00

test: add comprehensive tests for spark advisor, eidos, and memory modules (#659 )

Tests / lint (pull_request) Has been cancelled

Details

Tests / test (pull_request) Has been cancelled

Details

3f64e5c2bd

Adds dedicated test files for the three spark modules that had minimal
test coverage:

- test_advisor.py: 30 tests covering all advisory helpers
  (_check_failure_patterns, _check_agent_performance, _check_bid_patterns,
  _check_prediction_accuracy, _check_system_activity) and generate_advisories
  integration tests.

- test_eidos.py: 30 tests covering predict_task_outcome (baseline, history,
  edge cases), evaluate_prediction, _compute_accuracy components,
  get_predictions filters, and get_accuracy_stats.

- test_memory.py: 35 tests covering score_importance (all event types,
  boosts), record_event (auto/explicit importance, invalid JSON),
  get_events (all filters, ordering), store_memory, get_memories,
  count_events, count_memories, and _get_conn schema verification.

Fixes #659

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

kimi merged commit 1f1bc222e4 into main

2026-03-21 13:32:54 +00:00

kimi deleted branch kimi/issue-659

2026-03-21 13:32:54 +00:00

kimi referenced this issue from a commit

2026-03-21 13:32:54 +00:00

[kimi] test: add comprehensive tests for spark modules (#659) (#695)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#695