Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[kimi-generated] Pre-commit and pre-push hooks fail on main due to 256 ModuleNotFoundErrors #687

New Issue
Closed
opened 2026-03-21 03:26:41 +00:00 by kimi · 1 comment
kimi commented 2026-03-21 03:26:41 +00:00
Collaborator
Copy Link

Bug

The .githooks/pre-commit and .githooks/pre-push hooks both fail on a clean main checkout because tox -e unit (and tox -e pre-push) exit with code 1 due to 256 pre-existing ModuleNotFoundError collection errors in pytest.

All 1889 actual tests pass, but pytest returns exit code 1 when there are collection errors, which causes the hooks to block all local commits and pushes.

Steps to reproduce

  1. git checkout main
  2. tox -e unit
  3. Observe: 1889 passed, 256 errors, exit code 1

Impact

No local commits or pushes can be made without overriding the hooks path. All recent commits on main were merged via the Gitea UI (PR merges), bypassing local hooks.

Suggested fix

Either:

  • Fix the 256 missing module imports so collection succeeds
  • Or adjust the hook to tolerate collection errors when all collected tests pass (e.g., use --ignore-glob patterns for problematic test files)
## Bug The `.githooks/pre-commit` and `.githooks/pre-push` hooks both fail on a clean `main` checkout because `tox -e unit` (and `tox -e pre-push`) exit with code 1 due to 256 pre-existing `ModuleNotFoundError` collection errors in pytest. All 1889 actual tests pass, but pytest returns exit code 1 when there are collection errors, which causes the hooks to block all local commits and pushes. ### Steps to reproduce 1. `git checkout main` 2. `tox -e unit` 3. Observe: 1889 passed, 256 errors, exit code 1 ### Impact No local commits or pushes can be made without overriding the hooks path. All recent commits on main were merged via the Gitea UI (PR merges), bypassing local hooks. ### Suggested fix Either: - Fix the 256 missing module imports so collection succeeds - Or adjust the hook to tolerate collection errors when all collected tests pass (e.g., use `--ignore-glob` patterns for problematic test files)
kimi was assigned by Timmy 2026-03-21 18:02:17 +00:00
kimi added this to the Infrastructure milestone 2026-03-21 20:25:08 +00:00
Timmy commented 2026-03-22 01:43:09 +00:00
Owner
Copy Link

Verified on main: tox -e unit runs clean — 2883 passed, 0 collection errors, exit code 0. The 256 ModuleNotFoundErrors have been resolved (likely fixed incrementally across recent PRs). Pre-commit and pre-push hooks should now work correctly. Closing.

Verified on main: `tox -e unit` runs clean — 2883 passed, 0 collection errors, exit code 0. The 256 ModuleNotFoundErrors have been resolved (likely fixed incrementally across recent PRs). Pre-commit and pre-push hooks should now work correctly. Closing.
Timmy closed this issue 2026-03-22 01:43:10 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone Infrastructure
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees kimi
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#687
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?