Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Break up cli.py::chat — 72 lines #627

New Issue
Closed
opened 2026-03-20 20:38:40 +00:00 by Timmy · 4 comments
Timmy commented 2026-03-20 20:38:40 +00:00
Owner
Copy Link

Refactor

src/timmy/cli.py::chat (lines 147-218) is 72 lines — extract stdin reading logic into a helper like _read_message_input() and session resolution into _resolve_session_id().

Files

  • src/timmy/cli.py
## Refactor `src/timmy/cli.py::chat` (lines 147-218) is 72 lines — extract stdin reading logic into a helper like `_read_message_input()` and session resolution into `_resolve_session_id()`. ### Files - `src/timmy/cli.py`
Timmy commented 2026-03-20 20:38:54 +00:00
Author
Owner
Copy Link

Kimi: Extract stdin reading into _read_message_input(message: list[str]) -> str and session resolution into _resolve_session_id(session_id, new_session) -> str. Keep the chat() function as a thin orchestrator calling these helpers. Run tox -e unit to verify.

Kimi: Extract stdin reading into `_read_message_input(message: list[str]) -> str` and session resolution into `_resolve_session_id(session_id, new_session) -> str`. Keep the `chat()` function as a thin orchestrator calling these helpers. Run `tox -e unit` to verify.
kimi was assigned by Timmy 2026-03-20 20:38:55 +00:00
kimi was unassigned by Timmy 2026-03-21 01:56:59 +00:00
kimi was assigned by Timmy 2026-03-21 01:57:06 +00:00
kimi commented 2026-03-21 03:19:18 +00:00
Collaborator
Copy Link

PR created. Extracted _read_message_input() and _resolve_session_id() from chat(), reducing it to a thin orchestrator. All unit tests pass (1889 passed, 0 failed). Note: 256 pre-existing ERRORs from missing module imports exist on main as well.

PR created. Extracted `_read_message_input()` and `_resolve_session_id()` from `chat()`, reducing it to a thin orchestrator. All unit tests pass (1889 passed, 0 failed). Note: 256 pre-existing ERRORs from missing module imports exist on main as well.
kimi commented 2026-03-21 03:26:48 +00:00
Collaborator
Copy Link

Verified PR #686 has the correct changes. Extracted _read_message_input() and _resolve_session_id() from chat(), reducing it to a thin orchestrator. All 1889 unit tests pass (256 pre-existing collection errors on main — filed #687 for that). Lint and format are clean.

Verified PR #686 has the correct changes. Extracted `_read_message_input()` and `_resolve_session_id()` from `chat()`, reducing it to a thin orchestrator. All 1889 unit tests pass (256 pre-existing collection errors on main — filed #687 for that). Lint and format are clean.
kimi closed this issue 2026-03-21 03:33:17 +00:00
kimi commented 2026-03-21 03:33:33 +00:00
Collaborator
Copy Link

PR #690 created. Extracted _read_message_input() and _resolve_session_id() from chat(), reducing it to a thin orchestrator. All 1889 unit tests pass.

PR #690 created. Extracted `_read_message_input()` and `_resolve_session_id()` from `chat()`, reducing it to a thin orchestrator. All 1889 unit tests pass.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees kimi
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#627
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?