Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[kimi] refactor: extract helpers from chat() (#627) #690

Merged
Timmy merged 5 commits from kimi/issue-627 into main 2026-03-21 18:09:23 +00:00
Conversation 0 Commits 5 Files Changed -
kimi commented 2026-03-21 03:33:28 +00:00
Collaborator
Copy Link

Fixes #627

Extracted two helpers from the 72-line chat() function:

  • _read_message_input(message: list[str]) -> str — joins CLI args and handles stdin reading
  • _resolve_session_id(session_id, new_session) -> str — resolves the effective session ID from CLI flags

chat() is now a thin orchestrator calling these helpers.

All 1889 unit tests pass (256 pre-existing collection errors from missing module imports on main).

Fixes #627 Extracted two helpers from the 72-line `chat()` function: - `_read_message_input(message: list[str]) -> str` — joins CLI args and handles stdin reading - `_resolve_session_id(session_id, new_session) -> str` — resolves the effective session ID from CLI flags `chat()` is now a thin orchestrator calling these helpers. All 1889 unit tests pass (256 pre-existing collection errors from missing module imports on main).
kimi added 1 commit 2026-03-21 03:33:28 +00:00
refactor: extract _read_message_input and _resolve_session_id from chat()
Some checks failed
Tests / lint (pull_request) Has been cancelled
Details
Tests / test (pull_request) Has been cancelled
Details
917bf3e404 
Break up the 72-line chat() function into a thin orchestrator by
extracting stdin reading logic into _read_message_input() and session
resolution into _resolve_session_id().

Fixes #627

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Timmy added 1 commit 2026-03-21 13:52:06 +00:00
Merge branch 'main' into kimi/issue-627
Some checks failed
Tests / lint (pull_request) Has been cancelled
Details
Tests / test (pull_request) Has been cancelled
Details
6fc9ac09d2
Timmy added 1 commit 2026-03-21 18:01:22 +00:00
Merge branch 'main' into kimi/issue-627
Some checks failed
Tests / lint (pull_request) Has been cancelled
Details
Tests / test (pull_request) Has been cancelled
Details
20159cd286
Timmy added 1 commit 2026-03-21 18:08:42 +00:00
Merge branch 'main' into kimi/issue-627
Some checks failed
Tests / lint (pull_request) Has been cancelled
Details
Tests / test (pull_request) Has been cancelled
Details
f2295afba5
Timmy added 1 commit 2026-03-21 18:09:13 +00:00
Merge branch 'main' into kimi/issue-627
Some checks failed
Tests / lint (pull_request) Has been cancelled
Details
Tests / test (pull_request) Has been cancelled
Details
57b9953bb1
Timmy merged commit d1f5c2714b into main 2026-03-21 18:09:23 +00:00
Timmy deleted branch kimi/issue-627 2026-03-21 18:09:23 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#690
Delete Branch "kimi/issue-627"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?