[claude] Fix TemplateResponse signature for Starlette new API (#1114) #1120

claude · 2026-03-23T18:20:18Z

claude commented

2026-03-23 18:20:18 +00:00

Root cause

Starlette changed TemplateResponse signature from TemplateResponse(name, context) to TemplateResponse(request, name, context). Several routes in routes/tools.py and routes/calm.py still used the old form, passing a string as the first arg and a dict as the second. With the new Starlette, the dict became the name parameter passed to Jinja2’s template cache lookup, which computed tuple([dict]) as the cache key — unhashable, causing TypeError: cannot use ‘tuple’ as a dict key (unhashable type: ‘dict’).

Fix

Updated all 7 old-style TemplateResponse calls in routes/tools.py and routes/calm.py to the new TemplateResponse(request, name, context) signature and removed the now-redundant "request" key from context dicts (Starlette adds it automatically).

Tests

All 10 previously failing tests now pass. Full unit suite: 3247 passed, 1 skipped.

Fixes #1114 ## Root cause Starlette changed `TemplateResponse` signature from `TemplateResponse(name, context)` to `TemplateResponse(request, name, context)`. Several routes in `routes/tools.py` and `routes/calm.py` still used the old form, passing a string as the first arg and a dict as the second. With the new Starlette, the dict became the `name` parameter passed to Jinja2’s template cache lookup, which computed `tuple([dict])` as the cache key — unhashable, causing `TypeError: cannot use ‘tuple’ as a dict key (unhashable type: ‘dict’)`. ## Fix Updated all 7 old-style `TemplateResponse` calls in `routes/tools.py` and `routes/calm.py` to the new `TemplateResponse(request, name, context)` signature and removed the now-redundant `"request"` key from context dicts (Starlette adds it automatically). ## Tests All 10 previously failing tests now pass. Full unit suite: 3247 passed, 1 skipped.

claude added 1 commit 2026-03-23 18:20:19 +00:00

fix: update TemplateResponse calls to new Starlette signature

Tests / test (pull_request) Has been skipped

Details

Tests / lint (pull_request) Failing after 16s

Details

45344ca5af

Starlette changed TemplateResponse from TemplateResponse(name, context)
to TemplateResponse(request, name, context). The old calling convention
passed a dict as the 'name' parameter, which Jinja2 tried to use as a
cache key inside a tuple, causing TypeError: unhashable type: 'dict'.

Updated all old-style calls in routes/tools.py and routes/calm.py to
use the new positional-request-first signature and removed redundant
"request" key from context dicts (Starlette adds it automatically).

Fixes #1114

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

claude referenced this pull request

2026-03-23 18:20:27 +00:00

[loop-generated] [bug] 10 pre-existing test failures on main block all commits — unhashable dict key #1114

Rockachopa commented

2026-03-23 18:21:44 +00:00

Critical bugfix, want to merge ASAP. Has conflicts with main. Please rebase and force-push. This should land before #1121.

Timmy commented

2026-03-23 18:27:45 +00:00

Closing: PR has merge conflicts with main that cannot be auto-rebased. The underlying issue remains open for re-implementation.

Timmy closed this pull request

2026-03-23 18:27:46 +00:00

Rockachopa commented

2026-03-23 18:28:56 +00:00

LGTM — correct Starlette TemplateResponse fix, small diff, tests passing. Has merge conflicts against main. Please rebase and force-push, then I will merge.