Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[claude] Three-Strike Detector for Repeated Manual Work (#962) #1163

Closed
claude wants to merge 2 commits from (deleted):claude/issue-962 into main
pull from: (deleted):claude/issue-962
merge into: Rockachopa:main
Conversation 2 Commits 2 Files Changed 6 +1037
claude commented 2026-03-23 19:51:16 +00:00
Collaborator
Copy Link

Fixes #962

Summary

  • src/timmy/sovereignty/three_strike.py: SQLite-backed ThreeStrikeStore with three-tier strike system (discovery → warning → block), ThreeStrikeError exception, FalseworkChecklist pre-cloud-API checklist, and module-level get_detector() singleton
  • src/timmy/sovereignty/__init__.py: New sovereignty subpackage
  • src/dashboard/routes/three_strike.py: REST API under /sovereignty/three-strike (list, blocked, record, register automation, events)
  • src/dashboard/app.py: Router registered in FastAPI app
  • tests/timmy/test_three_strike.py: 52 unit tests covering all strike states, blocking, automation registration, and falsework checklist
  • tests/timmy/test_three_strike_routes.py: 7 unit tests for API routes with per-test temp DB isolation via monkeypatched get_detector()

Behaviour

  • Strike 1 (count=1): discovery — action proceeds normally, logged at INFO
  • Strike 2 (count=2): warning — action proceeds, logged at WARNING
  • Strike 3 (count≥3): blocked — raises ThreeStrikeError; caller must register an automation artifact first

Categories tracked

vlm_prompt_edit, game_bug_review, parameter_tuning, portal_adapter_creation, deployment_step

Fixes #962 ## Summary - **`src/timmy/sovereignty/three_strike.py`**: SQLite-backed `ThreeStrikeStore` with three-tier strike system (discovery → warning → block), `ThreeStrikeError` exception, `FalseworkChecklist` pre-cloud-API checklist, and module-level `get_detector()` singleton - **`src/timmy/sovereignty/__init__.py`**: New sovereignty subpackage - **`src/dashboard/routes/three_strike.py`**: REST API under `/sovereignty/three-strike` (list, blocked, record, register automation, events) - **`src/dashboard/app.py`**: Router registered in FastAPI app - **`tests/timmy/test_three_strike.py`**: 52 unit tests covering all strike states, blocking, automation registration, and falsework checklist - **`tests/timmy/test_three_strike_routes.py`**: 7 unit tests for API routes with per-test temp DB isolation via monkeypatched `get_detector()` ## Behaviour - Strike 1 (count=1): discovery — action proceeds normally, logged at INFO - Strike 2 (count=2): warning — action proceeds, logged at WARNING - Strike 3 (count≥3): blocked — raises `ThreeStrikeError`; caller must register an automation artifact first ## Categories tracked `vlm_prompt_edit`, `game_bug_review`, `parameter_tuning`, `portal_adapter_creation`, `deployment_step`
claude added 2 commits 2026-03-23 19:51:16 +00:00
WIP: Claude Code progress on #962 ab014788df 
Automated salvage commit — agent session ended (exit 124).
Work in progress, may need continuation.
feat: Three-Strike Detector for Repeated Manual Work
Some checks failed
Tests / lint (pull_request) Has been cancelled
Details
Tests / test (pull_request) Has been cancelled
Details
f3a7a26108 
Implements the three-strike detector that tracks recurring manual
actions by category and blocks the action on the third occurrence,
requiring an automation artifact to be registered first.

- src/timmy/sovereignty/three_strike.py: SQLite-backed ThreeStrikeStore,
  ThreeStrikeError, FalseworkChecklist (pre-cloud-API checklist),
  and module-level get_detector() singleton
- src/timmy/sovereignty/__init__.py: new sovereignty subpackage
- src/dashboard/routes/three_strike.py: REST API endpoints under
  /sovereignty/three-strike (list, blocked, record, register automation,
  events)
- src/dashboard/app.py: router registered in FastAPI app
- tests/timmy/test_three_strike.py: 52 unit tests covering all strike
  states, blocking, automation registration, and falsework checklist
- tests/timmy/test_three_strike_routes.py: 7 unit tests for API routes;
  fixed test isolation via monkeypatched get_detector() per-test temp DB

Fixes #962

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Timmy commented 2026-03-23 20:00:04 +00:00
Owner
Copy Link

Closing: merge conflicts with main after other PRs landed. Will re-implement on a fresh branch if still needed.

Closing: merge conflicts with main after other PRs landed. Will re-implement on a fresh branch if still needed.
Timmy closed this pull request 2026-03-23 20:00:07 +00:00
Rockachopa commented 2026-03-23 20:02:16 +00:00
Owner
Copy Link

Good work — three-tier strike system looks solid and 59 tests are thorough. However this PR has merge conflicts with main. Please rebase on main and force-push, then I will merge.

Good work — three-tier strike system looks solid and 59 tests are thorough. However this PR has merge conflicts with main. Please rebase on main and force-push, then I will merge.
Some checks failed
Tests / lint (pull_request) Has been cancelled
Details
Tests / test (pull_request) Has been cancelled
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1163
Delete Branch "(deleted):claude/issue-962"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?