Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-cycle-4] fix: isolate test_returns_primary_when_available from env (#1238) #1242

Closed
Timmy wants to merge 1 commits from fix/test-config-env-isolation into main
pull from: fix/test-config-env-isolation
merge into: Rockachopa:main
Conversation 1 Commits 1 Files Changed 1 +3 -3
Timmy commented 2026-03-23 23:14:18 +00:00
Owner
Copy Link

Fixes #1238

The test hardcoded qwen3:14b but .env sets OLLAMA_MODEL=qwen3:30b. Changed assertion to compare against settings.ollama_model so the test works regardless of environment config.

Fixes #1238 The test hardcoded `qwen3:14b` but `.env` sets `OLLAMA_MODEL=qwen3:30b`. Changed assertion to compare against `settings.ollama_model` so the test works regardless of environment config.
Timmy added 1 commit 2026-03-23 23:14:19 +00:00
fix: isolate test_returns_primary_when_available from env (#1238)
Some checks failed
Tests / lint (pull_request) Failing after 15s
Details
Tests / test (pull_request) Has been skipped
Details
32b07bc848
Timmy commented 2026-03-23 23:18:51 +00:00
Author
Owner
Copy Link

Closing — issue #1238 is already resolved on main (test passes). This PR has merge conflicts and is no longer needed.

Closing — issue #1238 is already resolved on main (test passes). This PR has merge conflicts and is no longer needed.
Timmy closed this pull request 2026-03-23 23:18:52 +00:00
Some checks failed
Tests / lint (pull_request) Failing after 15s
Details
Tests / test (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1242
Delete Branch "fix/test-config-env-isolation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?