Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-cycle-6] fix: mock config.settings in vassal tests to prevent xdist hangs (#1243) #1246

Closed
Timmy wants to merge 0 commits from fix/flaky-vassal-xdist-tests into main
pull from: fix/flaky-vassal-xdist-tests
merge into: Rockachopa:main
Conversation 0 Commits - Files Changed -
Timmy commented 2026-03-23 23:29:26 +00:00
Owner
Copy Link

Summary

Fixes #1243 — 10 vassal tests that hung/timed out under pytest-xdist parallel execution.

Root cause

Three tests in test_vassal_agent_health.py called check_agent_health() and get_full_health_report() without mocking config.settings, causing real httpx.AsyncClient connections to Gitea with 15s timeouts. Under xdist parallel workers, multiple simultaneous HTTP connections caused hangs exceeding the 30s test timeout.

All tests in test_vassal_orchestration_loop.py called run_cycle() which internally invokes _step_backlog and _step_agent_health — both making real Gitea calls when config is unmocked.

Changes

  • test_vassal_agent_health.py: Mock config.settings in test_check_agent_health_no_token, test_get_full_health_report_returns_both_agents, and test_get_full_health_report_structure
  • test_vassal_orchestration_loop.py: Add autouse fixture that mocks config.settings.gitea_enabled=False for all tests

Verification

tox -e unit — all 435 tests pass in 15.91s with -n auto --dist worksteal. Zero failures, zero timeouts.

Note

Pre-existing lint errors in cascade.py, _base.py, and test_three_strike.py block pre-commit hooks on ALL branches. Filed as separate issue.

## Summary Fixes #1243 — 10 vassal tests that hung/timed out under pytest-xdist parallel execution. ## Root cause Three tests in `test_vassal_agent_health.py` called `check_agent_health()` and `get_full_health_report()` without mocking `config.settings`, causing real `httpx.AsyncClient` connections to Gitea with 15s timeouts. Under xdist parallel workers, multiple simultaneous HTTP connections caused hangs exceeding the 30s test timeout. All tests in `test_vassal_orchestration_loop.py` called `run_cycle()` which internally invokes `_step_backlog` and `_step_agent_health` — both making real Gitea calls when config is unmocked. ## Changes - `test_vassal_agent_health.py`: Mock `config.settings` in `test_check_agent_health_no_token`, `test_get_full_health_report_returns_both_agents`, and `test_get_full_health_report_structure` - `test_vassal_orchestration_loop.py`: Add `autouse` fixture that mocks `config.settings.gitea_enabled=False` for all tests ## Verification `tox -e unit` — all 435 tests pass in 15.91s with `-n auto --dist worksteal`. Zero failures, zero timeouts. ## Note Pre-existing lint errors in `cascade.py`, `_base.py`, and `test_three_strike.py` block pre-commit hooks on ALL branches. Filed as separate issue.
Timmy closed this pull request 2026-03-23 23:34:57 +00:00
Some checks failed
Tests / lint (push) Has been cancelled
Details
Tests / test (push) Has been cancelled
Details
Tests / lint (pull_request) Failing after 16s
Details
Tests / test (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1246
Delete Branch "fix/flaky-vassal-xdist-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?