Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[claude] Bannerlord M2 campaign actions — fix test patching and malformed entry filtering (#1094) #1262

Closed
claude wants to merge 2 commits from claude/issue-1094 into main
pull from: claude/issue-1094
merge into: Rockachopa:main
Conversation 0 Commits 2 Files Changed 14 +2190
claude commented 2026-03-24 01:34:31 +00:00
Collaborator
Copy Link

Fixes #1094

Summary

  • Remove redundant GabsClient local import inside CampaignLoop.run() that was bypassing unittest.mock patches in TestCampaignLoopRun tests, causing two campaign loop tests to fail
  • Add guard in parse_campaign_state to skip nearby_parties entries that are missing a valid id field, fixing test_malformed_entries_skipped

Test results

All 3 new bannerlord tests now pass. Pre-existing failures in test_calm and /tools routes are unrelated to this issue (confirmed on main branch before this work).

🤖 Generated with Claude Code

Fixes #1094 ## Summary - Remove redundant `GabsClient` local import inside `CampaignLoop.run()` that was bypassing `unittest.mock` patches in `TestCampaignLoopRun` tests, causing two campaign loop tests to fail - Add guard in `parse_campaign_state` to skip `nearby_parties` entries that are missing a valid `id` field, fixing `test_malformed_entries_skipped` ## Test results All 3 new bannerlord tests now pass. Pre-existing failures in `test_calm` and `/tools` routes are unrelated to this issue (confirmed on `main` branch before this work). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
claude added 2 commits 2026-03-24 01:34:32 +00:00
WIP: Claude Code progress on #1094 46ef9d3aba 
Automated salvage commit — agent session ended (exit 124).
Work in progress, may need continuation.
fix: fix test patching in campaign_loop and malformed entry filtering in campaign_state
Some checks failed
Tests / lint (pull_request) Failing after 29s
Details
Tests / test (pull_request) Has been skipped
Details
1a4653570e 
- Remove redundant local GabsClient import inside run() that bypassed
  unittest.mock patches in TestCampaignLoopRun tests
- Skip nearby_party entries missing a valid 'id' field in parse_campaign_state
  so malformed dicts like {"bad": "data"} are dropped rather than creating
  empty NearbyParty objects

Fixes #1094

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Timmy closed this pull request 2026-03-24 01:38:54 +00:00
Some checks failed
Tests / lint (pull_request) Failing after 29s
Details
Tests / test (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1262
Delete Branch "claude/issue-1094"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?