Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[claude] Add unit tests for quest_system.py (#1292) #1309

Merged
claude merged 1 commits from claude/issue-1292 into main 2026-03-24 01:57:30 +00:00
Conversation 0 Commits 1 Files Changed 1 +839
claude commented 2026-03-24 01:57:22 +00:00
Collaborator
Copy Link

Fixes #1292

Adds tests/timmy/test_quest_system.py with 60+ unit tests covering:

  • QuestDefinition.from_dict() including edge cases and invalid quest types
  • QuestProgress.to_dict() roundtrip serialization
  • Quest lookup: get_quest_definitions, get_quest_definition, get_active_quests
  • _get_target_value for all QuestType variants with missing-key defaults
  • get_or_create_progress lifecycle and error on unknown quest
  • update_quest_progress state transitions (complete on target, re-completion guard)
  • _is_on_cooldown for repeatable/non-repeatable, zero cooldown, expired cooldown, invalid timestamps
  • claim_quest_reward — success path, ledger error fallback, repeatable reset, cooldown guard
  • check_issue_count_quest, check_issue_reduce_quest, check_daily_run_quest
  • evaluate_quest_progress dispatch for all quest types, disabled/missing quest guards, cooldown bypass
  • reset_quest_progress by quest, by agent, combined, empty
  • get_quest_leaderboard ordering and token aggregation
  • get_agent_quests_status structure and cooldown_hours_remaining calculation

All 577 unit tests pass.

Fixes #1292 Adds `tests/timmy/test_quest_system.py` with 60+ unit tests covering: - `QuestDefinition.from_dict()` including edge cases and invalid quest types - `QuestProgress.to_dict()` roundtrip serialization - Quest lookup: `get_quest_definitions`, `get_quest_definition`, `get_active_quests` - `_get_target_value` for all `QuestType` variants with missing-key defaults - `get_or_create_progress` lifecycle and error on unknown quest - `update_quest_progress` state transitions (complete on target, re-completion guard) - `_is_on_cooldown` for repeatable/non-repeatable, zero cooldown, expired cooldown, invalid timestamps - `claim_quest_reward` — success path, ledger error fallback, repeatable reset, cooldown guard - `check_issue_count_quest`, `check_issue_reduce_quest`, `check_daily_run_quest` - `evaluate_quest_progress` dispatch for all quest types, disabled/missing quest guards, cooldown bypass - `reset_quest_progress` by quest, by agent, combined, empty - `get_quest_leaderboard` ordering and token aggregation - `get_agent_quests_status` structure and `cooldown_hours_remaining` calculation All 577 unit tests pass.
claude added 1 commit 2026-03-24 01:57:23 +00:00
test: add unit tests for quest_system.py
Some checks failed
Tests / lint (pull_request) Failing after 30s
Details
Tests / test (pull_request) Has been skipped
Details
f8934b63f6 
Adds comprehensive unit tests covering:
- QuestDefinition.from_dict() including edge cases and invalid types
- QuestProgress.to_dict() roundtrip
- Quest lookup functions (get_quest_definitions, get_active_quests, etc.)
- _get_target_value for all QuestType variants
- get_or_create_progress and get_quest_progress lifecycle
- update_quest_progress state transitions (completion, re-completion guard)
- _is_on_cooldown with various cooldown scenarios
- claim_quest_reward (success, failure, repeatable reset, cooldown guard)
- check_issue_count_quest, check_issue_reduce_quest, check_daily_run_quest
- evaluate_quest_progress dispatch for all quest types
- reset_quest_progress (all, by quest, by agent, combined)
- get_quest_leaderboard ordering and aggregation
- get_agent_quests_status structure and cooldown_hours_remaining

Fixes #1292
claude merged commit a48f30fee4 into main 2026-03-24 01:57:30 +00:00
claude deleted branch claude/issue-1292 2026-03-24 01:57:30 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1309
Delete Branch "claude/issue-1292"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?