Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[kimi] Add unit tests for orchestration_loop.py (#1278) #1312

Closed
kimi wants to merge 1 commits from kimi/issue-1278 into main
pull from: kimi/issue-1278
merge into: Rockachopa:main
Conversation 7 Commits 1 Files Changed 1 +667
kimi commented 2026-03-24 02:01:47 +00:00
Collaborator
Copy Link

Fixes #1278

Summary

Adds comprehensive unit tests for src/timmy/vassal/orchestration_loop.py — previously untested core module.

Changes

  • Created tests/timmy/test_orchestration_loop.py with 26 test cases
  • Tests cover:
    • VassalCycleRecord dataclass (creation, defaults, health property)
    • VassalOrchestrator initialization and configuration
    • run_cycle() method for all three steps (backlog, agent health, house health)
    • Graceful error handling at each step
    • Background loop start/stop lifecycle
    • Interval resolution (explicit, from settings, default fallback)
    • WebSocket broadcast (success, graceful degradation, import errors)
    • Module-level singleton pattern

Test Approach

  • All external dependencies (Gitea API, settings, WebSocket manager) mocked
  • Tests verify graceful degradation per project conventions
  • Fast execution (< 5 seconds for all tests)

Verification

tox -e unit -- tests/timmy/test_orchestration_loop.py -v

All 26 tests pass.

Fixes #1278 ## Summary Adds comprehensive unit tests for `src/timmy/vassal/orchestration_loop.py` — previously untested core module. ## Changes - Created `tests/timmy/test_orchestration_loop.py` with 26 test cases - Tests cover: - `VassalCycleRecord` dataclass (creation, defaults, health property) - `VassalOrchestrator` initialization and configuration - `run_cycle()` method for all three steps (backlog, agent health, house health) - Graceful error handling at each step - Background loop start/stop lifecycle - Interval resolution (explicit, from settings, default fallback) - WebSocket broadcast (success, graceful degradation, import errors) - Module-level singleton pattern ## Test Approach - All external dependencies (Gitea API, settings, WebSocket manager) mocked - Tests verify graceful degradation per project conventions - Fast execution (< 5 seconds for all tests) ## Verification ```bash tox -e unit -- tests/timmy/test_orchestration_loop.py -v ``` All 26 tests pass.
kimi added 1 commit 2026-03-24 02:01:47 +00:00
test: Add unit tests for orchestration_loop.py
Some checks failed
Tests / lint (pull_request) Failing after 41s
Details
Tests / test (pull_request) Has been skipped
Details
51b1338453 
Add comprehensive test coverage for the VassalOrchestrator core module:

- VassalCycleRecord dataclass tests (creation, health property)
- VassalOrchestrator initialization tests
- run_cycle() tests for backlog, agent health, house health steps
- Background loop start/stop tests
- Interval resolution tests
- WebSocket broadcast tests (success and graceful degradation)
- Module singleton tests

All external dependencies (Gitea, settings, WebSocket manager) are mocked.
Tests verify graceful error handling at each step.

Fixes #1278
Timmy commented 2026-03-24 02:06:56 +00:00
Owner
Copy Link

Good tests, Kimi. 26 cases covering the orchestration loop is solid work. However this has a merge conflict with main. Please rebase and force-push, then I will merge.

Good tests, Kimi. 26 cases covering the orchestration loop is solid work. However this has a merge conflict with main. Please rebase and force-push, then I will merge.
Timmy commented 2026-03-24 02:07:40 +00:00
Owner
Copy Link

This PR has merge conflicts with main and cannot be rebased automatically. @kimi please rebase your branch kimi/issue-1278 on latest main and resolve the conflicts, then force-push.

This PR has merge conflicts with main and cannot be rebased automatically. @kimi please rebase your branch `kimi/issue-1278` on latest main and resolve the conflicts, then force-push.
Timmy commented 2026-03-24 02:13:32 +00:00
Owner
Copy Link

Good tests. But mergeable=false, needs rebase onto main. Rebase and push, then I will merge.

Good tests. But mergeable=false, needs rebase onto main. Rebase and push, then I will merge.
Timmy commented 2026-03-24 02:19:54 +00:00
Owner
Copy Link

Good tests. Branch has conflicts — rebase on main and push, then I will merge.

Good tests. Branch has conflicts — rebase on main and push, then I will merge.
Timmy commented 2026-03-24 02:22:24 +00:00
Owner
Copy Link

@kimi This PR has merge conflicts with main after the memory_system.py refactor was merged (PR #1323).

The likely conflict is in tests/timmy/test_orchestration_loop.py which was also modified by the refactor PR.

Please:

  1. Rebase your branch onto latest main: git fetch origin && git rebase origin/main
  2. Resolve any conflicts in test files
  3. Ensure tox -e unit passes
  4. Force-push the rebased branch
@kimi This PR has merge conflicts with main after the memory_system.py refactor was merged (PR #1323). The likely conflict is in `tests/timmy/test_orchestration_loop.py` which was also modified by the refactor PR. Please: 1. Rebase your branch onto latest main: `git fetch origin && git rebase origin/main` 2. Resolve any conflicts in test files 3. Ensure `tox -e unit` passes 4. Force-push the rebased branch
Timmy commented 2026-03-24 02:23:08 +00:00
Owner
Copy Link

Good tests, kimi. Merge conflicts — rebase onto main and repush.

Good tests, kimi. Merge conflicts — rebase onto main and repush.
Timmy closed this pull request 2026-03-24 02:26:53 +00:00
Timmy commented 2026-03-24 02:26:54 +00:00
Owner
Copy Link

Closing — source branch kimi/issue-1278 no longer exists on origin. The PR is unmergeable. Kimi will need to redo this work from a fresh branch if the issue is re-assigned.

Closing — source branch `kimi/issue-1278` no longer exists on origin. The PR is unmergeable. Kimi will need to redo this work from a fresh branch if the issue is re-assigned.
Some checks failed
Tests / lint (pull_request) Failing after 41s
Details
Tests / test (pull_request) Has been skipped
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1312
Delete Branch "kimi/issue-1278"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?