Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: add unit tests for memory/embeddings.py #440

Closed
kimi wants to merge 0 commits from kimi/issue-431 into main
pull from: kimi/issue-431
merge into: Rockachopa:main
Conversation 1 Commits - Files Changed -
kimi commented 2026-03-19 15:13:34 +00:00
Collaborator
Copy Link

Adds unit tests for timmy.memory.embeddings covering:

  • _simple_hash_embedding (determinism, normalization, edge cases)
  • cosine_similarity (identical, orthogonal, opposite, zero vectors)
  • _keyword_overlap (full, partial, no overlap, case insensitivity)
  • embed_text (fallback path and model path with mocking)
  • _get_embedding_model (skip setting, import errors)

Fixes #431

Adds unit tests for `timmy.memory.embeddings` covering: - `_simple_hash_embedding` (determinism, normalization, edge cases) - `cosine_similarity` (identical, orthogonal, opposite, zero vectors) - `_keyword_overlap` (full, partial, no overlap, case insensitivity) - `embed_text` (fallback path and model path with mocking) - `_get_embedding_model` (skip setting, import errors) Fixes #431
kimi added 1 commit 2026-03-19 15:13:34 +00:00
fix: add unit tests for memory/embeddings.py
All checks were successful
Tests / lint (pull_request) Successful in 2s
Details
Tests / test (pull_request) Successful in 1m9s
Details
ab0363f700 
Tests cover _simple_hash_embedding, cosine_similarity, _keyword_overlap,
embed_text, and _get_embedding_model with proper mocking of the global
model state.

Fixes #431

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Timmy commented 2026-03-19 15:17:04 +00:00
Owner
Copy Link

Closing as duplicate. PR#437 already merged equivalent embedding tests as tests/unit/test_memory_embeddings.py. This PR adds a near-identical test_embeddings.py — same coverage, same patterns. No need for both.

Closing as duplicate. PR#437 already merged equivalent embedding tests as `tests/unit/test_memory_embeddings.py`. This PR adds a near-identical `test_embeddings.py` — same coverage, same patterns. No need for both.
Timmy closed this pull request 2026-03-19 15:17:04 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#440
Delete Branch "kimi/issue-431"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?