Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: break up capture_error() into testable helpers #527

Closed
kimi wants to merge 0 commits from kimi/issue-506 into main
pull from: kimi/issue-506
merge into: Rockachopa:main
Conversation 1 Commits - Files Changed -
kimi commented 2026-03-20 00:05:52 +00:00
Collaborator
Copy Link

Fixes #506

Extract 5 focused helpers from the 138-line capture_error():

  • _extract_origin(): walk traceback for file/line
  • _log_error_event(): log to event log (best-effort)
  • _create_bug_report(): create task and log creation event
  • _send_error_notification(): push notification
  • _record_to_session(): forward to session recorder

capture_error() now orchestrates the helpers in ~25 lines. Added tests for each new helper.

Fixes #506 Extract 5 focused helpers from the 138-line `capture_error()`: - `_extract_origin()`: walk traceback for file/line - `_log_error_event()`: log to event log (best-effort) - `_create_bug_report()`: create task and log creation event - `_send_error_notification()`: push notification - `_record_to_session()`: forward to session recorder `capture_error()` now orchestrates the helpers in ~25 lines. Added tests for each new helper.
kimi added 1 commit 2026-03-20 00:05:53 +00:00
refactor: break up capture_error() into testable helpers
All checks were successful
Tests / lint (pull_request) Successful in 5s
Details
Tests / test (pull_request) Successful in 1m18s
Details
7bb6f15c33 
Extract 5 focused helpers from the 138-line capture_error():
- _extract_origin(): walk traceback for file/line
- _log_error_event(): log to event log (best-effort)
- _create_bug_report(): create task and log creation event
- _send_error_notification(): push notification
- _record_to_session(): forward to session recorder

capture_error() now orchestrates the helpers in ~25 lines.
Added tests for each new helper.

Fixes #506

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Timmy closed this pull request 2026-03-20 00:12:37 +00:00
Timmy commented 2026-03-20 00:12:41 +00:00
Owner
Copy Link

Closing as duplicate — PR #523 already merged this refactor and issue #506 is closed.

Closing as duplicate — PR #523 already merged this refactor and issue #506 is closed.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok kimi manus perplexity Rockachopa
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#527
Delete Branch "kimi/issue-506"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?