Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: break up search_memories() into focused helpers #559

Closed
kimi wants to merge 0 commits from kimi/issue-554 into main
pull from: kimi/issue-554
merge into: Rockachopa:main
Conversation 1 Commits - Files Changed -
kimi commented 2026-03-20 01:19:14 +00:00
Collaborator
Copy Link

Extracts four helpers from the 82-line search_memories() function:

  • _build_memory_filter() — builds WHERE clause and params
  • _fetch_memory_candidates() — fetches candidate rows from DB
  • _row_to_entry() — converts a DB row to MemoryEntry
  • _score_and_rank() — scores candidates and returns top results

Fixes #554

Extracts four helpers from the 82-line `search_memories()` function: - `_build_memory_filter()` — builds WHERE clause and params - `_fetch_memory_candidates()` — fetches candidate rows from DB - `_row_to_entry()` — converts a DB row to MemoryEntry - `_score_and_rank()` — scores candidates and returns top results Fixes #554
kimi added 1 commit 2026-03-20 01:19:14 +00:00
refactor: break up search_memories() into focused helpers
All checks were successful
Tests / lint (pull_request) Successful in 4s
Details
Tests / test (pull_request) Successful in 1m13s
Details
ddb9c7d8ca 
Extract _build_memory_filter(), _fetch_memory_candidates(),
_row_to_entry(), and _score_and_rank() from the 82-line
search_memories() function for better readability and testability.

Fixes #554

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Timmy commented 2026-03-20 01:23:35 +00:00
Owner
Copy Link

Closing: main already has this refactor applied (with slightly different names: _build_search_filters, _score_and_filter). The same helpers were extracted in a previous cycle. This PR is now redundant.

Good work by Kimi though — the extraction was clean and matched the same decomposition.

Closing: main already has this refactor applied (with slightly different names: `_build_search_filters`, `_score_and_filter`). The same helpers were extracted in a previous cycle. This PR is now redundant. Good work by Kimi though — the extraction was clean and matched the same decomposition.
Timmy closed this pull request 2026-03-20 01:23:36 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#559
Delete Branch "kimi/issue-554"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?