Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: wake thinking scheduler immediately on user message #586

Closed
kimi wants to merge 0 commits from kimi/issue-582 into main
pull from: kimi/issue-582
merge into: Rockachopa:main
Conversation 2 Commits - Files Changed -
kimi commented 2026-03-20 15:37:02 +00:00
Collaborator
Copy Link

Summary

The thinking scheduler slept for a fixed 5-minute interval between cycles (asyncio.sleep(settings.thinking_interval_seconds)). When a user sent a message, record_user_input() only reset the idle timer but did NOT wake the scheduler. Worst case: a message arriving right after a cycle completed would wait ~11 minutes (5 min sleep + 2 min timeout + 5 min sleep) before being "registered" as a thought.

Fix

  • Added an asyncio.Event to ThinkingEngine that gets set when record_user_input() is called
  • Added wait_for_interval() method that replaces the fixed asyncio.sleep() with an interruptible wait
  • The scheduler now wakes immediately when a user message arrives, triggering a thought cycle without delay

Files changed

  • src/timmy/thinking.py — Added _wake_event, _get_wake_event(), updated record_user_input(), added wait_for_interval()
  • src/dashboard/app.py — Replaced asyncio.sleep() with thinking_engine.wait_for_interval()

Fixes #582

## Summary The thinking scheduler slept for a fixed 5-minute interval between cycles (`asyncio.sleep(settings.thinking_interval_seconds)`). When a user sent a message, `record_user_input()` only reset the idle timer but did NOT wake the scheduler. Worst case: a message arriving right after a cycle completed would wait ~11 minutes (5 min sleep + 2 min timeout + 5 min sleep) before being "registered" as a thought. ## Fix - Added an `asyncio.Event` to `ThinkingEngine` that gets set when `record_user_input()` is called - Added `wait_for_interval()` method that replaces the fixed `asyncio.sleep()` with an interruptible wait - The scheduler now wakes immediately when a user message arrives, triggering a thought cycle without delay ## Files changed - `src/timmy/thinking.py` — Added `_wake_event`, `_get_wake_event()`, updated `record_user_input()`, added `wait_for_interval()` - `src/dashboard/app.py` — Replaced `asyncio.sleep()` with `thinking_engine.wait_for_interval()` Fixes #582
kimi added 3 commits 2026-03-20 15:37:03 +00:00
fix: capture thought timestamp at cycle start, not after LLM call c5b2809f61 
The thinking engine was recording created_at after the LLM finished
generating a response, causing up to 11 minutes of timestamp drift
(interval wait + model latency + dedup retries). Now the timestamp
is captured at the beginning of think_once() and passed through to
_store_thought(), so thoughts reflect when the cycle started.

Fixes #582

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
[loop-cycle-1233] refactor: break up BaseAgent.run() (#561) (#584) 4df58e32d6
fix: capture thought timestamp at cycle start, not after LLM call
All checks were successful
Tests / lint (pull_request) Successful in 5s
Details
Tests / test (pull_request) Successful in 1m12s
Details
1dd0f3ffe1 
The thinking engine was recording created_at after the LLM generation
completed. With dedup retries and model latency this could accumulate
up to ~11 minutes of drift. Capture the timestamp before the LLM call
so the thought reflects when the cycle started.

Fixes #582

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Timmy commented 2026-03-20 15:44:22 +00:00
Owner
Copy Link

@kimi This PR has merge conflicts with main. Please rebase your branch kimi/issue-582 onto latest main and force-push.

@kimi This PR has merge conflicts with main. Please rebase your branch `kimi/issue-582` onto latest main and force-push.
kimi added 1 commit 2026-03-20 15:44:30 +00:00
fix: wake thinking scheduler immediately on user message
All checks were successful
Tests / lint (pull_request) Successful in 2s
Details
Tests / test (pull_request) Successful in 1m11s
Details
53d85491bd 
The thinking scheduler slept for a fixed 5-minute interval between
cycles, meaning user messages could wait up to ~11 minutes before
being "registered" as a thought. Replace the fixed asyncio.sleep()
with an interruptible wait using asyncio.Event that wakes immediately
when record_user_input() is called.

Fixes #582

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kimi changed title from fix: capture thought timestamp at cycle start, not after LLM call to fix: wake thinking scheduler immediately on user message 2026-03-20 15:44:43 +00:00
Timmy closed this pull request 2026-03-20 15:52:08 +00:00
Timmy commented 2026-03-20 15:52:09 +00:00
Owner
Copy Link

Closing PR — source branch was deleted. The fix described in this issue is still valid. Reopening the issue for re-implementation.

Closing PR — source branch was deleted. The fix described in this issue is still valid. Reopening the issue for re-implementation.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#586
Delete Branch "kimi/issue-582"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?