Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove stale model_size kwarg from CLI create_timmy() calls #607

Closed
kimi wants to merge 0 commits from kimi/issue-604 into main
pull from: kimi/issue-604
merge into: Rockachopa:main
Conversation 1 Commits - Files Changed -
kimi commented 2026-03-20 16:50:02 +00:00
Collaborator
Copy Link

The model_size parameter was removed from create_timmy() but three CLI commands (think, chat, status) still passed it, causing TypeError crashes.

Changes:

  • Remove model_size=model_size from 3 call sites in src/timmy/cli.py
  • Update test to verify --model-size is accepted but not forwarded

Fixes #604

The `model_size` parameter was removed from `create_timmy()` but three CLI commands (`think`, `chat`, `status`) still passed it, causing `TypeError` crashes. **Changes:** - Remove `model_size=model_size` from 3 call sites in `src/timmy/cli.py` - Update test to verify `--model-size` is accepted but not forwarded Fixes #604
kimi added 1 commit 2026-03-20 16:50:02 +00:00
fix: remove stale model_size kwarg from CLI create_timmy() calls
All checks were successful
Tests / lint (pull_request) Successful in 6s
Details
Tests / test (pull_request) Successful in 1m10s
Details
f32b5a9e4d 
The model_size parameter was removed from create_timmy() but three CLI
commands (think, chat, status) still passed it, causing TypeError crashes.

Fixes #604

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Timmy closed this pull request 2026-03-20 16:56:36 +00:00
Timmy commented 2026-03-20 16:56:36 +00:00
Owner
Copy Link

Closing — the create_timmy() calls on main already omit model_size (lines 142, 205, 282 of cli.py). Tests pass clean (2106 passed). This PR is a duplicate of work already merged.

Closing — the create_timmy() calls on main already omit model_size (lines 142, 205, 282 of cli.py). Tests pass clean (2106 passed). This PR is a duplicate of work already merged.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#607
Delete Branch "kimi/issue-604"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?