test: add tests for issue body parser (#90)

scripts/gitea_issue_parser.py

@@ -0,0 +1,162 @@
+#!/usr/bin/env python3
+"""
+Gitea Issue Body Parser
+
+Extracts structured data from Gitea issue markdown bodies:
+- Title
+- Context section
+- Acceptance criteria (checkboxes)
+- Labels
+- Epic/parent references
+
+Usage:
+  python3 scripts/gitea_issue_parser.py <issue_body.txt
+  python3 scripts/gitea_issue_parser.py --url https://forge.../api/v1/repos/.../issues/123
+  echo "issue body" | python3 scripts/gitea_issue_parser.py --stdin
+
+Output: JSON with {title, context, criteria[], labels[], epic_ref}
+"""
+
+import argparse
+import json
+import re
+import sys
+from typing import Optional
+
+
+def parse_issue_body(body: str, title: str = "", labels: list = None) -> dict:
+    """Parse a Gitea issue body into structured JSON."""
+    result = {
+        "title": title,
+        "context": "",
+        "criteria": [],
+        "labels": labels or [],
+        "epic_ref": None,
+        "sections": {},
+    }
+
+    if not body:
+        return result
+
+    # Extract epic/parent reference from title or body
+    epic_pattern = r"#(\d+)"
+    title_refs = re.findall(epic_pattern, title)
+    body_refs = re.findall(epic_pattern, body[:200])  # Check early body refs
+
+    # Look for "Closes #N" or "Part of #N" or "Epic: #N"
+    close_match = re.search(r"(?:Closes?|Fixes?|Resolves?)\s+#(\d+)", body, re.IGNORECASE)
+    part_match = re.search(r"(?:Part of|Epic|Parent|Blocks?)\s+#(\d+)", body, re.IGNORECASE)
+
+    if close_match:
+        result["epic_ref"] = f"#{close_match.group(1)}"
+    elif part_match:
+        result["epic_ref"] = f"#{part_match.group(1)}"
+    elif title_refs:
+        result["epic_ref"] = f"#{title_refs[0]}"
+    elif body_refs:
+        result["epic_ref"] = f"#{body_refs[0]}"
+
+    # Split into sections by ## headers
+    section_pattern = r"^##\s+(.+)$"
+    lines = body.split("\n")
+    current_section = None
+    current_content = []
+
+    for line in lines:
+        header_match = re.match(section_pattern, line)
+        if header_match:
+            # Save previous section
+            if current_section:
+                result["sections"][current_section] = "\n".join(current_content).strip()
+            current_section = header_match.group(1).strip().lower()
+            current_content = []
+        else:
+            current_content.append(line)
+
+    # Save last section
+    if current_section:
+        result["sections"][current_section] = "\n".join(current_content).strip()
+
+    # Extract context
+    for key in ["context", "background", "description", "problem"]:
+        if key in result["sections"]:
+            result["context"] = result["sections"][key]
+            break
+
+    # Extract acceptance criteria (checkboxes)
+    criteria_section = None
+    for key in ["acceptance criteria", "acceptance_criteria", "criteria", "requirements", "definition of done"]:
+        if key in result["sections"]:
+            criteria_section = result["sections"][key]
+            break
+
+    if criteria_section:
+        checkbox_pattern = r"-\s*\[[ xX]?\]\s*(.+)"
+        for match in re.finditer(checkbox_pattern, criteria_section):
+            result["criteria"].append(match.group(1).strip())
+
+        # Also try plain numbered/bulleted lists if no checkboxes found
+        if not result["criteria"]:
+            list_pattern = r"^\s*(?:\d+\.|-|\*)\s+(.+)"
+            for match in re.finditer(list_pattern, criteria_section, re.MULTILINE):
+                result["criteria"].append(match.group(1).strip())
+
+    # If no sectioned criteria found, scan whole body for checkboxes
+    if not result["criteria"]:
+        for match in re.finditer(r"-\s*\[[ xX]?\]\s*(.+)", body):
+            result["criteria"].append(match.group(1).strip())
+
+    return result
+
+
+def parse_from_url(api_url: str, token: str = None) -> dict:
+    """Parse an issue from a Gitea API URL."""
+    import urllib.request
+
+    headers = {}
+    if token:
+        headers["Authorization"] = f"token {token}"
+
+    req = urllib.request.Request(api_url, headers=headers)
+    resp = json.loads(urllib.request.urlopen(req, timeout=30).read())
+
+    title = resp.get("title", "")
+    body = resp.get("body", "")
+    labels = [l["name"] for l in resp.get("labels", [])]
+
+    return parse_issue_body(body, title, labels)
+
+
+def main():
+    parser = argparse.ArgumentParser(description="Parse Gitea issue body into structured JSON")
+    parser.add_argument("input", nargs="?", help="Issue body file (or - for stdin)")
+    parser.add_argument("--url", help="Gitea API URL for the issue")
+    parser.add_argument("--stdin", action="store_true", help="Read from stdin")
+    parser.add_argument("--token", help="Gitea API token (or set GITEA_TOKEN env var)")
+    parser.add_argument("--title", default="", help="Issue title (for epic ref extraction)")
+    parser.add_argument("--labels", nargs="*", default=[], help="Issue labels")
+    parser.add_argument("--pretty", action="store_true", help="Pretty-print JSON output")
+    args = parser.parse_args()
+
+    import os
+    token = args.token or os.environ.get("GITEA_TOKEN")
+
+    if args.url:
+        result = parse_from_url(args.url, token)
+    elif args.stdin or (args.input and args.input == "-"):
+        body = sys.stdin.read()
+        result = parse_issue_body(body, args.title, args.labels)
+    elif args.input:
+        with open(args.input) as f:
+            body = f.read()
+        result = parse_issue_body(body, args.title, args.labels)
+    else:
+        parser.print_help()
+        sys.exit(1)
+
+    indent = 2 if args.pretty else None
+    print(json.dumps(result, indent=indent))
+
+
+if __name__ == "__main__":
+    main()

scripts/knowledge_staleness_check.py

@@ -1,131 +0,0 @@
-#!/usr/bin/env python3
-"""
-Knowledge Store Staleness Detector — Detect stale knowledge entries by comparing source file hashes.
-
-Usage:
-    python3 scripts/knowledge_staleness_check.py --index knowledge/index.json
-    python3 scripts/knowledge_staleness_check.py --index knowledge/index.json --json
-    python3 scripts/knowledge_staleness_check.py --index knowledge/index.json --fix
-"""
-
-import argparse
-import hashlib
-import json
-import os
-import sys
-from datetime import datetime, timezone
-from pathlib import Path
-from typing import Dict, List, Any, Optional
-
-
-def compute_file_hash(filepath: str) -> Optional[str]:
-    """Compute SHA-256 hash of a file. Returns None if file doesn't exist."""
-    try:
-        with open(filepath, "rb") as f:
-            return "sha256:" + hashlib.sha256(f.read()).hexdigest()
-    except (FileNotFoundError, IsADirectoryError, PermissionError):
-        return None
-
-
-def check_staleness(index_path: str, repo_root: str = ".") -> List[Dict[str, Any]]:
-    """Check all entries in knowledge index for staleness.
-    
-    Returns list of entries with staleness info:
-    - status: "fresh" | "stale" | "missing_source" | "no_hash"
-    - current_hash: computed hash (if source exists)
-    - stored_hash: hash from index
-    """
-    with open(index_path) as f:
-        data = json.load(f)
-
-    facts = data.get("facts", [])
-    results = []
-
-    for entry in facts:
-        source_file = entry.get("source_file")
-        stored_hash = entry.get("source_hash")
-
-        if not source_file:
-            results.append({**entry, "status": "no_source", "current_hash": None})
-            continue
-
-        full_path = os.path.join(repo_root, source_file)
-        current_hash = compute_file_hash(full_path)
-
-        if current_hash is None:
-            results.append({**entry, "status": "missing_source", "current_hash": None})
-        elif not stored_hash:
-            results.append({**entry, "status": "no_hash", "current_hash": current_hash})
-        elif current_hash != stored_hash:
-            results.append({**entry, "status": "stale", "current_hash": current_hash})
-        else:
-            results.append({**entry, "status": "fresh", "current_hash": current_hash})
-
-    return results
-
-
-def fix_hashes(index_path: str, repo_root: str = ".") -> int:
-    """Add hashes to entries missing them. Returns count of fixed entries."""
-    with open(index_path) as f:
-        data = json.load(f)
-
-    fixed = 0
-    for entry in data.get("facts", []):
-        if entry.get("source_hash"):
-            continue
-        source_file = entry.get("source_file")
-        if not source_file:
-            continue
-        full_path = os.path.join(repo_root, source_file)
-        h = compute_file_hash(full_path)
-        if h:
-            entry["source_hash"] = h
-            fixed += 1
-
-    with open(index_path, "w") as f:
-        json.dump(data, f, indent=2)
-
-    return fixed
-
-
-def main():
-    parser = argparse.ArgumentParser(description="Check knowledge store staleness")
-    parser.add_argument("--index", required=True, help="Path to knowledge/index.json")
-    parser.add_argument("--repo", default=".", help="Repo root for source file resolution")
-    parser.add_argument("--json", action="store_true", help="Output as JSON")
-    parser.add_argument("--fix", action="store_true", help="Add hashes to entries missing them")
-
-    args = parser.parse_args()
-
-    if args.fix:
-        fixed = fix_hashes(args.index, args.repo)
-        print(f"Fixed {fixed} entries with missing hashes.")
-        return
-
-    results = check_staleness(args.index, args.repo)
-
-    if args.json:
-        print(json.dumps(results, indent=2))
-    else:
-        stale = [r for r in results if r["status"] != "fresh"]
-        fresh = [r for r in results if r["status"] == "fresh"]
-
-        print(f"Knowledge Store Staleness Check")
-        print(f"  Total entries: {len(results)}")
-        print(f"  Fresh: {len(fresh)}")
-        print(f"  Stale/Issues: {len(stale)}")
-        print()
-
-        if stale:
-            print("Issues found:")
-            for r in stale:
-                status = r["status"]
-                fact = r.get("fact", "?")[:60]
-                source = r.get("source_file", "?")
-                print(f"  [{status}] {source}: {fact}")
-        else:
-            print("All entries are fresh!")
-
-
-if __name__ == "__main__":
-    main()

scripts/test_gitea_issue_parser.py

@@ -0,0 +1,111 @@
+#!/usr/bin/env python3
+"""Tests for gitea_issue_parser."""
+
+import json
+import sys
+import os
+
+sys.path.insert(0, os.path.dirname(__file__))
+from gitea_issue_parser import parse_issue_body
+
+
+def test_basic_structure():
+    body = """## Context
+This is the background.
+
+## Acceptance Criteria
+- [ ] First criterion
+- [x] Second criterion (already done)
+- [ ] Third criterion
+
+## Labels
+`pipeline`, `extraction`
+"""
+    result = parse_issue_body(body, "Test Issue", ["pipeline", "extraction"])
+    assert result["title"] == "Test Issue"
+    assert "background" in result["context"].lower()
+    assert len(result["criteria"]) == 3
+    assert "First criterion" in result["criteria"]
+    assert result["labels"] == ["pipeline", "extraction"]
+    print("PASS: test_basic_structure")
+
+
+def test_epic_ref():
+    body = "Closes #645\n\nSome description."
+    result = parse_issue_body(body, "feat: thing (#688)")
+    assert result["epic_ref"] == "#645"
+    print("PASS: test_epic_ref")
+
+
+def test_epic_ref_from_title():
+    body = "Some description without close ref."
+    result = parse_issue_body(body, "feat: scene descriptions (#645)")
+    assert result["epic_ref"] == "#645"
+    print("PASS: test_epic_ref_from_title")
+
+
+def test_no_checkboxes():
+    body = """## Requirements
+1. First thing
+2. Second thing
+3. Third thing
+"""
+    result = parse_issue_body(body)
+    assert len(result["criteria"]) == 3
+    print("PASS: test_no_checkboxes")
+
+
+def test_empty_body():
+    result = parse_issue_body("", "Empty Issue")
+    assert result["title"] == "Empty Issue"
+    assert result["criteria"] == []
+    assert result["context"] == ""
+    print("PASS: test_empty_body")
+
+
+def test_real_issue_format():
+    body = """Closes #681
+
+## Changes
+
+Add `#!/usr/bin/env python3` shebang to 6 Python scripts.
+
+## Verification
+
+All 6 files confirmed missing shebangs before fix.
+
+## Impact
+
+Scripts can now be executed directly.
+"""
+    result = parse_issue_body(body, "fix: add python3 shebangs (#685)")
+    assert result["epic_ref"] == "#681"
+    assert "shebang" in result["context"].lower()
+    print("PASS: test_real_issue_format")
+
+
+def test_all_sections_captured():
+    body = """## Context
+Background info.
+
+## Acceptance Criteria
+- [ ] Do thing
+
+## Labels
+`test`
+"""
+    result = parse_issue_body(body)
+    assert "context" in result["sections"]
+    assert "acceptance criteria" in result["sections"]
+    print("PASS: test_all_sections_captured")
+
+
+if __name__ == "__main__":
+    test_basic_structure()
+    test_epic_ref()
+    test_epic_ref_from_title()
+    test_no_checkboxes()
+    test_empty_body()
+    test_real_issue_format()
+    test_all_sections_captured()
+    print("\nAll tests passed.")

scripts/test_knowledge_staleness.py

@@ -1,129 +0,0 @@
-#!/usr/bin/env python3
-"""Tests for scripts/knowledge_staleness_check.py — 8 tests."""
-
-import json
-import os
-import sys
-import tempfile
-
-sys.path.insert(0, os.path.dirname(__file__) or ".")
-import importlib.util
-spec = importlib.util.spec_from_file_location("ks", os.path.join(os.path.dirname(__file__) or ".", "knowledge_staleness_check.py"))
-mod = importlib.util.module_from_spec(spec)
-spec.loader.exec_module(mod)
-check_staleness = mod.check_staleness
-fix_hashes = mod.fix_hashes
-compute_file_hash = mod.compute_file_hash
-
-
-def test_fresh_entry():
-    with tempfile.TemporaryDirectory() as tmpdir:
-        src = os.path.join(tmpdir, "source.py")
-        with open(src, "w") as f:
-            f.write("print('hello')")
-        h = compute_file_hash(src)
-        idx = os.path.join(tmpdir, "index.json")
-        with open(idx, "w") as f:
-            json.dump({"facts": [{"fact": "hello", "source_file": "source.py", "source_hash": h}]}, f)
-        results = check_staleness(idx, tmpdir)
-        assert results[0]["status"] == "fresh"
-        print("PASS: test_fresh_entry")
-
-
-def test_stale_entry():
-    with tempfile.TemporaryDirectory() as tmpdir:
-        src = os.path.join(tmpdir, "source.py")
-        with open(src, "w") as f:
-            f.write("original content")
-        idx = os.path.join(tmpdir, "index.json")
-        with open(idx, "w") as f:
-            json.dump({"facts": [{"fact": "old", "source_file": "source.py", "source_hash": "sha256:wrong"}]}, f)
-        # Now change the source
-        with open(src, "w") as f:
-            f.write("modified content")
-        results = check_staleness(idx, tmpdir)
-        assert results[0]["status"] == "stale"
-        print("PASS: test_stale_entry")
-
-
-def test_missing_source():
-    with tempfile.TemporaryDirectory() as tmpdir:
-        idx = os.path.join(tmpdir, "index.json")
-        with open(idx, "w") as f:
-            json.dump({"facts": [{"fact": "gone", "source_file": "nonexistent.py", "source_hash": "sha256:abc"}]}, f)
-        results = check_staleness(idx, tmpdir)
-        assert results[0]["status"] == "missing_source"
-        print("PASS: test_missing_source")
-
-
-def test_no_hash():
-    with tempfile.TemporaryDirectory() as tmpdir:
-        src = os.path.join(tmpdir, "source.py")
-        with open(src, "w") as f:
-            f.write("content")
-        idx = os.path.join(tmpdir, "index.json")
-        with open(idx, "w") as f:
-            json.dump({"facts": [{"fact": "no hash", "source_file": "source.py"}]}, f)
-        results = check_staleness(idx, tmpdir)
-        assert results[0]["status"] == "no_hash"
-        assert results[0]["current_hash"].startswith("sha256:")
-        print("PASS: test_no_hash")
-
-
-def test_no_source_field():
-    with tempfile.TemporaryDirectory() as tmpdir:
-        idx = os.path.join(tmpdir, "index.json")
-        with open(idx, "w") as f:
-            json.dump({"facts": [{"fact": "orphan"}]}, f)
-        results = check_staleness(idx, tmpdir)
-        assert results[0]["status"] == "no_source"
-        print("PASS: test_no_source_field")
-
-
-def test_fix_hashes():
-    with tempfile.TemporaryDirectory() as tmpdir:
-        src = os.path.join(tmpdir, "source.py")
-        with open(src, "w") as f:
-            f.write("content for hashing")
-        idx = os.path.join(tmpdir, "index.json")
-        with open(idx, "w") as f:
-            json.dump({"facts": [{"fact": "needs hash", "source_file": "source.py"}]}, f)
-        fixed = fix_hashes(idx, tmpdir)
-        assert fixed == 1
-        # Verify hash was added
-        with open(idx) as f:
-            data = json.load(f)
-        assert data["facts"][0]["source_hash"].startswith("sha256:")
-        print("PASS: test_fix_hashes")
-
-
-def test_empty_index():
-    with tempfile.TemporaryDirectory() as tmpdir:
-        idx = os.path.join(tmpdir, "index.json")
-        with open(idx, "w") as f:
-            json.dump({"facts": []}, f)
-        results = check_staleness(idx, tmpdir)
-        assert results == []
-        print("PASS: test_empty_index")
-
-
-def test_compute_hash_nonexistent():
-    h = compute_file_hash("/nonexistent/path/file.py")
-    assert h is None
-    print("PASS: test_compute_hash_nonexistent")
-
-
-def run_all():
-    test_fresh_entry()
-    test_stale_entry()
-    test_missing_source()
-    test_no_hash()
-    test_no_source_field()
-    test_fix_hashes()
-    test_empty_index()
-    test_compute_hash_nonexistent()
-    print("\nAll 8 tests passed!")
-
-
-if __name__ == "__main__":
-    run_all()