feat: add diff analyzer for PR change categorization (closes #118)

scripts/diff_analyzer.py

@@ -0,0 +1,239 @@
+"""
+Diff Analyzer — Pipeline 6.1
+
+Reads PR diffs and categorizes changes: new code, deleted code, modified code, moved code.
+Produces a change summary with line counts per category.
+
+Usage:
+    from diff_analyzer import DiffAnalyzer
+    analyzer = DiffAnalyzer()
+    summary = analyzer.analyze(diff_text)
+"""
+
+from __future__ import annotations
+
+import re
+from dataclasses import dataclass, field
+from enum import Enum
+from typing import List, Optional
+
+
+class ChangeCategory(Enum):
+    """Categories of code changes in a diff hunk."""
+    ADDED = "added"
+    DELETED = "deleted"
+    MODIFIED = "modified"
+    MOVED = "moved"
+    CONTEXT = "context"
+
+
+@dataclass
+class Hunk:
+    """A single diff hunk with metadata."""
+    header: str
+    old_start: int
+    old_count: int
+    new_start: int
+    new_count: int
+    lines: List[str] = field(default_factory=list)
+    category: ChangeCategory = ChangeCategory.CONTEXT
+    old_lines: int = 0
+    new_lines: int = 0
+
+
+@dataclass
+class FileChange:
+    """Changes within a single file."""
+    path: str
+    old_path: Optional[str] = None  # For renames
+    is_new: bool = False
+    is_deleted: bool = False
+    is_renamed: bool = False
+    hunks: List[Hunk] = field(default_factory=list)
+    added_lines: int = 0
+    deleted_lines: int = 0
+    context_lines: int = 0
+
+
+@dataclass
+class ChangeSummary:
+    """Summary of all changes in a diff."""
+    files_changed: int = 0
+    files_added: int = 0
+    files_deleted: int = 0
+    files_renamed: int = 0
+    files_modified: int = 0
+    total_added: int = 0
+    total_deleted: int = 0
+    total_context: int = 0
+    hunks_added: int = 0
+    hunks_deleted: int = 0
+    hunks_modified: int = 0
+    hunks_moved: int = 0
+    file_changes: List[FileChange] = field(default_factory=list)
+
+    def to_dict(self) -> dict:
+        """Serialize to dict for JSON output."""
+        return {
+            "files_changed": self.files_changed,
+            "files_added": self.files_added,
+            "files_deleted": self.files_deleted,
+            "files_renamed": self.files_renamed,
+            "files_modified": self.files_modified,
+            "total_added": self.total_added,
+            "total_deleted": self.total_deleted,
+            "total_context": self.total_context,
+            "hunks_added": self.hunks_added,
+            "hunks_deleted": self.hunks_deleted,
+            "hunks_modified": self.hunks_modified,
+            "hunks_moved": self.hunks_moved,
+            "files": [
+                {
+                    "path": fc.path,
+                    "old_path": fc.old_path,
+                    "is_new": fc.is_new,
+                    "is_deleted": fc.is_deleted,
+                    "is_renamed": fc.is_renamed,
+                    "added": fc.added_lines,
+                    "deleted": fc.deleted_lines,
+                    "context": fc.context_lines,
+                }
+                for fc in self.file_changes
+            ],
+        }
+
+
+# Regex for unified diff headers
+_HUNK_RE = re.compile(
+    r"^@@\s+-(\d+)(?:,(\d+))?\s+\+(\d+)(?:,(\d+))?\s+@@(.*)$"
+)
+_FILE_HEADER_RE = re.compile(r"^diff --git a/(.*) b/(.*)$")
+_RENAME_RE = re.compile(r"^rename from (.+)$|^rename to (.+)$")
+
+
+class DiffAnalyzer:
+    """Parses unified diffs and categorizes changes."""
+
+    def analyze(self, diff_text: str) -> ChangeSummary:
+        """Analyze a unified diff string and return a ChangeSummary."""
+        summary = ChangeSummary()
+        lines = diff_text.splitlines(keepends=False)
+
+        current_file: Optional[FileChange] = None
+        current_hunk: Optional[Hunk] = None
+        old_path: Optional[str] = None
+        new_path: Optional[str] = None
+
+        for line in lines:
+            # File header
+            m = _FILE_HEADER_RE.match(line)
+            if m:
+                # Save previous file
+                if current_file:
+                    self._classify_file(current_file)
+                    summary.file_changes.append(current_file)
+
+                old_path = m.group(1)
+                new_path = m.group(2)
+                current_file = FileChange(path=new_path, old_path=old_path)
+                current_hunk = None
+                continue
+
+            if current_file is None:
+                continue
+
+            # Detect new/deleted file markers
+            if line.startswith("new file mode"):
+                current_file.is_new = True
+                continue
+            if line.startswith("deleted file mode"):
+                current_file.is_deleted = True
+                continue
+
+            # Detect renames
+            rm = _RENAME_RE.match(line)
+            if rm:
+                current_file.is_renamed = True
+                continue
+
+            # Hunk header
+            hm = _HUNK_RE.match(line)
+            if hm:
+                if current_hunk:
+                    self._classify_hunk(current_hunk)
+                    current_file.hunks.append(current_hunk)
+
+                current_hunk = Hunk(
+                    header=line,
+                    old_start=int(hm.group(1)),
+                    old_count=int(hm.group(2) or 1),
+                    new_start=int(hm.group(3)),
+                    new_count=int(hm.group(4) or 1),
+                )
+                continue
+
+            if current_hunk is None:
+                continue
+
+            # Hunk content
+            current_hunk.lines.append(line)
+
+            if line.startswith("+"):
+                current_hunk.new_lines += 1
+                current_file.added_lines += 1
+            elif line.startswith("-"):
+                current_hunk.old_lines += 1
+                current_file.deleted_lines += 1
+            elif line.startswith(" "):
+                current_file.context_lines += 1
+
+        # Finalize last hunk and file
+        if current_hunk:
+            self._classify_hunk(current_hunk)
+            if current_file:
+                current_file.hunks.append(current_hunk)
+        if current_file:
+            self._classify_file(current_file)
+            summary.file_changes.append(current_file)
+
+        # Aggregate
+        summary.files_changed = len(summary.file_changes)
+        for fc in summary.file_changes:
+            summary.total_added += fc.added_lines
+            summary.total_deleted += fc.deleted_lines
+            summary.total_context += fc.context_lines
+            if fc.is_new:
+                summary.files_added += 1
+            elif fc.is_deleted:
+                summary.files_deleted += 1
+            elif fc.is_renamed:
+                summary.files_renamed += 1
+            else:
+                summary.files_modified += 1
+
+            for h in fc.hunks:
+                if h.category == ChangeCategory.ADDED:
+                    summary.hunks_added += 1
+                elif h.category == ChangeCategory.DELETED:
+                    summary.hunks_deleted += 1
+                elif h.category == ChangeCategory.MODIFIED:
+                    summary.hunks_modified += 1
+                elif h.category == ChangeCategory.MOVED:
+                    summary.hunks_moved += 1
+
+        return summary
+
+    def _classify_hunk(self, hunk: Hunk) -> None:
+        """Classify a hunk based on its add/delete ratio."""
+        if hunk.new_lines > 0 and hunk.old_lines == 0:
+            hunk.category = ChangeCategory.ADDED
+        elif hunk.old_lines > 0 and hunk.new_lines == 0:
+            hunk.category = ChangeCategory.DELETED
+        elif hunk.new_lines > 0 and hunk.old_lines > 0:
+            hunk.category = ChangeCategory.MODIFIED
+        else:
+            hunk.category = ChangeCategory.CONTEXT
+
+    def _classify_file(self, fc: FileChange) -> None:
+        """Final file classification (renames already detected via headers)."""
+        pass

scripts/gitea_issue_parser.py

@@ -1,162 +0,0 @@
-#!/usr/bin/env python3
-"""
-Gitea Issue Body Parser
-
-Extracts structured data from Gitea issue markdown bodies:
-- Title
-- Context section
-- Acceptance criteria (checkboxes)
-- Labels
-- Epic/parent references
-
-Usage:
-  python3 scripts/gitea_issue_parser.py <issue_body.txt
-  python3 scripts/gitea_issue_parser.py --url https://forge.../api/v1/repos/.../issues/123
-  echo "issue body" | python3 scripts/gitea_issue_parser.py --stdin
-
-Output: JSON with {title, context, criteria[], labels[], epic_ref}
-"""
-
-import argparse
-import json
-import re
-import sys
-from typing import Optional
-
-
-def parse_issue_body(body: str, title: str = "", labels: list = None) -> dict:
-    """Parse a Gitea issue body into structured JSON."""
-    result = {
-        "title": title,
-        "context": "",
-        "criteria": [],
-        "labels": labels or [],
-        "epic_ref": None,
-        "sections": {},
-    }
-
-    if not body:
-        return result
-
-    # Extract epic/parent reference from title or body
-    epic_pattern = r"#(\d+)"
-    title_refs = re.findall(epic_pattern, title)
-    body_refs = re.findall(epic_pattern, body[:200])  # Check early body refs
-
-    # Look for "Closes #N" or "Part of #N" or "Epic: #N"
-    close_match = re.search(r"(?:Closes?|Fixes?|Resolves?)\s+#(\d+)", body, re.IGNORECASE)
-    part_match = re.search(r"(?:Part of|Epic|Parent|Blocks?)\s+#(\d+)", body, re.IGNORECASE)
-
-    if close_match:
-        result["epic_ref"] = f"#{close_match.group(1)}"
-    elif part_match:
-        result["epic_ref"] = f"#{part_match.group(1)}"
-    elif title_refs:
-        result["epic_ref"] = f"#{title_refs[0]}"
-    elif body_refs:
-        result["epic_ref"] = f"#{body_refs[0]}"
-
-    # Split into sections by ## headers
-    section_pattern = r"^##\s+(.+)$"
-    lines = body.split("\n")
-    current_section = None
-    current_content = []
-
-    for line in lines:
-        header_match = re.match(section_pattern, line)
-        if header_match:
-            # Save previous section
-            if current_section:
-                result["sections"][current_section] = "\n".join(current_content).strip()
-            current_section = header_match.group(1).strip().lower()
-            current_content = []
-        else:
-            current_content.append(line)
-
-    # Save last section
-    if current_section:
-        result["sections"][current_section] = "\n".join(current_content).strip()
-
-    # Extract context
-    for key in ["context", "background", "description", "problem"]:
-        if key in result["sections"]:
-            result["context"] = result["sections"][key]
-            break
-
-    # Extract acceptance criteria (checkboxes)
-    criteria_section = None
-    for key in ["acceptance criteria", "acceptance_criteria", "criteria", "requirements", "definition of done"]:
-        if key in result["sections"]:
-            criteria_section = result["sections"][key]
-            break
-
-    if criteria_section:
-        checkbox_pattern = r"-\s*\[[ xX]?\]\s*(.+)"
-        for match in re.finditer(checkbox_pattern, criteria_section):
-            result["criteria"].append(match.group(1).strip())
-
-        # Also try plain numbered/bulleted lists if no checkboxes found
-        if not result["criteria"]:
-            list_pattern = r"^\s*(?:\d+\.|-|\*)\s+(.+)"
-            for match in re.finditer(list_pattern, criteria_section, re.MULTILINE):
-                result["criteria"].append(match.group(1).strip())
-
-    # If no sectioned criteria found, scan whole body for checkboxes
-    if not result["criteria"]:
-        for match in re.finditer(r"-\s*\[[ xX]?\]\s*(.+)", body):
-            result["criteria"].append(match.group(1).strip())
-
-    return result
-
-
-def parse_from_url(api_url: str, token: str = None) -> dict:
-    """Parse an issue from a Gitea API URL."""
-    import urllib.request
-
-    headers = {}
-    if token:
-        headers["Authorization"] = f"token {token}"
-
-    req = urllib.request.Request(api_url, headers=headers)
-    resp = json.loads(urllib.request.urlopen(req, timeout=30).read())
-
-    title = resp.get("title", "")
-    body = resp.get("body", "")
-    labels = [l["name"] for l in resp.get("labels", [])]
-
-    return parse_issue_body(body, title, labels)
-
-
-def main():
-    parser = argparse.ArgumentParser(description="Parse Gitea issue body into structured JSON")
-    parser.add_argument("input", nargs="?", help="Issue body file (or - for stdin)")
-    parser.add_argument("--url", help="Gitea API URL for the issue")
-    parser.add_argument("--stdin", action="store_true", help="Read from stdin")
-    parser.add_argument("--token", help="Gitea API token (or set GITEA_TOKEN env var)")
-    parser.add_argument("--title", default="", help="Issue title (for epic ref extraction)")
-    parser.add_argument("--labels", nargs="*", default=[], help="Issue labels")
-    parser.add_argument("--pretty", action="store_true", help="Pretty-print JSON output")
-    args = parser.parse_args()
-
-    import os
-    token = args.token or os.environ.get("GITEA_TOKEN")
-
-    if args.url:
-        result = parse_from_url(args.url, token)
-    elif args.stdin or (args.input and args.input == "-"):
-        body = sys.stdin.read()
-        result = parse_issue_body(body, args.title, args.labels)
-    elif args.input:
-        with open(args.input) as f:
-            body = f.read()
-        result = parse_issue_body(body, args.title, args.labels)
-    else:
-        parser.print_help()
-        sys.exit(1)
-
-    indent = 2 if args.pretty else None
-    print(json.dumps(result, indent=indent))
-
-
-if __name__ == "__main__":
-    main()

scripts/test_gitea_issue_parser.py

@@ -1,111 +0,0 @@
-#!/usr/bin/env python3
-"""Tests for gitea_issue_parser."""
-
-import json
-import sys
-import os
-
-sys.path.insert(0, os.path.dirname(__file__))
-from gitea_issue_parser import parse_issue_body
-
-
-def test_basic_structure():
-    body = """## Context
-This is the background.
-
-## Acceptance Criteria
-- [ ] First criterion
-- [x] Second criterion (already done)
-- [ ] Third criterion
-
-## Labels
-`pipeline`, `extraction`
-"""
-    result = parse_issue_body(body, "Test Issue", ["pipeline", "extraction"])
-    assert result["title"] == "Test Issue"
-    assert "background" in result["context"].lower()
-    assert len(result["criteria"]) == 3
-    assert "First criterion" in result["criteria"]
-    assert result["labels"] == ["pipeline", "extraction"]
-    print("PASS: test_basic_structure")
-
-
-def test_epic_ref():
-    body = "Closes #645\n\nSome description."
-    result = parse_issue_body(body, "feat: thing (#688)")
-    assert result["epic_ref"] == "#645"
-    print("PASS: test_epic_ref")
-
-
-def test_epic_ref_from_title():
-    body = "Some description without close ref."
-    result = parse_issue_body(body, "feat: scene descriptions (#645)")
-    assert result["epic_ref"] == "#645"
-    print("PASS: test_epic_ref_from_title")
-
-
-def test_no_checkboxes():
-    body = """## Requirements
-1. First thing
-2. Second thing
-3. Third thing
-"""
-    result = parse_issue_body(body)
-    assert len(result["criteria"]) == 3
-    print("PASS: test_no_checkboxes")
-
-
-def test_empty_body():
-    result = parse_issue_body("", "Empty Issue")
-    assert result["title"] == "Empty Issue"
-    assert result["criteria"] == []
-    assert result["context"] == ""
-    print("PASS: test_empty_body")
-
-
-def test_real_issue_format():
-    body = """Closes #681
-
-## Changes
-
-Add `#!/usr/bin/env python3` shebang to 6 Python scripts.
-
-## Verification
-
-All 6 files confirmed missing shebangs before fix.
-
-## Impact
-
-Scripts can now be executed directly.
-"""
-    result = parse_issue_body(body, "fix: add python3 shebangs (#685)")
-    assert result["epic_ref"] == "#681"
-    assert "shebang" in result["context"].lower()
-    print("PASS: test_real_issue_format")
-
-
-def test_all_sections_captured():
-    body = """## Context
-Background info.
-
-## Acceptance Criteria
-- [ ] Do thing
-
-## Labels
-`test`
-"""
-    result = parse_issue_body(body)
-    assert "context" in result["sections"]
-    assert "acceptance criteria" in result["sections"]
-    print("PASS: test_all_sections_captured")
-
-
-if __name__ == "__main__":
-    test_basic_structure()
-    test_epic_ref()
-    test_epic_ref_from_title()
-    test_no_checkboxes()
-    test_empty_body()
-    test_real_issue_format()
-    test_all_sections_captured()
-    print("\nAll tests passed.")

tests/test_diff_analyzer.py

@@ -0,0 +1,224 @@
+"""Tests for diff_analyzer module."""
+
+import sys
+import os
+sys.path.insert(0, os.path.join(os.path.dirname(__file__), '..', 'scripts'))
+
+from diff_analyzer import DiffAnalyzer, ChangeCategory
+
+
+def test_parse_simple_addition():
+    diff = """diff --git a/foo.py b/foo.py
+new file mode 100644
+--- /dev/null
++++ b/foo.py
+@@ -0,0 +1,3 @@
++def hello():
++    return "world"
++# end
+"""
+    analyzer = DiffAnalyzer()
+    summary = analyzer.analyze(diff)
+
+    assert summary.files_changed == 1
+    assert summary.files_added == 1
+    assert summary.files_modified == 0
+    assert summary.total_added == 3
+    assert summary.total_deleted == 0
+    assert summary.hunks_added == 1
+    assert len(summary.file_changes) == 1
+    assert summary.file_changes[0].is_new is True
+    assert summary.file_changes[0].path == "foo.py"
+
+
+def test_parse_simple_deletion():
+    diff = """diff --git a/old.py b/old.py
+deleted file mode 100644
+--- a/old.py
++++ /dev/null
+@@ -1,2 +0,0 @@
+-x = 1
+-y = 2
+"""
+    analyzer = DiffAnalyzer()
+    summary = analyzer.analyze(diff)
+
+    assert summary.files_changed == 1
+    assert summary.files_deleted == 1
+    assert summary.total_deleted == 2
+    assert summary.total_added == 0
+    assert summary.hunks_deleted == 1
+    assert summary.file_changes[0].is_deleted is True
+
+
+def test_parse_modification():
+    diff = """diff --git a/bar.py b/bar.py
+--- a/bar.py
++++ b/bar.py
+@@ -10,3 +10,4 @@ def foo():
+     existing()
+-    old_call()
++    new_call()
++    extra_step()
+     return
+"""
+    analyzer = DiffAnalyzer()
+    summary = analyzer.analyze(diff)
+
+    assert summary.files_changed == 1
+    assert summary.files_modified == 1
+    assert summary.total_added == 2   # +new_call(), +extra_step()
+    assert summary.total_deleted == 1  # -old_call()
+    assert summary.total_context == 2  # 2 context lines
+    assert summary.hunks_modified == 1
+
+
+def test_parse_multiple_files():
+    diff = """diff --git a/a.py b/a.py
+--- a/a.py
++++ b/a.py
+@@ -1,1 +1,2 @@
+ existing
++added
+diff --git a/b.py b/b.py
+new file mode 100644
+--- /dev/null
++++ b/b.py
+@@ -0,0 +1,1 @@
++new file
+diff --git a/c.py b/c.py
+deleted file mode 100644
+--- a/c.py
++++ /dev/null
+@@ -1,1 +0,0 @@
+-gone
+"""
+    analyzer = DiffAnalyzer()
+    summary = analyzer.analyze(diff)
+
+    assert summary.files_changed == 3
+    assert summary.files_added == 1
+    assert summary.files_deleted == 1
+    assert summary.files_modified == 1
+    assert summary.total_added == 2
+    assert summary.total_deleted == 1
+
+
+def test_parse_rename():
+    diff = """diff --git a/old_name.py b/new_name.py
+rename from old_name.py
+rename to new_name.py
+--- a/old_name.py
++++ b/new_name.py
+@@ -1,1 +1,1 @@
+-old_func()
++new_func()
+"""
+    analyzer = DiffAnalyzer()
+    summary = analyzer.analyze(diff)
+
+    assert summary.files_changed == 1
+    assert summary.files_renamed == 1
+    assert summary.file_changes[0].is_renamed is True
+    assert summary.file_changes[0].old_path == "old_name.py"
+    assert summary.file_changes[0].path == "new_name.py"
+
+
+def test_parse_mixed_hunks():
+    """A file with one add hunk and one delete hunk."""
+    diff = """diff --git a/mixed.py b/mixed.py
+--- a/mixed.py
++++ b/mixed.py
+@@ -5,0 +6,2 @@
++new_line_1
++new_line_2
+@@ -20,2 +22,0 @@
+-removed_1
+-removed_2
+"""
+    analyzer = DiffAnalyzer()
+    summary = analyzer.analyze(diff)
+
+    assert summary.files_changed == 1
+    assert summary.hunks_added == 1
+    assert summary.hunks_deleted == 1
+    assert summary.total_added == 2
+    assert summary.total_deleted == 2
+
+
+def test_empty_diff():
+    analyzer = DiffAnalyzer()
+    summary = analyzer.analyze("")
+
+    assert summary.files_changed == 0
+    assert summary.total_added == 0
+    assert summary.total_deleted == 0
+
+
+def test_to_dict():
+    diff = """diff --git a/test.py b/test.py
+new file mode 100644
+--- /dev/null
++++ b/test.py
+@@ -0,0 +1,2 @@
++line1
++line2
+"""
+    analyzer = DiffAnalyzer()
+    summary = analyzer.analyze(diff)
+    d = summary.to_dict()
+
+    assert d["files_changed"] == 1
+    assert d["files_added"] == 1
+    assert d["total_added"] == 2
+    assert d["total_deleted"] == 0
+    assert len(d["files"]) == 1
+    assert d["files"][0]["path"] == "test.py"
+    assert d["files"][0]["is_new"] is True
+
+
+def test_context_only_hunk():
+    """A hunk with only context lines (rare but possible)."""
+    diff = """diff --git a/noop.py b/noop.py
+--- a/noop.py
++++ b/noop.py
+@@ -5,3 +5,3 @@
+ context1
+ context2
+ context3
+"""
+    analyzer = DiffAnalyzer()
+    summary = analyzer.analyze(diff)
+
+    assert summary.total_context == 3
+    assert summary.total_added == 0
+    assert summary.total_deleted == 0
+
+
+def test_binary_files_skipped():
+    """Binary file diffs have no content lines — just headers."""
+    diff = """diff --git a/image.png b/image.png
+--- a/image.png
++++ b/image.png
+Binary files a/image.png and b/image.png differ
+"""
+    analyzer = DiffAnalyzer()
+    summary = analyzer.analyze(diff)
+
+    assert summary.files_changed == 1
+    assert summary.total_added == 0
+    assert summary.total_deleted == 0
+
+
+if __name__ == "__main__":
+    test_parse_simple_addition()
+    test_parse_simple_deletion()
+    test_parse_modification()
+    test_parse_multiple_files()
+    test_parse_rename()
+    test_parse_mixed_hunks()
+    test_empty_diff()
+    test_to_dict()
+    test_context_only_hunk()
+    test_binary_files_skipped()
+    print("All 10 tests passed.")