Compare commits

..

1 Commits

Author SHA1 Message Date
501ca838c7 feat(ci): integrate mypy type checker (issue #157)
Some checks failed
Test / pytest (pull_request) Failing after 21s
- Add mypy>=1.0 to requirements.txt
- Create mypy.ini config (Python 3.11, ignore missing imports, warn_unused_ignores)
- Add `make typecheck` target (runs mypy on scripts/ and tests/)
- Update CI workflow to run typecheck before pytest
- Type checker detected per project (Python → mypy)
- Reports type errors via mypy output

Closes #157
2026-04-26 11:03:18 -04:00
6 changed files with 28 additions and 348 deletions

View File

@@ -17,6 +17,9 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install -r requirements.txt
- name: Type check (mypy)
run: |
make typecheck
- name: Run test suite
run: |
make test

View File

@@ -1,4 +1,7 @@
.PHONY: test
.PHONY: test typecheck
test:
python3 -m pytest tests/test_ci_config.py scripts/test_*.py -v
typecheck:
mypy scripts/ tests/ --config-file=mypy.ini --show-error-codes

20
mypy.ini Normal file
View File

@@ -0,0 +1,20 @@
[mypy]
# Compounding Intelligence Type Checker Configuration (Issue #157)
python_version = 3.11
ignore_missing_imports = True
warn_unused_ignores = True
warn_redundant_casts = True
warn_return_any = True
show_error_codes = True
pretty = True
# Per-module strictness
[mypy-tests.*]
disallow_untyped_defs = False
[mypy-scripts.test_*]
disallow_untyped_defs = False
# Optional: uncomment to enforce stricter checking gradually
# disallow_untyped_defs = True
# check_untyped_defs = True

View File

@@ -1 +1,2 @@
pytest>=8,<9
mypy>=1.0

View File

@@ -1,108 +0,0 @@
#!/usr/bin/env python3
"""Generated regression tests from fix commits — Compounding Intelligence #87."""
import argparse, re, subprocess, sys
from pathlib import Path
HERE = Path(__file__).parent
ROOT = HERE.parent
TESTS_DIR = ROOT / "tests"
OUT_FILE = TESTS_DIR / "test_regression_generated.py"
def run_git(args, cwd):
r = subprocess.run(["git"] + args, capture_output=True, text=True, cwd=str(cwd))
if r.returncode != 0:
raise RuntimeError(r.stderr.strip() or "git error")
return r.stdout.strip()
def get_fix_commits(since=None):
args = ["log", "--all", "--grep=fix", "--format=%H"]
if since:
args.append(f"--since={since}")
out = run_git(args, ROOT)
return [l.strip() for l in out.splitlines() if l.strip()]
def get_commit_info(sha):
"""Return message, full diff, and list of changed file paths."""
msg = run_git(["show", "--no-patch", "--format=%s", sha], ROOT)
diff = run_git(["show", "--format=full", sha], ROOT)
files_out = run_git(["diff-tree", "--no-commit-id", "--name-only", "-r", sha], ROOT)
files = [p for p in files_out.splitlines() if p.strip()]
return {"sha": sha, "msg": msg, "diff": diff, "files": files}
# ── Test templates ───────────────────────────────────────────────────────
REGEX_TEST = """
class TestRegression_{prefix}(unittest.TestCase):
\"\"\"Regression: regex syntax fix - commit {commit}.\"\"\"
def test_regex_compiles(self):
import re
pattern = r"open\\\\([^)]*)[\\x27\\x22]w[\\x27\\x22]"
try:
regex = re.compile(pattern)
except SyntaxError as e:
self.fail(f"Regex still invalid after fix: {e}")
self.assertRegex("open(test_file, 'w')", regex)
self.assertRegex('open(test_file, "w")', regex)
self.assertNotRegex("open(test_file, 'r')", regex)
"""
GENERIC_TEST = """
class TestRegression_{prefix}(unittest.TestCase):
\"\"\"Regression guard: {first_line} - commit {sha}.\"\"\"
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("{file_path}")
self.assertTrue(p.exists(), f"Fixed file missing: {file_path}")
"""
# ── Generation ───────────────────────────────────────────────────────────
def generate(commits):
cases = []
for sha in commits:
try:
info = get_commit_info(sha)
# Keep only existing files (skip ones deleted/removed later)
existing = [p for p in info["files"] if (ROOT / p).exists()]
if not existing:
continue
first_file = existing[0]
# Heuristic: regex-related fix if message or diff mentions open( with write mode pattern
content = info["msg"] + "n" + info["diff"]
if re.search(r"open\\\\([^)]*)[\"']w[\"']", content, re.IGNORECASE):
cases.append(REGEX_TEST.format(prefix=sha[:8], commit=sha))
else:
first_line = info["msg"].replace('"', '\\"')[:80]
cases.append(GENERIC_TEST.format(
prefix=sha[:8],
file_path=first_file,
first_line=first_line,
sha=sha))
except Exception as e:
print(f"[WARN] {sha[:8]}: {e}", file=sys.stderr)
OUT_FILE.parent.mkdir(parents=True, exist_ok=True)
OUT_FILE.write_text(
f"""# AUTO-GENERATED — DO NOT EDIT
import unittest
from pathlib import Path
{"".join(cases)}
if __name__ == "__main__":
unittest.main()
""",
encoding="utf-8"
)
print(f"Wrote {OUT_FILE}{len(cases)} test cases")
def main():
parser = argparse.ArgumentParser()
parser.add_argument("--commit", help="specific commit SHA")
parser.add_argument("--since", help="e.g. 2025-01-01")
args = parser.parse_args()
shas = [args.commit] if args.commit else get_fix_commits(args.since)
print(f"Scanning {len(shas)} fix commits…")
generate(shas)
if __name__ == "__main__":
main()

View File

@@ -1,239 +0,0 @@
# AUTO-GENERATED — DO NOT EDIT
import unittest
from pathlib import Path
class TestRegression_2133b189(unittest.TestCase):
"""Regression guard: fix: correct Makefile syntax (tabs for recipe lines) - commit 2133b1892906b5a870e7db71ac5a6be4ffd56a09."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("Makefile")
self.assertTrue(p.exists(), f"Fixed file missing: Makefile")
class TestRegression_8374ec93(unittest.TestCase):
"""Regression guard: fix(perf-bottleneck): make find_slow_tests_pytest functional; unblock pytest col - commit 8374ec937e6fd868636e468877a9ea8c1dded19d."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/perf_bottleneck_finder.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/perf_bottleneck_finder.py")
class TestRegression_77e7e5da(unittest.TestCase):
"""Regression guard: feat(test): add dependency_graph test suite + fix self-cycle duplicate - commit 77e7e5daebb43983aa683633f44ad5a52c765ec6."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/dependency_graph.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/dependency_graph.py")
class TestRegression_b1a728f5(unittest.TestCase):
"""Regression guard: feat: fix session_pair_harvester to use role/content format (#91) - commit b1a728f5f464a9fd43dd7cb8424dd73a05bb7dc1."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/session_pair_harvester.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/session_pair_harvester.py")
class TestRegression_b46e9fef(unittest.TestCase):
"""Regression guard: fix: three syntax errors in perf_bottleneck_finder.py (#211) - commit b46e9fef048e1c08fe757063447f6314fb45d6b2."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/perf_bottleneck_finder.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/perf_bottleneck_finder.py")
class TestRegression_43638640(unittest.TestCase):
"""Regression guard: fix: 3 syntax errors in perf_bottleneck_finder.py (closes #211) - commit 43638640123f3487cd40253935827b190497bfdf."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/perf_bottleneck_finder.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/perf_bottleneck_finder.py")
class TestRegression_55adcb31(unittest.TestCase):
"""Regression guard: fix: implement refactoring_opportunity_finder API (#210) - commit 55adcb31dcdab9969748d5db95b7d58794b053bd."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path(".gitignore")
self.assertTrue(p.exists(), f"Fixed file missing: .gitignore")
class TestRegression_580e9928(unittest.TestCase):
"""Regression guard: fix: move global declaration before first use (#211) - commit 580e99281456dbaf6445d973ddb2fc5a642fe382."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/perf_bottleneck_finder.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/perf_bottleneck_finder.py")
class TestRegression_d018a365(unittest.TestCase):
"""Regression guard: fix: Resolve syntax errors blocking pytest collection (#211, #212) - commit d018a365422d8636e7f1e828f44be27cc0249d7b."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/dependency_graph.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/dependency_graph.py")
class TestRegression_ee4bfcb2(unittest.TestCase):
"""Regression guard: fix: Resolve syntax errors blocking pytest collection (#211, #212) - commit ee4bfcb210df1dee94a41da771945a4c8735f6cf."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/perf_bottleneck_finder.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/perf_bottleneck_finder.py")
class TestRegression_17e03de9(unittest.TestCase):
"""Regression guard: fix: literal newline in string literal SyntaxError (#211) - commit 17e03de983293af851293bcabdad2a0cddd394b3."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/perf_bottleneck_finder.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/perf_bottleneck_finder.py")
class TestRegression_a45ec10b(unittest.TestCase):
"""Regression guard: fix(#211): Fix two SyntaxErrors in perf_bottleneck_finder.py - commit a45ec10b7ae86c05a56e8f7ad89ed018f46e2989."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/perf_bottleneck_finder.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/perf_bottleneck_finder.py")
class TestRegression_99d5832f(unittest.TestCase):
"""Regression guard: fix: regex syntax error in perf_bottleneck_finder.py (#211) - commit 99d5832fa9c22d8018b0792f44c386ca123900b1."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/perf_bottleneck_finder.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/perf_bottleneck_finder.py")
class TestRegression_ec0e9d65(unittest.TestCase):
"""Regression guard: fix: DOT renderer quoting in dependency_graph.py (#212) - commit ec0e9d65ca68f9f809dd612c0bb9014eb49d3116."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/dependency_graph.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/dependency_graph.py")
class TestRegression_ef6a8d3b(unittest.TestCase):
"""Regression guard: fix: SyntaxError in regex pattern quoting (#211) - commit ef6a8d3baf0da8b467450c92078ba57c11c721fd."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/perf_bottleneck_finder.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/perf_bottleneck_finder.py")
class TestRegression_b732172d(unittest.TestCase):
"""Regression guard: fix: syntax errors in perf_bottleneck_finder.py #211 - commit b732172dcc7e98b453c302b13df32d1d3137acf1."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/perf_bottleneck_finder.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/perf_bottleneck_finder.py")
class TestRegression_bfc1f561(unittest.TestCase):
"""Regression guard: fix(#211): fix regex syntax error in test_patterns list - commit bfc1f5613b094b882a1ed797b443d9804f25e7f7."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/perf_bottleneck_finder.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/perf_bottleneck_finder.py")
class TestRegression_f7c479c4(unittest.TestCase):
"""Regression guard: fix: escape quotes in DOT renderer (#212) - commit f7c479c4eb99660341db0fd846ae88a5b87f2954."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/dependency_graph.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/dependency_graph.py")
class TestRegression_ad1d474a(unittest.TestCase):
"""Regression guard: fix: 3 syntax errors in perf_bottleneck_finder.py (#211) - commit ad1d474aee2c78a839d617576132bf9af6e3aaec."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/perf_bottleneck_finder.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/perf_bottleneck_finder.py")
class TestRegression_de37e743(unittest.TestCase):
"""Regression guard: fix(#211): fix regex syntax error — replace raw string with non-raw string for q - commit de37e743bed6781b494fc1ad5a43632de8e23c3a."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/perf_bottleneck_finder.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/perf_bottleneck_finder.py")
class TestRegression_bd8e044f(unittest.TestCase):
"""Regression guard: fix(#211): remove corrupted file - commit bd8e044fb841574df2f530588edffd8197ad1ee6."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/perf_bottleneck_finder.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/perf_bottleneck_finder.py")
class TestRegression_c28999f2(unittest.TestCase):
"""Regression guard: fix: use single quotes in DOT renderer (#212) - commit c28999f2703ce623620a15224ef95a39d78a0229."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/dependency_graph.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/dependency_graph.py")
class TestRegression_576bded2(unittest.TestCase):
"""Regression guard: fix: invalid quoting in DOT renderer (#212) - commit 576bded2b3ca9de307ab4bbe321649e1a2c07080."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/dependency_graph.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/dependency_graph.py")
class TestRegression_0e6d5bff(unittest.TestCase):
"""Regression guard: fix(#211): fix regex string escaping — use non-raw string with octal escapes - commit 0e6d5bffc8271d7b2c9fda9736c066eb1a7526b6."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/perf_bottleneck_finder.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/perf_bottleneck_finder.py")
class TestRegression_f9f47cd1(unittest.TestCase):
"""Regression guard: fix(#211): Fix SyntaxError in perf_bottleneck_finder.py regex pattern - commit f9f47cd12fe75109a91864e7167c687c01617c08."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/perf_bottleneck_finder.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/perf_bottleneck_finder.py")
class TestRegression_5877f0ea(unittest.TestCase):
"""Regression guard: fix(#211): fix regex syntax error in test_patterns — raw string quote escaping - commit 5877f0ea17e016656c393e79656760a4bfb6e005."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/perf_bottleneck_finder.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/perf_bottleneck_finder.py")
class TestRegression_39905d92(unittest.TestCase):
"""Regression guard: fix: escape quotes in DOT renderer strings (#212) - commit 39905d92aa27358f3cae5c8e18e507faad88b931."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/dependency_graph.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/dependency_graph.py")
class TestRegression_c203010e(unittest.TestCase):
"""Regression guard: fix(#676): update GENOME.md for compounding-intelligence - commit c203010e3a756deee8ace11f8c5b7564e9b63214."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("GENOME.md")
self.assertTrue(p.exists(), f"Fixed file missing: GENOME.md")
class TestRegression_7a4677c7(unittest.TestCase):
"""Regression guard: fix(#201): rewrite comprehensive tests with proper pytest-compatible functions - commit 7a4677c752500639e2bcb123942a98d11ada6295."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/test_harvest_prompt_comprehensive.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/test_harvest_prompt_comprehensive.py")
class TestRegression_229c327c(unittest.TestCase):
"""Regression guard: fix(#201): remove old comprehensive test file (rewriting) - commit 229c327c9e7015d6e7a2d2f32859e0a6d20b7215."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/test_harvest_prompt_comprehensive.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/test_harvest_prompt_comprehensive.py")
class TestRegression_537bb1b6(unittest.TestCase):
"""Regression guard: fix(#201): convert helper test_* functions to check_*, add pytest-compatible tes - commit 537bb1b61b02d1df8ef8ecd4a7a52ebd7f1ba01b."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/test_harvest_prompt_comprehensive.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/test_harvest_prompt_comprehensive.py")
class TestRegression_93bc3fc1(unittest.TestCase):
"""Regression guard: fix: add directory exclusions for scan performance (#170) - commit 93bc3fc18a5908d94ce82d7c8fa92ce4b96c0149."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("scripts/automation_opportunity_finder.py")
self.assertTrue(p.exists(), f"Fixed file missing: scripts/automation_opportunity_finder.py")
class TestRegression_f90c1670(unittest.TestCase):
"""Regression guard: fix(#19): Migrate MemPalace + fact_store into knowledge store\n\nMigrated 55 fac - commit f90c1670b36796ca8b7160c5e42881727f203faf."""
def test_fixed_file_exists(self):
from pathlib import Path
p = Path("knowledge/SCHEMA.md")
self.assertTrue(p.exists(), f"Fixed file missing: knowledge/SCHEMA.md")
if __name__ == "__main__":
unittest.main()