Timmy_Foundation/compounding-intelligence
15
0
Fork 0
Code Issues 173 Pull Requests 59 Actions Packages Projects Releases Wiki Activity

tests: pytest emits PytestReturnNotNoneWarning in harvest prompt scripts #201

New Issue
Closed
opened 2026-04-15 15:30:01 +00:00 by Rockachopa · 0 comments
Rockachopa commented 2026-04-15 15:30:01 +00:00
Owner
Copy Link

Found during #190 CI wiring

Running python3 -m pytest tests/test_ci_config.py scripts/test_*.py -v passes, but pytest emits 6 PytestReturnNotNoneWarning warnings.

Affected files:

  • scripts/test_harvest_prompt.py
  • scripts/test_harvest_prompt_comprehensive.py

Problem

Several test functions return True or (passed, message) tuples instead of asserting and returning None.
Today this is only a warning, but it makes the suite noisy and can become a failure if warnings are tightened later.

Suggested fix

  • convert those helper-style tests into real pytest assertions
  • move any reusable validation logic into helper functions that are not named test_*
## Found during #190 CI wiring Running `python3 -m pytest tests/test_ci_config.py scripts/test_*.py -v` passes, but pytest emits 6 `PytestReturnNotNoneWarning` warnings. Affected files: - `scripts/test_harvest_prompt.py` - `scripts/test_harvest_prompt_comprehensive.py` ## Problem Several test functions return `True` or `(passed, message)` tuples instead of asserting and returning `None`. Today this is only a warning, but it makes the suite noisy and can become a failure if warnings are tightened later. ## Suggested fix - convert those helper-style tests into real pytest assertions - move any reusable validation logic into helper functions that are not named `test_*`
hermes was assigned by Rockachopa 2026-04-16 01:21:52 +00:00
hermes was unassigned by Rockachopa 2026-04-17 05:06:11 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acceptance-criteria
batch-pipeline
Token masterplan batch pipeline
 bootstrapper
Pre-session context injection
 epic
Epic-level issue
 harvester
Session knowledge extraction
 measurer
Compounding metrics
 milestone:1
Milestone 1: Foundation
 milestone:2
Milestone 2: Integration
 milestone:3
Milestone 3: Measurement
 milestone:4
Milestone 4: Retroactive
 pipeline
Pipeline/integration work
 pipeline
priority:high
priority:medium
retroactive
Processing existing sessions
 throughput-10x
throughput-10x label
 token-masterplan
token-masterplan label
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude codex-agent ezra gemini google grok hermes kimi manus perplexity
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/compounding-intelligence#201
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?