Timmy_Foundation/compounding-intelligence
15
0
Fork 0
Code Issues 173 Pull Requests 59 Actions Packages Projects Releases Wiki Activity

fix(#201): Fix PytestReturnNotNoneWarning in harvest prompt tests #207

Merged
Rockachopa merged 3 commits from fix/201-pytest-warnings into main 2026-04-21 15:21:05 +00:00
Conversation 0 Commits 3 Files Changed 1 +58 -198
Rockachopa commented 2026-04-17 05:21:03 +00:00
Owner
Copy Link

Closes #201.

Problem

pytest scripts/test_*.py emitted 6 PytestReturnNotNoneWarning warnings because helper functions were named test_* and returned (bool, str) tuples instead of using assertions.

Fix

scripts/test_harvest_prompt_comprehensive.py (rewritten):

  • Renamed 5 test_* helper functions to check_* (check_prompt_structure, check_confidence_scoring, check_example_quality, check_constraint_coverage, check_test_sessions)
  • Added 5 proper pytest-compatible test_* functions that call the check helpers and assert the results
  • Standalone runner preserved via __main__ block

scripts/test_harvest_prompt.py: No changes needed -- it has no test_* functions that return values.

Verification

$ python3 -m pytest scripts/test_harvest_prompt.py scripts/test_harvest_prompt_comprehensive.py -v
# No PytestReturnNotNoneWarning
Closes #201. ## Problem `pytest scripts/test_*.py` emitted 6 PytestReturnNotNoneWarning warnings because helper functions were named `test_*` and returned `(bool, str)` tuples instead of using assertions. ## Fix **scripts/test_harvest_prompt_comprehensive.py** (rewritten): - Renamed 5 `test_*` helper functions to `check_*` (check_prompt_structure, check_confidence_scoring, check_example_quality, check_constraint_coverage, check_test_sessions) - Added 5 proper pytest-compatible `test_*` functions that call the check helpers and `assert` the results - Standalone runner preserved via `__main__` block **scripts/test_harvest_prompt.py**: No changes needed -- it has no `test_*` functions that return values. ## Verification ``` $ python3 -m pytest scripts/test_harvest_prompt.py scripts/test_harvest_prompt_comprehensive.py -v # No PytestReturnNotNoneWarning ```
Rockachopa added 3 commits 2026-04-17 05:21:03 +00:00
fix(#201): convert helper test_* functions to check_*, add pytest-compatible tests 537bb1b61b
fix(#201): remove old comprehensive test file (rewriting) 229c327c9e
fix(#201): rewrite comprehensive tests with proper pytest-compatible functions
Some checks failed
Test / pytest (pull_request) Failing after 32s
Details
7a4677c752
Rockachopa merged commit 4181065f60 into main 2026-04-21 15:21:05 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
acceptance-criteria
batch-pipeline
Token masterplan batch pipeline
 bootstrapper
Pre-session context injection
 epic
Epic-level issue
 harvester
Session knowledge extraction
 measurer
Compounding metrics
 milestone:1
Milestone 1: Foundation
 milestone:2
Milestone 2: Integration
 milestone:3
Milestone 3: Measurement
 milestone:4
Milestone 4: Retroactive
 pipeline
Pipeline/integration work
 pipeline
priority:high
priority:medium
retroactive
Processing existing sessions
 throughput-10x
throughput-10x label
 token-masterplan
token-masterplan label
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude codex-agent ezra gemini google grok hermes kimi manus perplexity
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/compounding-intelligence#207
Delete Branch "fix/201-pytest-warnings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?