Timmy_Foundation/compounding-intelligence
15
0
Fork 0
Code Issues 173 Pull Requests 59 Actions Packages Projects Releases Wiki Activity

feat(test): add dependency_graph test suite + fix self-cycle duplicate #242

Open
Rockachopa wants to merge 1 commits from step35/93-feat-cross-repo-dependency-g into main
pull from: step35/93-feat-cross-repo-dependency-g
merge into: Timmy_Foundation:main
Conversation 0 Commits 1 Files Changed 3 +188 -1
Rockachopa commented 2026-04-26 04:51:41 +00:00
Owner
Copy Link

Adds comprehensive test coverage for scripts/dependency_graph.py.

  • 20 unit/integration tests covering:
    • normalize_repo_name
    • scan_file_for_deps (Python, JS, Go, YAML, Ansible patterns)
    • detect_cycles (no cycles, simple cycles, 3-node cycles, multiple cycles, self-loops)
    • scan_repo (multi-file scanning)
    • Integration test validating timmy-config cross-repo scanning
  • Fix edge case: detect_cycles now returns clean cycles; self-loop no longer duplicates ([A,A] → [A]).
  • Uses local test_repos/ fixture (timmy-config clone) for realistic integration test.

Full acceptance criteria for #93:

  • ✓ Scan all repos for import/require/reference patterns (implemented & tested)
  • ✓ Build directed graph: repo → depends_on[] (implemented & tested)
  • ✓ Visualize as DOT/mermaid (implemented & verified)
  • ✓ Detect circular dependencies (implemented & tested)

The feature was implemented in main prior (commit cbebd93) but lacked test coverage. This PR adds tests and a minor bugfix, ensuring the cross-repo dependency graph builder remains reliable. The existing smoke-tests (scripts/*.py --help) all pass.

Closes #93

**Adds comprehensive test coverage for `scripts/dependency_graph.py`.** - 20 unit/integration tests covering: - `normalize_repo_name` - `scan_file_for_deps` (Python, JS, Go, YAML, Ansible patterns) - `detect_cycles` (no cycles, simple cycles, 3-node cycles, multiple cycles, self-loops) - `scan_repo` (multi-file scanning) - Integration test validating timmy-config cross-repo scanning - Fix edge case: `detect_cycles` now returns clean cycles; self-loop no longer duplicates (`[A,A]` → `[A]`). - Uses local `test_repos/` fixture (timmy-config clone) for realistic integration test. Full acceptance criteria for #93: - ✓ Scan all repos for import/require/reference patterns (implemented & tested) - ✓ Build directed graph: `repo → depends_on[]` (implemented & tested) - ✓ Visualize as DOT/mermaid (implemented & verified) - ✓ Detect circular dependencies (implemented & tested) The feature was implemented in main prior (commit cbebd93) but lacked test coverage. This PR adds tests and a minor bugfix, ensuring the cross-repo dependency graph builder remains reliable. The existing smoke-tests (`scripts/*.py --help`) all pass. Closes #93
Rockachopa added 1 commit 2026-04-26 04:51:42 +00:00
feat(test): add dependency_graph test suite + fix self-cycle duplicate
Some checks failed
Test / pytest (pull_request) Failing after 9s
Details
77e7e5daeb 
- 20 unit/integration tests covering normalize_repo_name, scan_file_for_deps,
  detect_cycles, and full repo scan.
- Fix detect_cycles self-loop returning duplicate node ([A,A] → [A]).
- Integration test validates timmy-config cross-repo detection.

Ref: #93 – provides test coverage to enable confident maintenance
  of cross-repo dependency graph capability.
Some checks failed
Test / pytest (pull_request) Failing after 9s
Details
Checking for merge conflicts…
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin step35/93-feat-cross-repo-dependency-g:step35/93-feat-cross-repo-dependency-g
git checkout step35/93-feat-cross-repo-dependency-g
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
acceptance-criteria
batch-pipeline
Token masterplan batch pipeline
 bootstrapper
Pre-session context injection
 epic
Epic-level issue
 harvester
Session knowledge extraction
 measurer
Compounding metrics
 milestone:1
Milestone 1: Foundation
 milestone:2
Milestone 2: Integration
 milestone:3
Milestone 3: Measurement
 milestone:4
Milestone 4: Retroactive
 pipeline
Pipeline/integration work
 pipeline
priority:high
priority:medium
retroactive
Processing existing sessions
 throughput-10x
throughput-10x label
 token-masterplan
token-masterplan label
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude codex-agent ezra gemini google grok hermes kimi manus perplexity
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/compounding-intelligence#242
Delete Branch "step35/93-feat-cross-repo-dependency-g"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?