hermes-agent/tests/test_setup_model_selection.py

"""Tests for _setup_provider_model_selection and the zai/kimi/minimax branch.

Regression test for the is_coding_plan NameError that crashed setup when
selecting zai, kimi-coding, minimax, or minimax-cn providers.
"""
import pytest
from unittest.mock import patch, MagicMock


@pytest.fixture
def mock_provider_registry():
    """Minimal PROVIDER_REGISTRY entries for tested providers."""
    class FakePConfig:
        def __init__(self, name, env_vars, base_url_env, inference_url):
            self.name = name
            self.api_key_env_vars = env_vars
            self.base_url_env_var = base_url_env
            self.inference_base_url = inference_url

    return {
        "zai": FakePConfig("ZAI", ["ZAI_API_KEY"], "ZAI_BASE_URL", "https://api.zai.example"),
        "kimi-coding": FakePConfig("Kimi Coding", ["KIMI_API_KEY"], "KIMI_BASE_URL", "https://api.kimi.example"),
        "minimax": FakePConfig("MiniMax", ["MINIMAX_API_KEY"], "MINIMAX_BASE_URL", "https://api.minimax.example"),
        "minimax-cn": FakePConfig("MiniMax CN", ["MINIMAX_API_KEY"], "MINIMAX_CN_BASE_URL", "https://api.minimax-cn.example"),
    }


class TestSetupProviderModelSelection:
    """Verify _setup_provider_model_selection works for all providers
    that previously hit the is_coding_plan NameError."""

    @pytest.mark.parametrize("provider_id,expected_defaults", [
        ("zai", ["glm-5", "glm-4.7", "glm-4.5", "glm-4.5-flash"]),
        ("kimi-coding", ["kimi-k2.5", "kimi-k2-thinking", "kimi-k2-turbo-preview"]),
        ("minimax", ["MiniMax-M2.5", "MiniMax-M2.5-highspeed", "MiniMax-M2.1"]),
        ("minimax-cn", ["MiniMax-M2.5", "MiniMax-M2.5-highspeed", "MiniMax-M2.1"]),
    ])
    @patch("hermes_cli.models.fetch_api_models", return_value=[])
    @patch("hermes_cli.config.get_env_value", return_value="fake-key")
    def test_falls_back_to_default_models_without_crashing(
        self, mock_env, mock_fetch, provider_id, expected_defaults, mock_provider_registry
    ):
        """Previously this code path raised NameError: 'is_coding_plan'.
        Now it delegates to _setup_provider_model_selection which uses
        _DEFAULT_PROVIDER_MODELS -- no crash, correct model list."""
        from hermes_cli.setup import _setup_provider_model_selection

        captured_choices = {}

        def fake_prompt_choice(label, choices, default):
            captured_choices["choices"] = choices
            # Select "Keep current" (last item)
            return len(choices) - 1

        with patch("hermes_cli.auth.PROVIDER_REGISTRY", mock_provider_registry):
            _setup_provider_model_selection(
                config={"model": {}},
                provider_id=provider_id,
                current_model="some-model",
                prompt_choice=fake_prompt_choice,
                prompt_fn=lambda _: None,
            )

        # The offered model list should start with the default models
        offered = captured_choices["choices"]
        for model in expected_defaults:
            assert model in offered, f"{model} not in choices for {provider_id}"

    @patch("hermes_cli.models.fetch_api_models")
    @patch("hermes_cli.config.get_env_value", return_value="fake-key")
    def test_live_models_used_when_available(
        self, mock_env, mock_fetch, mock_provider_registry
    ):
        """When fetch_api_models returns results, those are used instead of defaults."""
        from hermes_cli.setup import _setup_provider_model_selection

        live = ["live-model-1", "live-model-2"]
        mock_fetch.return_value = live

        captured_choices = {}

        def fake_prompt_choice(label, choices, default):
            captured_choices["choices"] = choices
            return len(choices) - 1

        with patch("hermes_cli.auth.PROVIDER_REGISTRY", mock_provider_registry):
            _setup_provider_model_selection(
                config={"model": {}},
                provider_id="zai",
                current_model="some-model",
                prompt_choice=fake_prompt_choice,
                prompt_fn=lambda _: None,
            )

        offered = captured_choices["choices"]
        assert "live-model-1" in offered
        assert "live-model-2" in offered

    @patch("hermes_cli.models.fetch_api_models", return_value=[])
    @patch("hermes_cli.config.get_env_value", return_value="fake-key")
    def test_custom_model_selection(
        self, mock_env, mock_fetch, mock_provider_registry
    ):
        """Selecting 'Custom model' lets user type a model name."""
        from hermes_cli.setup import _setup_provider_model_selection, _DEFAULT_PROVIDER_MODELS

        defaults = _DEFAULT_PROVIDER_MODELS["zai"]
        custom_model_idx = len(defaults)  # "Custom model" is right after defaults

        config = {"model": {}}

        def fake_prompt_choice(label, choices, default):
            return custom_model_idx

        with patch("hermes_cli.auth.PROVIDER_REGISTRY", mock_provider_registry):
            _setup_provider_model_selection(
                config=config,
                provider_id="zai",
                current_model="some-model",
                prompt_choice=fake_prompt_choice,
                prompt_fn=lambda _: "my-custom-model",
            )

        assert config["model"]["default"] == "my-custom-model"