fix: escape parens and braces in fork bomb regex pattern
The fork bomb regex used `()` (empty capture group) and unescaped `{}`
instead of literal `\(\)` and `\{\}`. This meant the classic fork bomb
`:(){ :|:& };:` was never detected. Also added `\s*` between `:` and
`&` and between `;` and trailing `:` to catch whitespace variants.
This commit is contained in:
@@ -413,3 +413,20 @@ class TestViewFullCommand:
|
||||
# After first 'v', is_truncated becomes False, so second 'v' -> deny
|
||||
assert result == "deny"
|
||||
|
||||
|
||||
class TestForkBombDetection:
|
||||
"""The fork bomb regex must match the classic :(){ :|:& };: pattern."""
|
||||
|
||||
def test_classic_fork_bomb(self):
|
||||
dangerous, key, desc = detect_dangerous_command(":(){ :|:& };:")
|
||||
assert dangerous is True, "classic fork bomb not detected"
|
||||
assert "fork bomb" in desc.lower()
|
||||
|
||||
def test_fork_bomb_with_spaces(self):
|
||||
dangerous, key, desc = detect_dangerous_command(":() { : | :& } ; :")
|
||||
assert dangerous is True, "fork bomb with extra spaces not detected"
|
||||
|
||||
def test_colon_in_safe_command_not_flagged(self):
|
||||
dangerous, key, desc = detect_dangerous_command("echo hello:world")
|
||||
assert dangerous is False
|
||||
|
||||
|
||||
@@ -38,7 +38,7 @@ DANGEROUS_PATTERNS = [
|
||||
(r'\bsystemctl\s+(stop|disable|mask)\b', "stop/disable system service"),
|
||||
(r'\bkill\s+-9\s+-1\b', "kill all processes"),
|
||||
(r'\bpkill\s+-9\b', "force kill processes"),
|
||||
(r':()\s*{\s*:\s*\|\s*:&\s*}\s*;:', "fork bomb"),
|
||||
(r':\(\)\s*\{\s*:\s*\|\s*:\s*&\s*\}\s*;\s*:', "fork bomb"),
|
||||
(r'\b(bash|sh|zsh)\s+-c\s+', "shell command via -c flag"),
|
||||
(r'\b(python[23]?|perl|ruby|node)\s+-[ec]\s+', "script execution via -e/-c flag"),
|
||||
(r'\b(curl|wget)\b.*\|\s*(ba)?sh\b', "pipe remote content to shell"),
|
||||
|
||||
Reference in New Issue
Block a user