fix: suppress fallback_model warnings for blank/disabled fields (#373)

When fallback_model is present in config.yaml but has blank fields or
explicitly set enabled: false, treat it as intentionally disabled rather
than emitting startup warnings about missing provider/model fields.

Changes:
- gateway/run.py _load_fallback_model(): return None for empty dicts or
  enabled:false fallback_model entries
- hermes_cli/config.py validate_config_structure(): skip warnings when
  fallback_model has enabled: false; improved hint messages to suggest
  the enabled: false convention

cli.py

@@ -3134,196 +3134,6 @@ class HermesCLI:
         print(f"  Home:    {display}")
         print()
 
-    def _handle_debug_command(self, command: str):
-        """Generate a debug report with system info and logs, upload to paste service."""
-        import platform
-        import sys
-        import time as _time
-
-        # Parse optional lines argument
-        parts = command.split(maxsplit=1)
-        log_lines = 50
-        if len(parts) > 1:
-            try:
-                log_lines = min(int(parts[1]), 500)
-            except ValueError:
-                pass
-
-        _cprint("  Collecting debug info...")
-
-        # Collect system info
-        lines = []
-        lines.append("=== HERMES DEBUG REPORT ===")
-        lines.append(f"Generated: {_time.strftime('%Y-%m-%d %H:%M:%S %z')}")
-        lines.append("")
-
-        lines.append("--- System ---")
-        lines.append(f"Python: {sys.version}")
-        lines.append(f"Platform: {platform.platform()}")
-        lines.append(f"Architecture: {platform.machine()}")
-        lines.append(f"Hostname: {platform.node()}")
-        lines.append("")
-
-        # Hermes info
-        lines.append("--- Hermes ---")
-        try:
-            from hermes_constants import get_hermes_home, display_hermes_home
-            lines.append(f"Home: {display_hermes_home()}")
-        except Exception:
-            lines.append("Home: unknown")
-
-        try:
-            from hermes_constants import __version__
-            lines.append(f"Version: {__version__}")
-        except Exception:
-            lines.append("Version: unknown")
-
-        lines.append(f"Profile: {getattr(self, '_profile_name', 'default')}")
-        lines.append(f"Session: {self.session_id}")
-        lines.append(f"Model: {self.model}")
-        lines.append(f"Provider: {getattr(self, '_provider_name', 'unknown')}")
-
-        try:
-            lines.append(f"Working dir: {os.getcwd()}")
-        except Exception:
-            pass
-
-        # Config (redacted)
-        lines.append("")
-        lines.append("--- Config (redacted) ---")
-        try:
-            from hermes_constants import get_hermes_home
-            config_path = get_hermes_home() / "config.yaml"
-            if config_path.exists():
-                import yaml
-                with open(config_path) as f:
-                    cfg = yaml.safe_load(f) or {}
-                # Redact secrets
-                for key in ("api_key", "token", "secret", "password"):
-                    if key in cfg:
-                        cfg[key] = "***REDACTED***"
-                lines.append(yaml.dump(cfg, default_flow_style=False)[:2000])
-            else:
-                lines.append("(no config file found)")
-        except Exception as e:
-            lines.append(f"(error reading config: {e})")
-
-        # Recent logs
-        lines.append("")
-        lines.append(f"--- Recent Logs (last {log_lines} lines) ---")
-        try:
-            from hermes_constants import get_hermes_home
-            log_dir = get_hermes_home() / "logs"
-            if log_dir.exists():
-                for log_file in sorted(log_dir.glob("*.log")):
-                    try:
-                        content = log_file.read_text(encoding="utf-8", errors="replace")
-                        tail = content.strip().split("\n")[-log_lines:]
-                        if tail:
-                            lines.append(f"\n[{log_file.name}]")
-                            lines.extend(tail)
-                    except Exception:
-                        pass
-            else:
-                lines.append("(no logs directory)")
-        except Exception:
-            lines.append("(error reading logs)")
-
-        # Tool info
-        lines.append("")
-        lines.append("--- Enabled Toolsets ---")
-        try:
-            lines.append(", ".join(self.enabled_toolsets) if self.enabled_toolsets else "(none)")
-        except Exception:
-            lines.append("(unknown)")
-
-        report = "\n".join(lines)
-        report_size = len(report)
-
-        # Try to upload to paste services
-        paste_url = None
-        services = [
-            ("dpaste", _upload_dpaste),
-            ("0x0.st", _upload_0x0st),
-        ]
-
-        for name, uploader in services:
-            try:
-                url = uploader(report)
-                if url:
-                    paste_url = url
-                    break
-            except Exception:
-                continue
-
-        print()
-        if paste_url:
-            _cprint(f"  Debug report uploaded: {paste_url}")
-            _cprint(f"  Size: {report_size} bytes, {len(lines)} lines")
-        else:
-            # Fallback: save locally
-            try:
-                from hermes_constants import get_hermes_home
-                debug_path = get_hermes_home() / "debug-report.txt"
-                debug_path.write_text(report, encoding="utf-8")
-                _cprint(f"  Paste services unavailable. Report saved to: {debug_path}")
-                _cprint(f"  Size: {report_size} bytes, {len(lines)} lines")
-            except Exception as e:
-                _cprint(f"  Failed to save report: {e}")
-                _cprint(f"  Report ({report_size} bytes):")
-                print(report)
-        print()
-
-
-def _upload_dpaste(content: str) -> str | None:
-    """Upload content to dpaste.org. Returns URL or None."""
-    import urllib.request
-    import urllib.parse
-    data = urllib.parse.urlencode({
-        "content": content,
-        "syntax": "text",
-        "expiry_days": 7,
-    }).encode()
-    req = urllib.request.Request(
-        "https://dpaste.org/api/",
-        data=data,
-        headers={"User-Agent": "hermes-agent/debug"},
-    )
-    with urllib.request.urlopen(req, timeout=10) as resp:
-        url = resp.read().decode().strip()
-        if url.startswith("http"):
-            return url
-    return None
-
-
-def _upload_0x0st(content: str) -> str | None:
-    """Upload content to 0x0.st. Returns URL or None."""
-    import urllib.request
-    import io
-    # 0x0.st expects multipart form with a file field
-    boundary = "----HermesDebugBoundary"
-    body = (
-        f"--{boundary}\r\n"
-        f'Content-Disposition: form-data; name="file"; filename="debug.txt"\r\n'
-        f"Content-Type: text/plain\r\n\r\n"
-        f"{content}\r\n"
-        f"--{boundary}--\r\n"
-    ).encode()
-    req = urllib.request.Request(
-        "https://0x0.st",
-        data=body,
-        headers={
-            "Content-Type": f"multipart/form-data; boundary={boundary}",
-            "User-Agent": "hermes-agent/debug",
-        },
-    )
-    with urllib.request.urlopen(req, timeout=10) as resp:
-        url = resp.read().decode().strip()
-        if url.startswith("http"):
-            return url
-    return None
-
-
     def show_config(self):
         """Display current configuration with kawaii ASCII art."""
         # Get terminal config from environment (which was set from cli-config.yaml)
@@ -4511,8 +4321,6 @@ def _upload_0x0st(content: str) -> str | None:
             self.show_help()
         elif canonical == "profile":
             self._handle_profile_command()
-        elif canonical == "debug":
-            self._handle_debug_command(cmd_original)
         elif canonical == "tools":
             self._handle_tools_command(cmd_original)
         elif canonical == "toolsets":

gateway/run.py

@@ -1026,6 +1026,16 @@ class GatewayRunner:
                     cfg = _y.safe_load(_f) or {}
                 fb = cfg.get("fallback_providers") or cfg.get("fallback_model") or None
                 if fb:
+                    # Treat empty dict / disabled fallback as "not configured"
+                    if isinstance(fb, dict):
+                        _enabled = fb.get("enabled")
+                        if _enabled is False or (
+                            isinstance(_enabled, str)
+                            and _enabled.strip().lower() in ("false", "0", "no", "off")
+                        ):
+                            return None
+                        if not fb.get("provider") and not fb.get("model"):
+                            return None
                     return fb
         except Exception:
             pass

hermes_cli/config.py

@@ -1421,6 +1421,7 @@ def validate_config_structure(config: Optional[Dict[str, Any]] = None) -> List["
                     ))
 
     # ── fallback_model must be a top-level dict with provider + model ────
+    # Blank or explicitly disabled fallback is intentional — skip validation.
     fb = config.get("fallback_model")
     if fb is not None:
         if not isinstance(fb, dict):
@@ -1430,20 +1431,29 @@ def validate_config_structure(config: Optional[Dict[str, Any]] = None) -> List["
                 "Change to:\n"
                 "  fallback_model:\n"
                 "    provider: openrouter\n"
-                "    model: anthropic/claude-sonnet-4",
+                "    model: anthropic/claude-sonnet-4\n"
+                "Or disable with:\n"
+                "  fallback_model:\n"
+                "    enabled: false",
             ))
         elif fb:
-            if not fb.get("provider"):
+            # Skip warnings when fallback is explicitly disabled (enabled: false)
+            _enabled = fb.get("enabled")
+            if _enabled is False or (isinstance(_enabled, str) and _enabled.strip().lower() in ("false", "0", "no", "off")):
+                pass  # intentionally disabled — no warnings
+            elif not fb.get("provider"):
                 issues.append(ConfigIssue(
                     "warning",
                     "fallback_model is missing 'provider' field — fallback will be disabled",
-                    "Add: provider: openrouter (or another provider)",
+                    "Add: provider: openrouter (or another provider)\n"
+                    "Or disable with: enabled: false",
                 ))
-            if not fb.get("model"):
+            elif not fb.get("model"):
                 issues.append(ConfigIssue(
                     "warning",
                     "fallback_model is missing 'model' field — fallback will be disabled",
-                    "Add: model: anthropic/claude-sonnet-4 (or another model)",
+                    "Add: model: anthropic/claude-sonnet-4 (or another model)\n"
+                    "Or disable with: enabled: false",
                 ))
 
     # ── Check for fallback_model accidentally nested inside custom_providers ──