Compare commits
1 Commits
claude/iss
...
fix/500-cl
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
568a735f65 |
@@ -41,6 +41,64 @@ from agent.model_metadata import is_local_endpoint
|
||||
|
||||
logger = logging.getLogger(__name__)
|
||||
|
||||
# Minimum context tokens required for cron job execution
|
||||
CRON_MIN_CONTEXT_TOKENS = 500
|
||||
|
||||
|
||||
class ModelContextError(Exception):
|
||||
"""Raised when a model does not have enough context tokens for a cron job."""
|
||||
pass
|
||||
|
||||
|
||||
# =====================================================================
|
||||
# Cloud Context Warning — detect local service refs in cloud prompts
|
||||
# =====================================================================
|
||||
|
||||
import re as _re
|
||||
|
||||
_LOCAL_SERVICE_PATTERNS = [
|
||||
_re.compile(r'\blocalhost:\d+', _re.IGNORECASE),
|
||||
_re.compile(r'\b127\.\d+\.\d+\.\d+:\d+', _re.IGNORECASE),
|
||||
_re.compile(r'\b0\.0\.0\.0:\d+', _re.IGNORECASE),
|
||||
_re.compile(r'\bollama\b', _re.IGNORECASE),
|
||||
_re.compile(r'\bcurl\s+localhost\b', _re.IGNORECASE),
|
||||
_re.compile(r'\bwget\s+localhost\b', _re.IGNORECASE),
|
||||
_re.compile(r'\bhttp://localhost\b', _re.IGNORECASE),
|
||||
_re.compile(r'\bhttps?://127\.\d+\.\d+\.\d+\b', _re.IGNORECASE),
|
||||
_re.compile(r'\bcheck\s+ollama\b', _re.IGNORECASE),
|
||||
_re.compile(r'\bconnect\s+local\b', _re.IGNORECASE),
|
||||
_re.compile(r'\bhermes\s+gateway\s+local\b', _re.IGNORECASE),
|
||||
_re.compile(r'\blocal\s+model\b', _re.IGNORECASE),
|
||||
]
|
||||
|
||||
_CLOUD_CONTEXT_WARNING = (
|
||||
"\n\n[SYSTEM NOTE: This cron job is running on a CLOUD inference endpoint. "
|
||||
"Local services (Ollama, localhost, local gateway) are NOT accessible from "
|
||||
"this environment. Do not attempt to connect to localhost, run curl/wget "
|
||||
"against local ports, or check local model availability. Report the "
|
||||
"limitation and focus on tasks achievable remotely.]\n"
|
||||
)
|
||||
|
||||
|
||||
def _detect_local_service_refs(text: str) -> list[str]:
|
||||
"""Detect references to local services in prompt text."""
|
||||
refs = []
|
||||
for pat in _LOCAL_SERVICE_PATTERNS:
|
||||
if pat.search(text):
|
||||
refs.append(pat.pattern)
|
||||
return refs
|
||||
|
||||
|
||||
def _inject_cloud_context(prompt: str, base_url: str) -> str:
|
||||
"""If running on cloud but prompt references local services, inject warning."""
|
||||
if is_local_endpoint(base_url):
|
||||
return prompt
|
||||
refs = _detect_local_service_refs(prompt)
|
||||
if refs:
|
||||
logger.info("Cloud endpoint + local service refs detected (%d patterns), injecting warning", len(refs))
|
||||
return _CLOUD_CONTEXT_WARNING + prompt
|
||||
return prompt
|
||||
|
||||
|
||||
# =====================================================================
|
||||
# Deploy Sync Guard
|
||||
@@ -817,6 +875,9 @@ def run_job(job: dict) -> tuple[bool, str, str, Optional[str]]:
|
||||
job_name,
|
||||
)
|
||||
|
||||
# Inject cloud-context warning if prompt references local services (#468)
|
||||
prompt = _inject_cloud_context(prompt, _runtime_base_url)
|
||||
|
||||
_agent_kwargs = _safe_agent_kwargs({
|
||||
"model": turn_route["model"],
|
||||
"api_key": turn_route["runtime"].get("api_key"),
|
||||
|
||||
83
tests/cron/test_cron_cloud_context.py
Normal file
83
tests/cron/test_cron_cloud_context.py
Normal file
@@ -0,0 +1,83 @@
|
||||
"""Tests for cron cloud-context warning injection (#468)."""
|
||||
|
||||
import pytest
|
||||
|
||||
from cron.scheduler import (
|
||||
_LOCAL_SERVICE_PATTERNS,
|
||||
_detect_local_service_refs,
|
||||
_inject_cloud_context,
|
||||
_CLOUD_CONTEXT_WARNING,
|
||||
)
|
||||
|
||||
|
||||
class TestDetectLocalServiceRefs:
|
||||
"""Test local service reference detection."""
|
||||
|
||||
def test_detects_localhost_with_port(self):
|
||||
refs = _detect_local_service_refs("Connect to localhost:11434")
|
||||
assert len(refs) > 0
|
||||
|
||||
def test_detects_127_address(self):
|
||||
refs = _detect_local_service_refs("Check http://127.0.0.1:8080/health")
|
||||
assert len(refs) > 0
|
||||
|
||||
def test_detects_ollama(self):
|
||||
refs = _detect_local_service_refs("Run ollama pull gemma4")
|
||||
assert len(refs) > 0
|
||||
|
||||
def test_detects_curl_localhost(self):
|
||||
refs = _detect_local_service_refs("curl localhost:11434/api/tags")
|
||||
assert len(refs) > 0
|
||||
|
||||
def test_detects_wget_localhost(self):
|
||||
refs = _detect_local_service_refs("wget localhost:8080/data")
|
||||
assert len(refs) > 0
|
||||
|
||||
def test_detects_http_localhost(self):
|
||||
refs = _detect_local_service_refs("http://localhost:3000")
|
||||
assert len(refs) > 0
|
||||
|
||||
def test_detects_local_model(self):
|
||||
refs = _detect_local_service_refs("Use the local model for inference")
|
||||
assert len(refs) > 0
|
||||
|
||||
def test_no_refs_returns_empty(self):
|
||||
refs = _detect_local_service_refs("Search the web for Python tutorials")
|
||||
assert len(refs) == 0
|
||||
|
||||
def test_case_insensitive(self):
|
||||
refs = _detect_local_service_refs("OLLAMA is running on LocalHost:11434")
|
||||
assert len(refs) > 0
|
||||
|
||||
|
||||
class TestInjectCloudContext:
|
||||
"""Test cloud context warning injection."""
|
||||
|
||||
def test_no_warning_on_local_endpoint(self):
|
||||
prompt = "Check ollama on localhost:11434"
|
||||
result = _inject_cloud_context(prompt, "http://localhost:11434/v1")
|
||||
assert result == prompt # No injection for local endpoints
|
||||
|
||||
def test_no_warning_when_no_local_refs(self):
|
||||
prompt = "Search the web for news"
|
||||
result = _inject_cloud_context(prompt, "https://api.openai.com/v1")
|
||||
assert result == prompt
|
||||
|
||||
def test_injects_warning_on_cloud_with_local_refs(self):
|
||||
prompt = "Check ollama status on localhost:11434"
|
||||
result = _inject_cloud_context(prompt, "https://api.openai.com/v1")
|
||||
assert _CLOUD_CONTEXT_WARNING in result
|
||||
assert prompt in result
|
||||
assert result.startswith(_CLOUD_CONTEXT_WARNING)
|
||||
|
||||
def test_nous_cloud_injects_warning(self):
|
||||
prompt = "curl localhost:11434/api/tags"
|
||||
result = _inject_cloud_context(prompt, "https://inference-api.nousresearch.com/v1")
|
||||
assert _CLOUD_CONTEXT_WARNING in result
|
||||
|
||||
def test_warning_content(self):
|
||||
prompt = "local model check"
|
||||
result = _inject_cloud_context(prompt, "https://api.example.com/v1")
|
||||
assert "CLOUD" in result
|
||||
assert "NOT accessible" in result
|
||||
assert "localhost" in result
|
||||
Reference in New Issue
Block a user