fix: log plugin memory provider fallback failure at debug level

Address review feedback on PR #1002: replace silent `except Exception: pass`
with `logger.debug(...)` so plugin loading failures are visible in debug logs.

Refs #990

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

cli.py

@@ -6852,12 +6852,11 @@ class HermesCLI:
             self._voice_stop_and_transcribe()
 
         # Audio cue: single beep BEFORE starting stream (avoid CoreAudio conflict)
-        if self._voice_beeps_enabled():
-            try:
-                from tools.voice_mode import play_beep
-                play_beep(frequency=880, count=1)
-            except Exception:
-                pass
+        try:
+            from tools.voice_mode import play_beep
+            play_beep(frequency=880, count=1)
+        except Exception:
+            pass
 
         try:
             self._voice_recorder.start(on_silence_stop=_on_silence)
@@ -6905,12 +6904,11 @@ class HermesCLI:
             wav_path = self._voice_recorder.stop()
 
             # Audio cue: double beep after stream stopped (no CoreAudio conflict)
-            if self._voice_beeps_enabled():
-                try:
-                    from tools.voice_mode import play_beep
-                    play_beep(frequency=660, count=2)
-                except Exception:
-                    pass
+            try:
+                from tools.voice_mode import play_beep
+                play_beep(frequency=660, count=2)
+            except Exception:
+                pass
 
             if wav_path is None:
                 _cprint(f"{_DIM}No speech detected.{_RST}")
@@ -7061,17 +7059,6 @@ class HermesCLI:
             _cprint(f"Unknown voice subcommand: {subcommand}")
             _cprint("Usage: /voice [on|off|tts|status]")
 
-    def _voice_beeps_enabled(self) -> bool:
-        """Return whether CLI voice mode should play record start/stop beeps."""
-        try:
-            from hermes_cli.config import load_config
-            voice_cfg = load_config().get("voice", {})
-            if isinstance(voice_cfg, dict):
-                return bool(voice_cfg.get("beep_enabled", True))
-        except Exception:
-            pass
-        return True
-
     def _enable_voice_mode(self):
         """Enable voice mode after checking requirements."""
         if self._voice_mode:

hermes_cli/plugins.py

@@ -211,6 +211,43 @@ class PluginContext:
         }
         logger.debug("Plugin %s registered CLI command: %s", self.manifest.name, name)
 
+    # -- memory provider registration ----------------------------------------
+
+    def register_memory_provider(self, provider) -> None:
+        """Register a memory provider supplied by this plugin.
+
+        The provider must be an instance of ``agent.memory_provider.MemoryProvider``.
+        Only one plugin-registered memory provider is accepted; a second
+        attempt is rejected with a warning.
+
+        The registered provider is retrievable via
+        ``get_plugin_memory_provider()`` and is picked up by ``run_agent.py``
+        when ``memory.provider`` in *config.yaml* matches the provider's
+        ``name`` property.
+        """
+        from agent.memory_provider import MemoryProvider
+
+        if not isinstance(provider, MemoryProvider):
+            logger.warning(
+                "Plugin '%s' tried to register a memory provider that does not "
+                "inherit from MemoryProvider. Ignoring.",
+                self.manifest.name,
+            )
+            return
+        if self._manager._plugin_memory_provider is not None:
+            logger.warning(
+                "Plugin '%s' tried to register a memory provider, but one is "
+                "already registered by another plugin. Only one plugin-supplied "
+                "memory provider is allowed at a time.",
+                self.manifest.name,
+            )
+            return
+        self._manager._plugin_memory_provider = provider
+        logger.info(
+            "Plugin '%s' registered memory provider: %s",
+            self.manifest.name, provider.name,
+        )
+
     # -- context engine registration -----------------------------------------
 
     def register_context_engine(self, engine) -> None:
@@ -323,6 +360,7 @@ class PluginManager:
         self._plugin_tool_names: Set[str] = set()
         self._cli_commands: Dict[str, dict] = {}
         self._context_engine = None  # Set by a plugin via register_context_engine()
+        self._plugin_memory_provider = None  # Set by a plugin via register_memory_provider()
         self._discovered: bool = False
         self._cli_ref = None  # Set by CLI after plugin discovery
         # Plugin skill registry: qualified name → metadata dict.
@@ -699,6 +737,11 @@ def get_plugin_context_engine():
     return get_plugin_manager()._context_engine
 
 
+def get_plugin_memory_provider():
+    """Return the plugin-registered memory provider, or None."""
+    return get_plugin_manager()._plugin_memory_provider
+
+
 def get_plugin_toolsets() -> List[tuple]:
     """Return plugin toolsets as ``(key, label, description)`` tuples.
 

run_agent.py

@@ -1193,6 +1193,18 @@ class AIAgent:
                     from plugins.memory import load_memory_provider as _load_mem
                     self._memory_manager = _MemoryManager()
                     _mp = _load_mem(_mem_provider_name)
+                    # Fall back to a user plugin that called register_memory_provider()
+                    if _mp is None:
+                        try:
+                            from hermes_cli.plugins import get_plugin_memory_provider as _gpm
+                            _candidate = _gpm()
+                            if _candidate and _candidate.name == _mem_provider_name:
+                                _mp = _candidate
+                        except Exception as _gpm_err:
+                            logger.debug(
+                                "get_plugin_memory_provider() failed during fallback lookup: %s",
+                                _gpm_err,
+                            )
                     if _mp and _mp.is_available():
                         self._memory_manager.add_provider(_mp)
                     if self._memory_manager.providers:

tests/hermes_cli/test_plugins.py

@@ -19,6 +19,7 @@ from hermes_cli.plugins import (
     PluginManifest,
     get_plugin_manager,
     get_pre_tool_call_block_message,
+    get_plugin_memory_provider,
     discover_plugins,
     invoke_hook,
 )
@@ -609,3 +610,105 @@ class TestPreLlmCallTargetRouting:
 # in PluginContext (hermes_cli/plugins.py).  The tests referenced _plugin_commands,
 # commands_registered, get_plugin_command_handler, and GATEWAY_KNOWN_COMMANDS
 # integration — all of which are unimplemented features.
+
+
+# ── TestRegisterMemoryProvider ─────────────────────────────────────────────
+
+
+class TestRegisterMemoryProvider:
+    """Regression tests for PluginContext.register_memory_provider() — issue #990.
+
+    The MemPalace plugin (and any user plugin following the developer guide)
+    calls ``ctx.register_memory_provider(provider)`` inside ``register(ctx)``.
+    Before the fix, PluginContext had no such method and the plugin failed to
+    load with: 'PluginContext' object has no attribute 'register_memory_provider'.
+    """
+
+    def _make_memory_plugin(self, plugins_dir: "Path", name: str) -> None:
+        """Write a minimal user plugin that registers a stub MemoryProvider."""
+        from agent.memory_provider import MemoryProvider
+
+        plugin_dir = plugins_dir / name
+        plugin_dir.mkdir(parents=True, exist_ok=True)
+        (plugin_dir / "plugin.yaml").write_text(
+            f"name: {name}\nversion: 0.1.0\ndescription: Stub memory plugin\n"
+        )
+        # The register() body imports and calls register_memory_provider — this
+        # is the exact pattern documented in memory-provider-plugin.md and used
+        # by third-party plugins such as MemPalace.
+        (plugin_dir / "__init__.py").write_text(
+            "from agent.memory_provider import MemoryProvider\n"
+            "\n"
+            "class _StubProvider(MemoryProvider):\n"
+            "    @property\n"
+            f"    def name(self): return '{name}'\n"
+            "    def is_available(self): return True\n"
+            "    def initialize(self, session_id, **kw): pass\n"
+            "    def get_tool_schemas(self): return []\n"
+            "\n"
+            "def register(ctx):\n"
+            "    ctx.register_memory_provider(_StubProvider())\n"
+        )
+
+    def test_register_memory_provider_succeeds(self, tmp_path, monkeypatch):
+        """A user plugin calling register_memory_provider() loads without error."""
+        plugins_dir = tmp_path / "hermes_test" / "plugins"
+        self._make_memory_plugin(plugins_dir, "mempalace")
+        monkeypatch.setenv("HERMES_HOME", str(tmp_path / "hermes_test"))
+
+        mgr = PluginManager()
+        mgr.discover_and_load()
+
+        assert "mempalace" in mgr._plugins
+        assert mgr._plugins["mempalace"].enabled, (
+            mgr._plugins["mempalace"].error
+        )
+
+    def test_plugin_memory_provider_stored(self, tmp_path, monkeypatch):
+        """The provider instance is accessible via get_plugin_memory_provider()."""
+        import hermes_cli.plugins as plugins_mod
+
+        plugins_dir = tmp_path / "hermes_test" / "plugins"
+        self._make_memory_plugin(plugins_dir, "mempalace")
+        monkeypatch.setenv("HERMES_HOME", str(tmp_path / "hermes_test"))
+
+        mgr = PluginManager()
+        # Swap the singleton so get_plugin_memory_provider() sees our manager
+        monkeypatch.setattr(plugins_mod, "_plugin_manager", mgr)
+        mgr.discover_and_load()
+
+        provider = get_plugin_memory_provider()
+        assert provider is not None
+        assert provider.name == "mempalace"
+
+    def test_second_registration_rejected(self, tmp_path, monkeypatch):
+        """Only one plugin-registered memory provider is accepted."""
+        plugins_dir = tmp_path / "hermes_test" / "plugins"
+        self._make_memory_plugin(plugins_dir, "first_provider")
+        self._make_memory_plugin(plugins_dir, "second_provider")
+        monkeypatch.setenv("HERMES_HOME", str(tmp_path / "hermes_test"))
+
+        mgr = PluginManager()
+        mgr.discover_and_load()
+
+        # The manager should hold exactly one provider
+        assert mgr._plugin_memory_provider is not None
+        assert mgr._plugin_memory_provider.name in {"first_provider", "second_provider"}
+
+    def test_non_provider_rejected(self, tmp_path, monkeypatch):
+        """Passing a non-MemoryProvider object logs a warning and is ignored."""
+        plugins_dir = tmp_path / "hermes_test" / "plugins"
+        plugin_dir = plugins_dir / "bad_provider"
+        plugin_dir.mkdir(parents=True, exist_ok=True)
+        (plugin_dir / "plugin.yaml").write_text("name: bad_provider\n")
+        (plugin_dir / "__init__.py").write_text(
+            "def register(ctx):\n"
+            "    ctx.register_memory_provider('not-a-provider')\n"
+        )
+        monkeypatch.setenv("HERMES_HOME", str(tmp_path / "hermes_test"))
+
+        mgr = PluginManager()
+        mgr.discover_and_load()
+
+        # Plugin still loads (warning only), but no provider is stored
+        assert mgr._plugin_memory_provider is None

tests/tools/test_voice_cli_integration.py

@@ -4,31 +4,13 @@ state management, streaming TTS activation, voice message prefix, _vprint."""
 import ast
 import os
 import queue
-import sys
 import threading
-import types
 from types import SimpleNamespace
 from unittest.mock import MagicMock, patch
 
 import pytest
 
 
-def _ensure_cli_import_shims():
-    sys.modules.setdefault(
-        "agent.auxiliary_client",
-        types.SimpleNamespace(
-            call_llm=lambda *args, **kwargs: "",
-            async_call_llm=lambda *args, **kwargs: "",
-            extract_content_or_reasoning=lambda *args, **kwargs: "",
-            resolve_provider_client=lambda *args, **kwargs: (None, None, None, None),
-            get_async_text_auxiliary_client=lambda *args, **kwargs: None,
-        ),
-    )
-
-
-_ensure_cli_import_shims()
-
-
 def _make_voice_cli(**overrides):
     """Create a minimal HermesCLI with only voice-related attrs initialized.
 
@@ -36,7 +18,6 @@ def _make_voice_cli(**overrides):
     needed.  Only the voice state attributes (from __init__ lines 3749-3758)
     are populated.
     """
-    _ensure_cli_import_shims()
     from cli import HermesCLI
 
     cli = HermesCLI.__new__(HermesCLI)
@@ -952,58 +933,6 @@ class TestEnableVoiceModeReal:
         assert cli._voice_mode is True
 
 
-class TestVoiceBeepConfigReal:
-    """Tests the CLI voice beep toggle."""
-
-    @patch("hermes_cli.config.load_config", return_value={"voice": {}})
-    def test_beeps_enabled_by_default(self, _cfg):
-        cli = _make_voice_cli()
-        assert cli._voice_beeps_enabled() is True
-
-    @patch("hermes_cli.config.load_config", return_value={"voice": {"beep_enabled": False}})
-    def test_beeps_can_be_disabled(self, _cfg):
-        cli = _make_voice_cli()
-        assert cli._voice_beeps_enabled() is False
-
-    @patch("cli._cprint")
-    @patch("cli.threading.Thread")
-    @patch("tools.voice_mode.play_beep")
-    @patch("tools.voice_mode.create_audio_recorder")
-    @patch(
-        "tools.voice_mode.check_voice_requirements",
-        return_value={
-            "available": True,
-            "audio_available": True,
-            "stt_available": True,
-            "details": "OK",
-            "missing_packages": [],
-        },
-    )
-    @patch(
-        "hermes_cli.config.load_config",
-        return_value={
-            "voice": {
-                "beep_enabled": False,
-                "silence_threshold": 200,
-                "silence_duration": 3.0,
-            }
-        },
-    )
-    def test_start_recording_skips_beep_when_disabled(
-        self, _cfg, _req, mock_create, mock_beep, mock_thread, _cp
-    ):
-        recorder = MagicMock()
-        recorder.supports_silence_autostop = True
-        mock_create.return_value = recorder
-        mock_thread.return_value = MagicMock(start=MagicMock())
-
-        cli = _make_voice_cli()
-        cli._voice_start_recording()
-
-        recorder.start.assert_called_once()
-        mock_beep.assert_not_called()
-
-
 class TestDisableVoiceModeReal:
     """Tests _disable_voice_mode with real CLI instance."""
 
@@ -1158,16 +1087,6 @@ class TestVoiceStopAndTranscribeReal:
         cli._voice_stop_and_transcribe()
         assert cli._pending_input.empty()
 
-    @patch("cli._cprint")
-    @patch("hermes_cli.config.load_config", return_value={"voice": {"beep_enabled": False}})
-    @patch("tools.voice_mode.play_beep")
-    def test_no_speech_detected_skips_beep_when_disabled(self, mock_beep, _cfg, _cp):
-        recorder = MagicMock()
-        recorder.stop.return_value = None
-        cli = _make_voice_cli(_voice_recording=True, _voice_recorder=recorder)
-        cli._voice_stop_and_transcribe()
-        mock_beep.assert_not_called()
-
     @patch("cli._cprint")
     @patch("cli.os.unlink")
     @patch("cli.os.path.isfile", return_value=True)
@@ -1237,18 +1156,12 @@ class TestVoiceStopAndTranscribeReal:
     @patch("cli._cprint")
     @patch("tools.voice_mode.play_beep")
     def test_continuous_restarts_on_no_speech(self, _beep, _cp):
-        import time
-
         recorder = MagicMock()
         recorder.stop.return_value = None
         cli = _make_voice_cli(_voice_recording=True, _voice_recorder=recorder,
                               _voice_continuous=True)
         cli._voice_start_recording = MagicMock()
         cli._voice_stop_and_transcribe()
-        for _ in range(50):
-            if cli._voice_start_recording.call_count:
-                break
-            time.sleep(0.01)
         cli._voice_start_recording.assert_called_once()
 
     @patch("cli._cprint")

website/docs/user-guide/features/voice-mode.md

@@ -149,7 +149,7 @@ Two-stage algorithm detects when you've finished speaking:
 
 If no speech is detected at all for 15 seconds, recording stops automatically.
 
-Both `silence_threshold` and `silence_duration` are configurable in `config.yaml`. You can also disable the record start/stop beeps with `voice.beep_enabled: false`.
+Both `silence_threshold` and `silence_duration` are configurable in `config.yaml`.
 
 ### Streaming TTS
 
@@ -383,7 +383,6 @@ voice:
   record_key: "ctrl+b"            # Key to start/stop recording
   max_recording_seconds: 120       # Maximum recording length
   auto_tts: false                  # Auto-enable TTS when voice mode starts
-  beep_enabled: true               # Play record start/stop beeps
   silence_threshold: 200           # RMS level (0-32767) below which counts as silence
   silence_duration: 3.0            # Seconds of silence before auto-stop