[QA] Verify CLI voice beep toggle #952

Open
opened 2026-04-22 02:22:34 +00:00 by Rockachopa · 1 comment
Owner

Parent

#949

Branch / checkout

  • Validate on upstream/main or an equivalent synced checkout.

Commit landed today

  • b48ea41d2 voice: add CLI beep toggle

Targeted tests

  • tests/tools/test_voice_cli_integration.py

Tasks

  • Enable the beep option in config and confirm voice mode emits the beep.
  • Disable the option and confirm the same path is silent.
  • Verify voice mode still strips markdown before speech output.
  • Verify voice mode does not pollute conversation history with TTS-only text.

Acceptance Criteria

  • Beep behavior is actually toggled by config.
  • Existing voice/TTS integration behavior is not regressed.
  • Targeted tests pass.
## Parent #949 ## Branch / checkout - Validate on `upstream/main` or an equivalent synced checkout. ## Commit landed today - `b48ea41d2` voice: add CLI beep toggle ## Targeted tests - `tests/tools/test_voice_cli_integration.py` ## Tasks - [ ] Enable the beep option in config and confirm voice mode emits the beep. - [ ] Disable the option and confirm the same path is silent. - [ ] Verify voice mode still strips markdown before speech output. - [ ] Verify voice mode does not pollute conversation history with TTS-only text. ## Acceptance Criteria - [ ] Beep behavior is actually toggled by config. - [ ] Existing voice/TTS integration behavior is not regressed. - [ ] Targeted tests pass.
Rockachopa added this to the Morning review — Hermes harness features landed 2026-04-21 milestone 2026-04-22 02:22:34 +00:00
Rockachopa added the QAp1-important labels 2026-04-22 02:22:34 +00:00
hermes was assigned by Rockachopa 2026-04-22 04:32:09 +00:00
Author
Owner

PR #1037 created: #1037

Validated the issue against upstream-main expectations, found forge main still missing the beep-toggle gate, backported the voice.beep_enabled path into CLI voice mode, and ran the full targeted tests/tools/test_voice_cli_integration.py file successfully.

PR #1037 created: https://forge.alexanderwhitestone.com/Timmy_Foundation/hermes-agent/pulls/1037 Validated the issue against upstream-main expectations, found forge main still missing the beep-toggle gate, backported the `voice.beep_enabled` path into CLI voice mode, and ran the full targeted `tests/tools/test_voice_cli_integration.py` file successfully.
Sign in to join this conversation.
No Label QA p1-important
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/hermes-agent#952