Timmy_Foundation/hermes-agent
15
0
Fork 0
Code Issues 282 Pull Requests 87 Actions 1 Packages Projects Releases Wiki Activity

[QA] Verify CLI voice beep toggle (#952) #1037

Open
Rockachopa wants to merge 186 commits from fix/952 into main
pull from: fix/952
merge into: Timmy_Foundation:main
Conversation 1 Commits 186 Files Changed 151 +23974 -128
Rockachopa commented 2026-04-22 15:34:02 +00:00
Owner
Copy Link

Closes #952

Summary

  • backport the upstream CLI voice beep toggle so record start/stop beeps honor voice.beep_enabled
  • add focused voice integration tests for default-on, config-off, start-recording silent mode, and stop-recording silent mode
  • document voice.beep_enabled in the voice-mode user guide and config example
  • harden the targeted voice CLI tests with local import shims and a deterministic wait for async no-speech restart

Grounding

  • issue #952 explicitly pointed at upstream/main / a synced checkout
  • forge main did not contain the upstream _voice_beeps_enabled() gate or the new beep-toggle tests
  • upstream main did contain the feature and tests, so this PR restores that slice to the fork

Acceptance

  • Beep behavior is actually toggled by config
  • Existing voice/TTS integration behavior is not regressed
  • Targeted tests pass

Verification

  • python3 -m py_compile cli.py tests/tools/test_voice_cli_integration.py
  • PYTHONPATH=/tmp/BURN-7-2 pytest -q tests/tools/test_voice_cli_integration.py
Closes #952 ## Summary - backport the upstream CLI voice beep toggle so record start/stop beeps honor `voice.beep_enabled` - add focused voice integration tests for default-on, config-off, start-recording silent mode, and stop-recording silent mode - document `voice.beep_enabled` in the voice-mode user guide and config example - harden the targeted voice CLI tests with local import shims and a deterministic wait for async no-speech restart ## Grounding - issue #952 explicitly pointed at upstream/main / a synced checkout - forge `main` did not contain the upstream `_voice_beeps_enabled()` gate or the new beep-toggle tests - upstream `main` did contain the feature and tests, so this PR restores that slice to the fork ## Acceptance - [x] Beep behavior is actually toggled by config - [x] Existing voice/TTS integration behavior is not regressed - [x] Targeted tests pass ## Verification - `python3 -m py_compile cli.py tests/tools/test_voice_cli_integration.py` - `PYTHONPATH=/tmp/BURN-7-2 pytest -q tests/tools/test_voice_cli_integration.py`
Rockachopa added 1 commit 2026-04-22 15:34:03 +00:00
fix: add CLI voice beep toggle
All checks were successful
Lint / lint (pull_request) Successful in 9s
Details
de6f0d174c 
Closes #952
claude approved these changes 2026-04-22 16:10:53 +00:00
claude left a comment
Member
Copy Link

Clean implementation. The beep toggle is well-guarded with config loading, sensible default (enabled), and proper exception handling.

Positive:

  • _voice_beeps_enabled() safely defaults to True if config loading fails
  • Tests cover default-on, config-off, and both start/stop recording paths
  • Import shims for test isolation are correct

Minor:

  1. The _ensure_cli_import_shims() is called both at module level and inside _make_voice_cli(). The module-level call should be sufficient.
  2. Consider using pytest fixtures instead of manual shim management for cleaner test setup.
Clean implementation. The beep toggle is well-guarded with config loading, sensible default (enabled), and proper exception handling. Positive: - _voice_beeps_enabled() safely defaults to True if config loading fails - Tests cover default-on, config-off, and both start/stop recording paths - Import shims for test isolation are correct Minor: 1. The _ensure_cli_import_shims() is called both at module level and inside _make_voice_cli(). The module-level call should be sufficient. 2. Consider using pytest fixtures instead of manual shim management for cleaner test setup.
All checks were successful
Lint / lint (pull_request) Successful in 9s
Details
This pull request has changes conflicting with the target branch.
  • cli.py
  • gateway/platforms/api_server.py
  • hermes_cli/models.py
  • hermes_cli/web_server.py
  • run_agent.py
  • tests/hermes_cli/test_web_server.py
  • tools/browser_tool.py
  • tools/file_tools.py
  • tools/skill_manager_tool.py
  • web/src/i18n/en.ts
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/952:fix/952
git checkout fix/952
Sign in to join this conversation.
Reviewers
No Reviewers
claude
Labels
Clear labels
CI
Continuous integration, runners, workflow issues
 QA
Quality assurance, testing, production audit
 accessibility
Auto-created for game epic
 assigned-claw-code
Queued for Code Claw (qwen/openrouter)
 assigned-kimi
Task assigned to KimiClaw for processing
 audit-finding
batch-pipeline
batch-pipeline label
 blocked
Blocked by external dependency or merge conflict
 bug
claw-code-done
Code Claw completed this task
 claw-code-in-progress
Code Claw is actively working
 critical
docs
Auto-created for game epic
 duplicate
Duplicate of another issue
 epic
Epic - large feature with multiple sub-tasks
 epic:memory
Unified Memory Architecture epic
 game
Auto-created for game epic
 gaming
Gaming agent capabilities
 implementation
Auto-created for game epic
 infra
Infrastructure, VPS, DNS, deployment
 infrastructure
Auto-created for game epic
 juice
Auto-created for game epic
 kimi-done
KimiClaw has completed this task
 kimi-in-progress
KimiClaw is actively working on this
 mcp
MCP (Model Context Protocol) tools & servers
 mechanics
Auto-created for game epic
 mobile
Auto-created for game epic
 morrowind
Morrowind Agent gameplay & MCP integration
 needs-review
PR or issue requires reviewer sign-off before merge/close
 ops
p0-critical
p1-important
performance
Auto-created for game epic
 phase:1-activate
Phase 1: Activate existing systems
 phase:2-operational
Phase 2: Operational memory bridge
 phase:3-episodic
Phase 3: Proactive episodic recall
 phase:4-hygiene
Phase 4: Memory hygiene and quality
 phase:5-integration
Phase 5: Integration and testing
 poka-yoke
polish
Auto-created for game epic
 priority-high
Auto-created for game epic
 priority-low
Auto-created for game epic
 priority-medium
Auto-created for game epic
 research
security
Security hardening, vulnerability fixes
 shared-infra
Shared infrastructure across projects (Playground + LPM)
 sovereign
Auto-created for game epic
 stale
No activity, pending triage or closure
 throughput-10x
throughput-10x label
 token-masterplan
token-masterplan label
 tool-evaluation
ux
Auto-created for game epic
 velocity-engine
Auto-generated by velocity engine
 visuals
Auto-created for game epic
 wont-fix
Closed as intentionally not fixing — explicit descope
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude claw-code codex-agent ezra gemini google grok hermes kimi manus perplexity sonnet
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/hermes-agent#1037
Delete Branch "fix/952"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?