Timmy_Foundation/hermes-agent
15
0
Fork 0
Code Issues 282 Pull Requests 87 Actions 1 Packages Projects Releases Wiki Activity

docs: verify prompt caching optimization is already implemented (#851) #1044

Open
Rockachopa wants to merge 186 commits from fix/851 into main
pull from: fix/851
merge into: Timmy_Foundation:main
Conversation 1 Commits 186 Files Changed 150 +23917 -117
Rockachopa commented 2026-04-22 15:51:27 +00:00
Owner
Copy Link

Closes #851

Summary:

  • add docs/issue-851-verification.md documenting that the prompt-caching architecture described in #851 already exists on main
  • cite the existing Anthropic/OpenRouter cache-control implementation, OpenAI/Codex prompt-cache-key support, system-prompt stability, and cache hit/miss logging
  • keep the repo delta truthful: the issue's own conclusion says no new prompt-caching implementation is required, only verification and operational follow-up

Verification:

  • PYTHONPATH=/tmp/BURN2-FORGE-ALPHA-3 python3 -m pytest -q tests/agent/test_prompt_caching.py
  • PYTHONPATH=/tmp/BURN2-FORGE-ALPHA-3 python3 -m py_compile agent/prompt_caching.py run_agent.py
Closes #851 Summary: - add `docs/issue-851-verification.md` documenting that the prompt-caching architecture described in #851 already exists on `main` - cite the existing Anthropic/OpenRouter cache-control implementation, OpenAI/Codex prompt-cache-key support, system-prompt stability, and cache hit/miss logging - keep the repo delta truthful: the issue's own conclusion says no new prompt-caching implementation is required, only verification and operational follow-up Verification: - `PYTHONPATH=/tmp/BURN2-FORGE-ALPHA-3 python3 -m pytest -q tests/agent/test_prompt_caching.py` - `PYTHONPATH=/tmp/BURN2-FORGE-ALPHA-3 python3 -m py_compile agent/prompt_caching.py run_agent.py`
Rockachopa added 1 commit 2026-04-22 15:51:28 +00:00
docs: verify prompt caching optimization is already implemented (#851)
All checks were successful
Lint / lint (pull_request) Successful in 9s
Details
d203a800a1
claude requested changes 2026-04-22 16:10:02 +00:00
claude left a comment
Member
Copy Link

REQUEST_CHANGES: This PR adds only a verification doc confirming prompt caching is already implemented. While the analysis is thorough, a standalone markdown doc whose sole purpose is to say "close this issue" belongs in an issue comment, not as a committed file.

Issues:

  1. The doc references specific line numbers (e.g., run_agent.py:8301-8306) that will drift as code changes, creating stale docs.
  2. Consider closing the issue with a comment instead of landing a verification artifact in the repo.
  3. If the doc must land, move it under docs/evaluations/ or similar, and strip the line-number references in favor of function/class names.
REQUEST_CHANGES: This PR adds only a verification doc confirming prompt caching is already implemented. While the analysis is thorough, a standalone markdown doc whose sole purpose is to say "close this issue" belongs in an issue comment, not as a committed file. Issues: 1. The doc references specific line numbers (e.g., run_agent.py:8301-8306) that will drift as code changes, creating stale docs. 2. Consider closing the issue with a comment instead of landing a verification artifact in the repo. 3. If the doc must land, move it under docs/evaluations/ or similar, and strip the line-number references in favor of function/class names.
All checks were successful
Lint / lint (pull_request) Successful in 9s
Details
This pull request has changes conflicting with the target branch.
  • cli.py
  • gateway/platforms/api_server.py
  • hermes_cli/models.py
  • hermes_cli/web_server.py
  • run_agent.py
  • tests/hermes_cli/test_web_server.py
  • tests/test_batch_executor.py
  • tools/batch_executor.py
  • tools/browser_tool.py
  • tools/file_tools.py
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/851:fix/851
git checkout fix/851
Sign in to join this conversation.
Reviewers
No Reviewers
claude
Labels
Clear labels
CI
Continuous integration, runners, workflow issues
 QA
Quality assurance, testing, production audit
 accessibility
Auto-created for game epic
 assigned-claw-code
Queued for Code Claw (qwen/openrouter)
 assigned-kimi
Task assigned to KimiClaw for processing
 audit-finding
batch-pipeline
batch-pipeline label
 blocked
Blocked by external dependency or merge conflict
 bug
claw-code-done
Code Claw completed this task
 claw-code-in-progress
Code Claw is actively working
 critical
docs
Auto-created for game epic
 duplicate
Duplicate of another issue
 epic
Epic - large feature with multiple sub-tasks
 epic:memory
Unified Memory Architecture epic
 game
Auto-created for game epic
 gaming
Gaming agent capabilities
 implementation
Auto-created for game epic
 infra
Infrastructure, VPS, DNS, deployment
 infrastructure
Auto-created for game epic
 juice
Auto-created for game epic
 kimi-done
KimiClaw has completed this task
 kimi-in-progress
KimiClaw is actively working on this
 mcp
MCP (Model Context Protocol) tools & servers
 mechanics
Auto-created for game epic
 mobile
Auto-created for game epic
 morrowind
Morrowind Agent gameplay & MCP integration
 needs-review
PR or issue requires reviewer sign-off before merge/close
 ops
p0-critical
p1-important
performance
Auto-created for game epic
 phase:1-activate
Phase 1: Activate existing systems
 phase:2-operational
Phase 2: Operational memory bridge
 phase:3-episodic
Phase 3: Proactive episodic recall
 phase:4-hygiene
Phase 4: Memory hygiene and quality
 phase:5-integration
Phase 5: Integration and testing
 poka-yoke
polish
Auto-created for game epic
 priority-high
Auto-created for game epic
 priority-low
Auto-created for game epic
 priority-medium
Auto-created for game epic
 research
security
Security hardening, vulnerability fixes
 shared-infra
Shared infrastructure across projects (Playground + LPM)
 sovereign
Auto-created for game epic
 stale
No activity, pending triage or closure
 throughput-10x
throughput-10x label
 token-masterplan
token-masterplan label
 tool-evaluation
ux
Auto-created for game epic
 velocity-engine
Auto-generated by velocity engine
 visuals
Auto-created for game epic
 wont-fix
Closed as intentionally not fixing — explicit descope
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude claw-code codex-agent ezra gemini google grok hermes kimi manus perplexity sonnet
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/hermes-agent#1044
Delete Branch "fix/851"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?