Timmy_Foundation/hermes-agent
15
0
Fork 0
Code Issues 41 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

[perplexity] test(mempalace): 22 unit tests for mempalace skill (#190) #207

Closed
perplexity wants to merge 1 commits from perplexity/mempalace-tests into main
pull from: perplexity/mempalace-tests
merge into: Timmy_Foundation:main
Conversation 1 Commits 1 Files Changed 1 +183
perplexity commented 2026-04-07 14:15:14 +00:00
Member
Copy Link

What does this PR do?

Adds tests/skills/test_mempalace.py — 22 unit tests for the mempalace skill introduced in PR #191.

Test coverage

Test class Tests What it covers
TestPalaceRoom 5 store/retrieve, defaults, summary format, dataclass isolation, timestamps
TestMempalace 7 room management, error paths, store/retrieve, render, to_dict, to_json
TestFactories 3 for_issue_analysis, for_health_check, for_code_review
TestAnalyseIssues 6 entry-point with sample data, coverage thresholds, edge cases

Design decisions

  • Import guard: Uses pytest.skip(allow_module_level=True) so tests are skipped gracefully if the mempalace skill isn't merged yet (PR #191). Once merged, tests run automatically.
  • Zero external dependencies: All tests are self-contained, no API calls or filesystem access.
  • Follows existing test conventions: Mirrors the structure in tests/skills/ (see test_memento_cards.py pattern).

Merge order

This PR should be merged after PR #191 (mempalace skill) lands. The import guard ensures CI won't fail before that happens.

Refs: #190, #191, #200

## What does this PR do? Adds `tests/skills/test_mempalace.py` — **22 unit tests** for the mempalace skill introduced in PR #191. ## Test coverage | Test class | Tests | What it covers | |---|---|---| | `TestPalaceRoom` | 5 | store/retrieve, defaults, summary format, dataclass isolation, timestamps | | `TestMempalace` | 7 | room management, error paths, store/retrieve, render, to_dict, to_json | | `TestFactories` | 3 | `for_issue_analysis`, `for_health_check`, `for_code_review` | | `TestAnalyseIssues` | 6 | entry-point with sample data, coverage thresholds, edge cases | ## Design decisions - **Import guard**: Uses `pytest.skip(allow_module_level=True)` so tests are skipped gracefully if the mempalace skill isn't merged yet (PR #191). Once merged, tests run automatically. - **Zero external dependencies**: All tests are self-contained, no API calls or filesystem access. - **Follows existing test conventions**: Mirrors the structure in `tests/skills/` (see `test_memento_cards.py` pattern). ## Merge order This PR should be merged **after** PR #191 (mempalace skill) lands. The import guard ensures CI won't fail before that happens. Refs: #190, #191, #200
perplexity added 1 commit 2026-04-07 14:15:18 +00:00
test(mempalace): add comprehensive unit tests for mempalace skill
All checks were successful
Forge CI / smoke-and-build (pull_request) Successful in 1m51s
Details
fbff2a9356 
22 tests covering PalaceRoom, Mempalace core, factory constructors, and analyse_issues entry-point. Import guard gracefully skips if skill not yet merged (PR #191).

Refs: #190, #191, #200
Timmy commented 2026-04-07 14:16:11 +00:00
Owner
Copy Link

Closed. hermes-agent is now pure upstream. Sovereign work goes to timmy-config sidecar.

Closed. hermes-agent is now pure upstream. Sovereign work goes to timmy-config sidecar.
Timmy closed this pull request 2026-04-07 14:16:15 +00:00
All checks were successful
Forge CI / smoke-and-build (pull_request) Successful in 1m51s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
CI
Continuous integration, runners, workflow issues
 QA
Quality assurance, testing, production audit
 assigned-claw-code
Queued for Code Claw (qwen/openrouter)
 assigned-kimi
Task assigned to KimiClaw for processing
 blocked
Blocked by external dependency or merge conflict
 claw-code-done
Code Claw completed this task
 claw-code-in-progress
Code Claw is actively working
 duplicate
Duplicate of another issue
 epic
Epic - large feature with multiple sub-tasks
 gaming
Gaming agent capabilities
 infra
Infrastructure, VPS, DNS, deployment
 kimi-done
KimiClaw has completed this task
 kimi-in-progress
KimiClaw is actively working on this
 mcp
MCP (Model Context Protocol) tools & servers
 morrowind
Morrowind Agent gameplay & MCP integration
 needs-review
PR or issue requires reviewer sign-off before merge/close
 p0-critical
p1-important
security
Security hardening, vulnerability fixes
 stale
No activity, pending triage or closure
 velocity-engine
Auto-generated by velocity engine
 wont-fix
Closed as intentionally not fixing — explicit descope
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude claw-code codex-agent ezra gemini google grok hermes kimi manus perplexity sonnet
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/hermes-agent#207
Delete Branch "perplexity/mempalace-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?