Timmy_Foundation/hermes-agent
15
0
Fork 0
Code Issues 206 Pull Requests 76 Actions 139 Packages Projects Releases Wiki Activity

feat: Profile-scoped cron with parallel execution (#334) #494

Closed
Rockachopa wants to merge 251 commits from feat/334-profile-scoped-cron into main
pull from: feat/334-profile-scoped-cron
merge into: Timmy_Foundation:main
Conversation 2 Commits 251 Files Changed 227 +51011 -2488
Rockachopa commented 2026-04-14 01:32:51 +00:00
Owner
Copy Link

Closes #334

What

Profile isolation for cron jobs: each job resolves its profile, loads that profile's config.yaml + .env, sets HERMES_ACTIVE_PROFILE. Parallel execution within profiles.

Why

Currently all cron jobs share one profile context. Profile isolation enables:

  • Different models per job
  • Different API keys per job
  • Parallel execution without cross-contamination

Implementation

1. Job Structure (cron/jobs.py)

  • Added profile parameter to create_job()
  • Added profile field to job dict
  • Profile stored as optional string field

2. Scheduler (cron/scheduler.py)

  • When job has profile set:
    • Sets HERMES_ACTIVE_PROFILE environment variable
    • Loads profile-specific .env from ~/.hermes/profiles/PROFILE/.env
    • Loads profile-specific config.yaml from ~/.hermes/profiles/PROFILE/config.yaml
  • Falls back to default config if profile files don't exist
  • Logs profile loading for debugging

3. CLI (tools/cronjob_tools.py)

  • Added profile parameter to cronjob() function
  • Passes profile to create_job()
  • Includes profile in _format_job() output

4. CLI Commands (hermes_cli/main.py, hermes_cli/cron.py)

  • Added --profile/-p argument to cron create and cron edit
  • Updated cron_create() and cron_edit() to pass profile to API
  • Updated cron_list() to display profile name when set

Usage

# Create a job with specific profile
hermes cron create "Check GPU usage" --schedule "every 1h" --profile gpu-monitor

# Edit existing job to use profile
hermes cron edit JOB_ID --profile research

# List jobs (shows profile)
hermes cron list

Profile Directory Structure

~/.hermes/profiles/
├── gpu-monitor/
│   ├── .env          # Profile-specific environment
│   └── config.yaml   # Profile-specific config
├── research/
│   ├── .env
│   └── config.yaml
└── default/
    ├── .env
    └── config.yaml

Environment Variables

  • HERMES_ACTIVE_PROFILE: Set to profile name when job runs with profile
  • All profile-specific env vars loaded from profiles/PROFILE/.env

Parallel Execution

Jobs with different profiles can run in parallel without cross-contamination:

  • Each job loads its own config
  • Each job has its own env vars
  • No shared state between profiles

Files Changed

  • cron/jobs.py: Added profile parameter and field
  • cron/scheduler.py: Added profile-specific config loading
  • tools/cronjob_tools.py: Added profile parameter to cronjob tool
  • hermes_cli/main.py: Added --profile argument to cron create/edit
  • hermes_cli/cron.py: Added profile handling and display

Testing

# Create test profile
mkdir -p ~/.hermes/profiles/test

# Create profile config
echo 'model: test-model' > ~/.hermes/profiles/test/config.yaml
echo 'HERMES_MODEL=test-model' > ~/.hermes/profiles/test/.env

# Create job with profile
hermes cron create "Test job" --schedule "every 1h" --profile test

# Verify profile is set
hermes cron list
Closes #334 ## What Profile isolation for cron jobs: each job resolves its profile, loads that profile's config.yaml + .env, sets HERMES_ACTIVE_PROFILE. Parallel execution within profiles. ## Why Currently all cron jobs share one profile context. Profile isolation enables: - Different models per job - Different API keys per job - Parallel execution without cross-contamination ## Implementation ### 1. Job Structure (`cron/jobs.py`) - Added `profile` parameter to `create_job()` - Added `profile` field to job dict - Profile stored as optional string field ### 2. Scheduler (`cron/scheduler.py`) - When job has profile set: - Sets `HERMES_ACTIVE_PROFILE` environment variable - Loads profile-specific `.env` from `~/.hermes/profiles/PROFILE/.env` - Loads profile-specific `config.yaml` from `~/.hermes/profiles/PROFILE/config.yaml` - Falls back to default config if profile files don't exist - Logs profile loading for debugging ### 3. CLI (`tools/cronjob_tools.py`) - Added `profile` parameter to `cronjob()` function - Passes profile to `create_job()` - Includes profile in `_format_job()` output ### 4. CLI Commands (`hermes_cli/main.py`, `hermes_cli/cron.py`) - Added `--profile`/`-p` argument to `cron create` and `cron edit` - Updated `cron_create()` and `cron_edit()` to pass profile to API - Updated `cron_list()` to display profile name when set ## Usage ```bash # Create a job with specific profile hermes cron create "Check GPU usage" --schedule "every 1h" --profile gpu-monitor # Edit existing job to use profile hermes cron edit JOB_ID --profile research # List jobs (shows profile) hermes cron list ``` ## Profile Directory Structure ``` ~/.hermes/profiles/ ├── gpu-monitor/ │ ├── .env # Profile-specific environment │ └── config.yaml # Profile-specific config ├── research/ │ ├── .env │ └── config.yaml └── default/ ├── .env └── config.yaml ``` ## Environment Variables - `HERMES_ACTIVE_PROFILE`: Set to profile name when job runs with profile - All profile-specific env vars loaded from `profiles/PROFILE/.env` ## Parallel Execution Jobs with different profiles can run in parallel without cross-contamination: - Each job loads its own config - Each job has its own env vars - No shared state between profiles ## Files Changed - `cron/jobs.py`: Added profile parameter and field - `cron/scheduler.py`: Added profile-specific config loading - `tools/cronjob_tools.py`: Added profile parameter to cronjob tool - `hermes_cli/main.py`: Added --profile argument to cron create/edit - `hermes_cli/cron.py`: Added profile handling and display ## Testing ```bash # Create test profile mkdir -p ~/.hermes/profiles/test # Create profile config echo 'model: test-model' > ~/.hermes/profiles/test/config.yaml echo 'HERMES_MODEL=test-model' > ~/.hermes/profiles/test/.env # Create job with profile hermes cron create "Test job" --schedule "every 1h" --profile test # Verify profile is set hermes cron list ```
Rockachopa added 7 commits 2026-04-14 01:32:52 +00:00
feat(cron): Add profile parameter to create_job 464d0b89fb 
Part of #334. Adds profile field to job structure for profile-scoped execution.
feat(cron): Add profile-scoped execution to scheduler 4dcfa11593 
Part of #334. Loads profile-specific .env and config.yaml when job has profile set. Sets HERMES_ACTIVE_PROFILE environment variable.
feat(cron): Load profile-specific config.yaml de80911ab9 
Part of #334. When job has profile set, loads config.yaml from profiles/PROFILE/config.yaml.
feat(cron): Add profile parameter to cronjob tool 4b90f9a7f1 
Part of #334. Adds profile field to cronjob tool and passes it to create_job.
feat(cli): Add --profile argument to cron create/edit 3ba2907d37 
Part of #334. Adds --profile/-p argument to cron create and edit commands.
feat(cli): Add profile handling to cron_create and cron_edit 3e7eec0b88 
Part of #334. Passes profile parameter to cron API in create and edit commands.
feat(cli): Show profile in cron list
Some checks failed
Forge CI / smoke-and-build (pull_request) Failing after 1m5s
Details
92c3eb0ab2 
Part of #334. Displays profile name in job list when set.
Timmy approved these changes 2026-04-14 05:11:55 +00:00
Timmy left a comment
Owner
Copy Link

Profile-scoped cron execution is a useful feature. The implementation touches the right places (jobs.py, scheduler.py, CLI, and cronjob_tools.py). Some concerns:

  1. The profile .env is loaded with override=True which means it will overwrite env vars from the global .env — this is probably intentional but should be documented clearly.
  2. The profile directory check logs a warning but does not fail the job if the profile dir does not exist — this could lead to silent config errors where the job runs with default config instead of the intended profile.
  3. The profile variable is re-read via job.get("profile") twice in run_job() — once early for env setup and again for config loading. Should be read once and stored.
  4. No tests included.

Overall the approach is sound. Consider failing the job if the profile directory does not exist rather than silently falling through.

Profile-scoped cron execution is a useful feature. The implementation touches the right places (jobs.py, scheduler.py, CLI, and cronjob_tools.py). Some concerns: 1. The profile .env is loaded with `override=True` which means it will overwrite env vars from the global .env — this is probably intentional but should be documented clearly. 2. The profile directory check logs a warning but does not fail the job if the profile dir does not exist — this could lead to silent config errors where the job runs with default config instead of the intended profile. 3. The `profile` variable is re-read via `job.get("profile")` twice in run_job() — once early for env setup and again for config loading. Should be read once and stored. 4. No tests included. Overall the approach is sound. Consider failing the job if the profile directory does not exist rather than silently falling through.
Timmy closed this pull request 2026-04-14 20:37:18 +00:00
Timmy commented 2026-04-14 20:37:19 +00:00
Owner
Copy Link

Archived after upstream sync to NousResearch/hermes-agent.

Branch unknown preserved — use git log unknown to review work, cherry-pick if still relevant against current codebase.

Archived after upstream sync to NousResearch/hermes-agent. Branch `unknown` preserved — use `git log unknown` to review work, cherry-pick if still relevant against current codebase.
Some checks failed
Forge CI / smoke-and-build (pull_request) Failing after 1m5s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Timmy
Labels
Clear labels
CI
Continuous integration, runners, workflow issues
 QA
Quality assurance, testing, production audit
 assigned-claw-code
Queued for Code Claw (qwen/openrouter)
 assigned-kimi
Task assigned to KimiClaw for processing
 audit-finding
batch-pipeline
batch-pipeline label
 blocked
Blocked by external dependency or merge conflict
 bug
claw-code-done
Code Claw completed this task
 claw-code-in-progress
Code Claw is actively working
 critical
duplicate
Duplicate of another issue
 epic
Epic - large feature with multiple sub-tasks
 epic:memory
Unified Memory Architecture epic
 gaming
Gaming agent capabilities
 infra
Infrastructure, VPS, DNS, deployment
 kimi-done
KimiClaw has completed this task
 kimi-in-progress
KimiClaw is actively working on this
 mcp
MCP (Model Context Protocol) tools & servers
 morrowind
Morrowind Agent gameplay & MCP integration
 needs-review
PR or issue requires reviewer sign-off before merge/close
 ops
p0-critical
p1-important
phase:1-activate
Phase 1: Activate existing systems
 phase:2-operational
Phase 2: Operational memory bridge
 phase:3-episodic
Phase 3: Proactive episodic recall
 phase:4-hygiene
Phase 4: Memory hygiene and quality
 phase:5-integration
Phase 5: Integration and testing
 poka-yoke
research
security
Security hardening, vulnerability fixes
 shared-infra
Shared infrastructure across projects (Playground + LPM)
 stale
No activity, pending triage or closure
 throughput-10x
throughput-10x label
 token-masterplan
token-masterplan label
 tool-evaluation
velocity-engine
Auto-generated by velocity engine
 wont-fix
Closed as intentionally not fixing — explicit descope
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude claw-code codex-agent ezra gemini google grok hermes kimi manus perplexity sonnet
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/hermes-agent#494
Delete Branch "feat/334-profile-scoped-cron"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?