101 lines
2.4 KiB
Markdown
101 lines
2.4 KiB
Markdown
# Issue #954 Verification — maps skill guest_house / camp_site / bakery
|
|
|
|
Status: PASS
|
|
|
|
## Drift noted
|
|
|
|
Issue #954 asked for validation on `upstream/main` (commit `c5a814b23`).
|
|
Fresh `forge/main` did not contain `skills/productivity/maps/`, so the forge branch was behind upstream for this feature cluster.
|
|
This branch ports the upstream maps skill files into the forge checkout and adds regression coverage.
|
|
|
|
## Automated verification
|
|
|
|
Command:
|
|
|
|
```bash
|
|
pytest -q tests/skills/test_maps_client.py
|
|
```
|
|
|
|
Result:
|
|
|
|
- 5 passed
|
|
|
|
Coverage added:
|
|
|
|
- maps skill files exist in the repo
|
|
- `guest_house` category maps to `tourism=guest_house`
|
|
- `camp_site` category maps to `tourism=camp_site`
|
|
- `bakery` expands to both `shop=bakery` and `amenity=bakery`
|
|
- dual-key bakery results dedupe correctly
|
|
- skill documentation lists the new categories and supersedes `find-nearby`
|
|
|
|
## Manual evidence
|
|
|
|
### 1) guest_house lookup
|
|
|
|
Command:
|
|
|
|
```bash
|
|
python3 skills/productivity/maps/scripts/maps_client.py nearby --near "Bath, United Kingdom" --category guest_house --limit 3
|
|
```
|
|
|
|
Observed results:
|
|
|
|
- Henrietta House — 390.3 m
|
|
- The Windsor — 437.2 m
|
|
- The Old Rectory Bed & Breakfast — 495.7 m
|
|
|
|
All returned `tourism=guest_house` in the raw tags.
|
|
|
|
### 2) camp_site lookup
|
|
|
|
Command:
|
|
|
|
```bash
|
|
python3 skills/productivity/maps/scripts/maps_client.py nearby --near "Yosemite Valley, California" --category camp_site --limit 5
|
|
```
|
|
|
|
Observed result:
|
|
|
|
- Yellow Pine Administrative Campground — 90.3 m
|
|
|
|
Returned `tourism=camp_site` in the raw tags.
|
|
|
|
### 3) bakery lookup via `shop=bakery`
|
|
|
|
Command:
|
|
|
|
```bash
|
|
python3 skills/productivity/maps/scripts/maps_client.py nearby --near "Lawrenceville, New Jersey" --category bakery --radius 5000 --limit 10
|
|
```
|
|
|
|
Observed results:
|
|
|
|
- The Gingered Peach — 713.8 m
|
|
- WildFlour Bakery — 741.9 m
|
|
|
|
Both returned `shop=bakery` in the raw tags.
|
|
|
|
### 4) bakery lookup via `amenity=bakery`
|
|
|
|
Command:
|
|
|
|
```bash
|
|
python3 skills/productivity/maps/scripts/maps_client.py nearby --near "20735 Stevens Creek Boulevard, Cupertino, CA" --category bakery --radius 600 --limit 5
|
|
```
|
|
|
|
Observed result:
|
|
|
|
- Paris Baguette — 28.6 m
|
|
|
|
Returned `amenity=bakery` in the raw tags (and also includes `shop=bakery`), proving the dual-key union query reaches amenity-tagged bakeries too.
|
|
|
|
## Conclusion
|
|
|
|
PASS.
|
|
|
|
- `guest_house` resolves correctly
|
|
- `camp_site` resolves correctly
|
|
- `bakery` resolves through both supported keys
|
|
- forge/main drift from upstream/main was real and is addressed on this branch
|