Timmy_Foundation/the-beacon
15
0
Fork 0
Code Issues 12 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(a11y): accessibility improvements — aria-labels, URL revoke race, duplicate cleanup #63

Closed
Timmy wants to merge 2 commits from burn/a11y-aria-labels into main
pull from: burn/a11y-aria-labels
merge into: Timmy_Foundation:main
Conversation 14 Commits 2 Files Changed 4 +10 -42
Timmy commented 2026-04-11 03:56:52 +00:00
Owner
Copy Link

Closes #49

Changes

Missing aria-labels fixed:

  • Help overlay close button
  • Drift ending START OVER button
  • Offline popup Continue button

exportSave() URL revoke race fixed:

  • URL.revokeObjectURL() called synchronously after a.click() — some browsers need the URL alive during download initiation. Now delayed 1s via setTimeout.

Duplicate exportSave/importSave removed from utils.js:

  • utils.js had clipboard-based versions, render.js has file-based versions. Since render.js loads last, its definitions won. Removed the dead code in utils.js to eliminate confusion.
Closes #49 ## Changes **Missing aria-labels fixed:** - Help overlay close button - Drift ending START OVER button - Offline popup Continue button **exportSave() URL revoke race fixed:** - `URL.revokeObjectURL()` called synchronously after `a.click()` — some browsers need the URL alive during download initiation. Now delayed 1s via setTimeout. **Duplicate exportSave/importSave removed from utils.js:** - utils.js had clipboard-based versions, render.js has file-based versions. Since render.js loads last, its definitions won. Removed the dead code in utils.js to eliminate confusion.
Timmy added 1 commit 2026-04-11 03:56:53 +00:00
fix(a11y): add missing aria-labels to overlay buttons, fix exportSave URL revoke race, remove duplicate export/import in utils.js
Some checks failed
Accessibility Checks / a11y-audit (pull_request) Failing after 2s
Details
Smoke Test / smoke (pull_request) Failing after 3s
Details
ed48327f3d 
- Add aria-label to help overlay close button, drift ending START OVER button, offline popup Continue button
- Fix exportSave() URL.revokeObjectURL race condition (delay 1s before revoke)
- Remove duplicate exportSave/importSave definitions in utils.js (render.js has canonical file-based versions)
- All buttons now have aria-labels for screen reader accessibility

Closes #49
Timmy commented 2026-04-11 05:33:52 +00:00
Author
Owner
Copy Link

🤖 Auto-Merge Blocked — CI Failing

Required status checks are failing:

  • Smoke Test / smoke (pull_request): failing
  • Accessibility Checks / a11y-audit (pull_request): failing

Please fix the failing checks.

🤖 **Auto-Merge Blocked — CI Failing** Required status checks are failing: - `Smoke Test / smoke (pull_request)`: **failing** - `Accessibility Checks / a11y-audit (pull_request)`: **failing** Please fix the failing checks.
Rockachopa commented 2026-04-11 09:32:09 +00:00
Owner
Copy Link

🚫 Blocked: Required status checks failing — Same CI infrastructure issue. Smoke Test + Accessibility Checks fail in <4s.

🚫 **Blocked: Required status checks failing** — Same CI infrastructure issue. Smoke Test + Accessibility Checks fail in <4s.
codex-agent was assigned by Rockachopa 2026-04-11 09:45:09 +00:00
Timmy commented 2026-04-11 10:11:04 +00:00
Author
Owner
Copy Link

🚫 Cannot merge — CI failing.

• Smoke Test / smoke: ❌
• Accessibility Checks / a11y-audit: ❌

Please fix the CI failures before merging.

🚫 **Cannot merge — CI failing.** • Smoke Test / smoke: ❌ • Accessibility Checks / a11y-audit: ❌ Please fix the CI failures before merging.
Timmy commented 2026-04-11 18:54:24 +00:00
Author
Owner
Copy Link

This PR now has merge conflicts after merging #65 and #66. Please rebase on latest main.

This PR now has merge conflicts after merging #65 and #66. Please rebase on latest main.
Timmy commented 2026-04-11 20:24:09 +00:00
Author
Owner
Copy Link

🤖 Timmy PR Review Bot

This PR has merge conflicts with main. Please rebase or resolve conflicts.

🤖 **Timmy PR Review Bot** This PR has merge conflicts with `main`. Please rebase or resolve conflicts.
Timmy commented 2026-04-11 21:45:53 +00:00
Author
Owner
Copy Link

Blocked: merge conflicts with current main. Please rebase to resolve conflicts so the accessibility improvements can be reviewed and merged.

**Blocked: merge conflicts** with current `main`. Please rebase to resolve conflicts so the accessibility improvements can be reviewed and merged.
Timmy commented 2026-04-11 23:17:50 +00:00
Author
Owner
Copy Link

Blocked: Merge conflict. This PR has mergeable: false — it conflicts with the current main branch. The PR needs to be rebased or have conflicts resolved before it can be merged.

**Blocked: Merge conflict.** This PR has `mergeable: false` — it conflicts with the current `main` branch. The PR needs to be rebased or have conflicts resolved before it can be merged.
Timmy commented 2026-04-12 04:51:51 +00:00
Author
Owner
Copy Link

⚠️ Blocked: Merge conflicts detected.

This PR (burn/a11y-aria-labels → main) has merge conflicts that must be resolved before merging. The branch has diverged from main — likely because other PRs touching the same files have been merged since this branch was created.

Action needed: Rebase or merge main into burn/a11y-aria-labels, resolve conflicts, and push the update.

⚠️ **Blocked: Merge conflicts detected.** This PR (`burn/a11y-aria-labels` → `main`) has merge conflicts that must be resolved before merging. The branch has diverged from main — likely because other PRs touching the same files have been merged since this branch was created. **Action needed:** Rebase or merge `main` into `burn/a11y-aria-labels`, resolve conflicts, and push the update.
Timmy commented 2026-04-12 05:33:47 +00:00
Author
Owner
Copy Link

🚫 Merge blocked by Timmy PR review cron job.

This PR has merge conflicts with the base branch. Please rebase or resolve conflicts.

Please rebase this branch onto main and resolve any conflicts.

🚫 **Merge blocked by Timmy PR review cron job.** This PR has merge conflicts with the base branch. Please rebase or resolve conflicts. Please rebase this branch onto `main` and resolve any conflicts.
Timmy commented 2026-04-12 06:09:07 +00:00
Author
Owner
Copy Link

⚠️ Blocked: merge conflict

This PR has conflicts with main. It overlaps significantly with PR #70 (just merged) — both remove duplicate exportSave/importSave from utils.js and add a comment explaining why.

To fix: Rebase burn/a11y-aria-labels onto the latest main. The aria-label fixes and URL revoke race fix are still needed — just the utils.js dead code removal is already done by #70. After rebase, keep only the unique changes (aria-labels + URL revoke).

⚠️ **Blocked: merge conflict** This PR has conflicts with `main`. It overlaps significantly with PR #70 (just merged) — both remove duplicate `exportSave`/`importSave` from `utils.js` and add a comment explaining why. **To fix:** Rebase `burn/a11y-aria-labels` onto the latest `main`. The aria-label fixes and URL revoke race fix are still needed — just the `utils.js` dead code removal is already done by #70. After rebase, keep only the unique changes (aria-labels + URL revoke).
Rockachopa commented 2026-04-12 07:02:07 +00:00
Owner
Copy Link

PR Review — Blocked

Status: ❌ Cannot merge

Issues:

  1. Merge conflicts — Branch burn/a11y-aria-labels has conflicts with main that must be resolved manually
  2. CI failing — Smoke Test and Accessibility Checks are failing

Diff: 3 files changed (index.html, js/render.js, js/utils.js) — mostly cleanup and aria-label additions. The changes look reasonable in isolation but need the conflicts resolved first.

## PR Review — Blocked **Status:** ❌ Cannot merge **Issues:** 1. **Merge conflicts** — Branch `burn/a11y-aria-labels` has conflicts with `main` that must be resolved manually 2. **CI failing** — Smoke Test and Accessibility Checks are failing **Diff:** 3 files changed (`index.html`, `js/render.js`, `js/utils.js`) — mostly cleanup and aria-label additions. The changes look reasonable in isolation but need the conflicts resolved first.
Timmy commented 2026-04-12 08:37:37 +00:00
Author
Owner
Copy Link

PR Triage — Blocked: Merge Conflict

This PR (burn/a11y-aria-labels → main) reports mergeable: false. The branch is behind current main and has conflicts that need manual resolution.

Action needed:

  1. Rebase or merge main into burn/a11y-aria-labels
  2. Resolve any conflicts
  3. Push the updated branch — PR will re-check mergeability

Once the branch is up to date and conflict-free, this PR can be merged.

**PR Triage — Blocked: Merge Conflict** This PR (`burn/a11y-aria-labels` → `main`) reports `mergeable: false`. The branch is behind current `main` and has conflicts that need manual resolution. **Action needed:** 1. Rebase or merge `main` into `burn/a11y-aria-labels` 2. Resolve any conflicts 3. Push the updated branch — PR will re-check mergeability Once the branch is up to date and conflict-free, this PR can be merged.
Timmy commented 2026-04-12 09:29:31 +00:00
Author
Owner
Copy Link

Automated Review — Already merged

This PR's changes are already present in main. Checked all 3 changed files:

  • index.html — aria-labels already applied
  • js/render.js — setTimeout URL revoke fix already applied
  • js/utils.js — duplicate cleanup already done

This PR can be safely closed. The CI failures (smoke test, a11y-audit) are expected since the branch is stale.

Recommendation: Close this PR — changes are already merged.

**Automated Review — Already merged** This PR's changes are already present in `main`. Checked all 3 changed files: - `index.html` — aria-labels already applied - `js/render.js` — setTimeout URL revoke fix already applied - `js/utils.js` — duplicate cleanup already done This PR can be safely closed. The CI failures (smoke test, a11y-audit) are expected since the branch is stale. **Recommendation:** Close this PR — changes are already merged.
hermes commented 2026-04-12 11:35:00 +00:00
Member
Copy Link

🤖 Timmy PR Review — Status: Blocked

CI: ❌ Failing

  • Smoke Test / smoke — Failing after 3s
  • Accessibility Checks / a11y-audit — Failing after 2s

Merge: ❌ Conflicts with base branch. Cannot auto-merge.

Changes (6 additions, 42 deletions):

  • Added aria-label attributes to buttons (Close help, Start over, Continue)
  • Fixed URL revoke race in save export (setTimeout before revokeObjectURL)
  • Cleaned up duplicate exportSave function

Note: Clean a11y improvements. Needs conflict resolution to merge.

**🤖 Timmy PR Review — Status: Blocked** **CI:** ❌ Failing - Smoke Test / smoke — Failing after 3s - Accessibility Checks / a11y-audit — Failing after 2s **Merge:** ❌ Conflicts with base branch. Cannot auto-merge. **Changes (6 additions, 42 deletions):** - Added `aria-label` attributes to buttons (Close help, Start over, Continue) - Fixed URL revoke race in save export (setTimeout before revokeObjectURL) - Cleaned up duplicate `exportSave` function **Note:** Clean a11y improvements. Needs conflict resolution to merge.
gemini added 1 commit 2026-04-12 12:13:34 +00:00
Test push to PR branch
Some checks failed
Accessibility Checks / a11y-audit (pull_request) Failing after 2s
Details
Smoke Test / smoke (pull_request) Failing after 4s
Details
0b3fc4a404
gemini closed this pull request 2026-04-12 12:18:49 +00:00
Some checks failed
Accessibility Checks / a11y-audit (pull_request) Failing after 2s
Details
Smoke Test / smoke (pull_request) Failing after 4s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
P1
P2
P3
architecture
devops
documentation
education
endgame
gameplay
mechanics
narrative
polish
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude codex-agent ezra gemini google grok hermes kimi manus perplexity
No Assignees codex-agent
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/the-beacon#63
Delete Branch "burn/a11y-aria-labels"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?