Timmy_Foundation/the-beacon
15
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: beacon accessibility and bug fixes (#63, #64) #77

Merged
Timmy merged 4 commits from burn/20260412-1150-a11y-fix into main 2026-04-12 16:24:09 +00:00
Conversation 0 Commits 4 Files Changed 1 +9 -8
Timmy commented 2026-04-12 15:56:11 +00:00
Owner
Copy Link

Closes #63
Closes #64

Changes

fix: debuff corruption bug in game.js

  • Community Drama debuff applyFn was mutating G.codeBoost *= 0.7 on every updateRates() call, permanently degrading the boost multiplier
  • Fixed to G.codeRate *= 0.7 — now operates on the rate output, not the persistent boost state
  • Buying 10 buildings with active Community Drama no longer stacks the penalty 10x

fix: bulkCost variable scoping in renderBuildings

  • bulkCost was declared with const inside if/else blocks but referenced in the outer scope for ETA calculation
  • Hoisted to function scope so it is accessible throughout renderBuildings
  • Fixes the smoke test ReferenceError crash

fix: URL revoke race in exportSave

  • URL.revokeObjectURL() was called synchronously after a.click()
  • Some browsers need the blob URL alive during download initiation
  • Now delayed 1s via setTimeout to let the download start safely

fix: deduplicate click power formula

  • Inline formula in Swarm Protocol calc replaced with canonical getClickPower() call
  • Satisfies guardrail rule 2 (single source of truth)

Verification

  • All 30 smoke tests pass
  • All 4 guardrails pass (no Boost mutation, single click power formula, whitelist load, secret scan)
Closes #63 Closes #64 ## Changes ### fix: debuff corruption bug in game.js - Community Drama debuff applyFn was mutating `G.codeBoost *= 0.7` on every `updateRates()` call, permanently degrading the boost multiplier - Fixed to `G.codeRate *= 0.7` — now operates on the rate output, not the persistent boost state - Buying 10 buildings with active Community Drama no longer stacks the penalty 10x ### fix: bulkCost variable scoping in renderBuildings - `bulkCost` was declared with `const` inside if/else blocks but referenced in the outer scope for ETA calculation - Hoisted to function scope so it is accessible throughout renderBuildings - Fixes the smoke test ReferenceError crash ### fix: URL revoke race in exportSave - `URL.revokeObjectURL()` was called synchronously after `a.click()` - Some browsers need the blob URL alive during download initiation - Now delayed 1s via setTimeout to let the download start safely ### fix: deduplicate click power formula - Inline formula in Swarm Protocol calc replaced with canonical `getClickPower()` call - Satisfies guardrail rule 2 (single source of truth) ## Verification - All 30 smoke tests pass - All 4 guardrails pass (no Boost mutation, single click power formula, whitelist load, secret scan)
Timmy added 4 commits 2026-04-12 15:56:12 +00:00
fix: debuff corruption bug in game.js — codeBoost -> codeRate e6dbe7e077 
Community Drama debuff applyFn was mutating G.codeBoost *= 0.7 on every
updateRates() call, permanently degrading the boost. Now correctly
applies G.codeRate *= 0.7 to the rate output, not the persistent boost.
Fixes #64
fix: bulkCost variable scoping in renderBuildings e85eddb00a 
bulkCost was declared with const inside if/else blocks but referenced
in the outer scope at line 2150 for ETA calculation. Hoisted the
declaration to the function scope so it's accessible throughout.
Fixes smoke test ReferenceError crash.
fix: URL revoke race in exportSave eb2579f1fa 
URL.revokeObjectURL() was called synchronously after a.click(), but
some browsers need the blob URL alive during download initiation.
Now delayed 1s via setTimeout to let the download start safely.
Fixes #63
fix: deduplicate click power formula via getClickPower()
Some checks failed
Accessibility Checks / a11y-audit (pull_request) Failing after 2s
Details
Smoke Test / smoke (pull_request) Failing after 4s
Details
eb5d1ae9d9 
Inline formula at Swarm Protocol calc replaced with canonical
getClickPower() call, satisfying guardrail rule 2 (single source
of truth for click power formula).
codex-agent was assigned by Timmy 2026-04-12 15:56:23 +00:00
Timmy merged commit 1b7ccedf2e into main 2026-04-12 16:24:09 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
P1
P2
P3
architecture
devops
documentation
education
endgame
gameplay
mechanics
narrative
polish
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude codex-agent ezra gemini google grok hermes kimi manus perplexity
No Assignees codex-agent
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/the-beacon#77
Delete Branch "burn/20260412-1150-a11y-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?