fix: rate-limit crisis overlay display (#100 )

wip: add crisis overlay rate-limit regression test
2026-04-20 19:39:26 -04:00 · 2026-04-20 19:35:53 -04:00
2 changed files with 118 additions and 50 deletions
--- a/index.html
+++ b/index.html
@@ -613,31 +613,6 @@ html, body {
  top: 8px;
  outline: 2px solid #58a6ff;
 }
-
-/* ===== TOAST NOTIFICATION (fix #73) ===== */
-.toast-notification {
-  position: fixed;
-  bottom: 24px;
-  left: 50%;
-  transform: translateX(-50%) translateY(100px);
-  padding: 12px 24px;
-  border-radius: 8px;
-  font-size: 0.9rem;
-  font-weight: 500;
-  z-index: 10001;
-  opacity: 0;
-  transition: transform 0.3s ease, opacity 0.3s ease;
-  pointer-events: none;
-  max-width: 90vw;
-  text-align: center;
-}
-.toast-notification.visible {
-  transform: translateX(-50%) translateY(0);
-  opacity: 1;
-}
-.toast-notification.success { background: #238636; color: #fff; }
-.toast-notification.error { background: #da3633; color: #fff; }
-
 </style>
 </head>
 <body>
@@ -706,6 +681,7 @@ html, body {
  <!-- Footer -->
  <footer id="footer">
    <a href="/about.html" aria-label="About The Door">about</a>
+    <button id="crisis-resources-btn" aria-label="Open crisis resources">crisis resources</button>
    <button id="safety-plan-btn" aria-label="Open My Safety Plan">my safety plan</button>
    <button id="clear-chat-btn" aria-label="Clear chat history">clear chat</button>
  </footer>
@@ -836,6 +812,7 @@ Sovereignty and service always.`;
  var overlayCallLink = document.querySelector('.overlay-call');
  var statusDot = document.querySelector('.status-dot');
  var statusText = document.getElementById('status-text');
+  var crisisResourcesBtn = document.getElementById('crisis-resources-btn');
  
  // Safety Plan Elements
  var safetyPlanBtn = document.getElementById('safety-plan-btn');
@@ -851,6 +828,9 @@ Sovereignty and service always.`;
  var isStreaming = false;
  var overlayTimer = null;
  var crisisPanelShown = false;
+  var CRISIS_OVERLAY_COOLDOWN_MS = 10 * 60 * 1000;
+  var CRISIS_OVERLAY_LAST_SHOWN_KEY = 'timmy_crisis_overlay_last_shown_at';
+  var CRISIS_OVERLAY_EVENT_LOG_KEY = 'timmy_crisis_overlay_event_log';

  // ===== SERVICE WORKER =====
  if ('serviceWorker' in navigator) {
@@ -878,6 +858,43 @@ Sovereignty and service always.`;
  window.addEventListener('offline', updateOnlineStatus);
  updateOnlineStatus();

+  function getLastOverlayShownAt() {
+    try {
+      return parseInt(localStorage.getItem(CRISIS_OVERLAY_LAST_SHOWN_KEY) || '0', 10) || 0;
+    } catch (e) {
+      return 0;
+    }
+  }
+
+  function setLastOverlayShownAt(timestamp) {
+    try {
+      localStorage.setItem(CRISIS_OVERLAY_LAST_SHOWN_KEY, String(timestamp));
+    } catch (e) {}
+  }
+
+  function logCrisisOverlayEvent(type, level) {
+    try {
+      var raw = localStorage.getItem(CRISIS_OVERLAY_EVENT_LOG_KEY);
+      var events = raw ? JSON.parse(raw) : [];
+      if (!Array.isArray(events)) events = [];
+      events.push({ type: type, level: level, at: Date.now() });
+      if (events.length > 20) events = events.slice(events.length - 20);
+      localStorage.setItem(CRISIS_OVERLAY_EVENT_LOG_KEY, JSON.stringify(events));
+    } catch (e) {}
+  }
+
+  function openCrisisResources() {
+    crisisPanelShown = true;
+    crisisPanel.classList.add('visible');
+    if (typeof crisisPanel.scrollIntoView === 'function') {
+      crisisPanel.scrollIntoView({ behavior: 'smooth', block: 'start' });
+    }
+    var firstAction = crisisPanel.querySelector('.crisis-btn, a[href]');
+    if (firstAction && typeof firstAction.focus === 'function') {
+      firstAction.focus();
+    }
+  }
+
  // ===== CRISIS KEYWORDS =====
  // Tier 1: General crisis indicators - triggers enhanced 988 panel
  var crisisKeywords = [
@@ -1046,6 +1063,19 @@ Sovereignty and service always.`;
  var _preOverlayFocusElement = null;

  function showOverlay() {
+    return showOverlayWithRateLimit(false, 2);
+  }
+
+  function showOverlayWithRateLimit(forceOpen, level) {
+    var lastShownAt = getLastOverlayShownAt();
+    if (!forceOpen && Date.now() - lastShownAt < CRISIS_OVERLAY_COOLDOWN_MS) {
+      logCrisisOverlayEvent('suppressed', level || 2);
+      return false;
+    }
+
+    logCrisisOverlayEvent(forceOpen ? 'manual-open' : 'shown', level || 2);
+    setLastOverlayShownAt(Date.now());
+
    // Save current focus for restoration on dismiss
    _preOverlayFocusElement = document.activeElement;

@@ -1078,6 +1108,7 @@ Sovereignty and service always.`;

    // Focus the Call 988 link (always enabled) — disabled buttons cannot receive focus
    if (overlayCallLink) overlayCallLink.focus();
+    return true;
  }

  // Register focus trap on document (always listening, gated by class check)
@@ -1221,24 +1252,7 @@ Sovereignty and service always.`;
  });

  saveSafetyPlan.addEventListener('click', function() {
-    var 
-  // ===== TOAST NOTIFICATION (fix #73) =====
-  var _toastEl = document.getElementById('toast-notification');
-  var _toastTimer = null;
-
-  function showToast(message, type) {
-    type = type || 'success';
-    _toastEl.textContent = message;
-    _toastEl.className = 'toast-notification ' + type;
-    void _toastEl.offsetHeight; // force reflow before transition
-    _toastEl.classList.add('visible');
-    if (_toastTimer) clearTimeout(_toastTimer);
-    _toastTimer = setTimeout(function() {
-      _toastEl.classList.remove('visible');
-    }, 3000);
-  }
-
-    plan = {
+    var plan = {
      warningSigns: document.getElementById('sp-warning-signs').value,
      coping: document.getElementById('sp-coping').value,
      distraction: document.getElementById('sp-distraction').value,
@@ -1249,9 +1263,9 @@ Sovereignty and service always.`;
      localStorage.setItem('timmy_safety_plan', JSON.stringify(plan));
      safetyPlanModal.classList.remove('active');
      _restoreSafetyPlanFocus();
-      showToast('Safety plan saved.', 'success');
+      alert('Safety plan saved locally.');
    } catch (e) {
-      showToast('Error saving plan.', 'error');
+      alert('Error saving plan.');
    }
  });

@@ -1343,6 +1357,12 @@ Sovereignty and service always.`;
    });
  }

+  if (crisisResourcesBtn) {
+    crisisResourcesBtn.addEventListener('click', function() {
+      openCrisisResources();
+    });
+  }
+
  // ===== TEXTAREA AUTO-RESIZE =====
  msgInput.addEventListener('input', function() {
    this.style.height = 'auto';
@@ -1505,10 +1525,5 @@ Sovereignty and service always.`;

 })();
 </script>
-
-  <!-- Toast notification (fix #73) -->
-  <div id="toast-notification" class="toast-notification"
-       role="status" aria-live="polite" aria-atomic="true"></div>
-
 </body>
 </html>
--- a/tests/test_crisis_overlay_rate_limit.py
+++ b/tests/test_crisis_overlay_rate_limit.py
@@ -0,0 +1,53 @@
+import pathlib
+import re
+import unittest
+
+ROOT = pathlib.Path(__file__).resolve().parents[1]
+INDEX_HTML = ROOT / 'index.html'
+
+
+class TestCrisisOverlayRateLimit(unittest.TestCase):
+    @classmethod
+    def setUpClass(cls):
+        cls.html = INDEX_HTML.read_text()
+
+    def test_overlay_has_ten_minute_cooldown_constant(self):
+        self.assertRegex(
+            self.html,
+            r"CRISIS_OVERLAY_COOLDOWN_MS\s*=\s*10\s*\*\s*60\s*\*\s*1000",
+            'Expected a 10-minute crisis overlay cooldown constant.',
+        )
+
+    def test_show_overlay_suppresses_repeat_with_logging(self):
+        self.assertRegex(
+            self.html,
+            r"function\s+logCrisisOverlayEvent\s*\(",
+            'Expected a crisis overlay event logger.',
+        )
+        self.assertRegex(
+            self.html,
+            r"if\s*\(!forceOpen\s*&&\s*Date\.now\(\)\s*-\s*lastShownAt\s*<\s*CRISIS_OVERLAY_COOLDOWN_MS\)",
+            'Expected showOverlay to suppress repeated auto-displays inside the cooldown window.',
+        )
+        self.assertRegex(
+            self.html,
+            r"logCrisisOverlayEvent\('suppressed'",
+            'Expected suppressed overlay attempts to be logged.',
+        )
+
+    def test_manual_crisis_resources_button_exists_and_bypasses_cooldown(self):
+        self.assertIn('id="crisis-resources-btn"', self.html)
+        self.assertRegex(
+            self.html,
+            r"function\s+openCrisisResources\s*\(",
+            'Expected a manual crisis resources opener.',
+        )
+        self.assertRegex(
+            self.html,
+            r"crisisResourcesBtn\.addEventListener\('click',\s*function\(\)\s*\{\s*openCrisisResources\(\);",
+            'Expected the footer button to wire into openCrisisResources().',
+        )
+
+
+if __name__ == '__main__':
+    unittest.main()
Author	SHA1	Message	Date
Alexander Whitestone	e132fc134b	fix: rate-limit crisis overlay display (#100 ) All checks were successful Sanity Checks / sanity-test (pull_request) Successful in 5s Details Smoke Test / smoke (pull_request) Successful in 6s Details	2026-04-20 19:39:26 -04:00
Alexander Whitestone	8b658e76f3	wip: add crisis overlay rate-limit regression test	2026-04-20 19:35:53 -04:00