Timmy_Foundation/the-door
15
0
Fork 0
Code Issues 19 Pull Requests 18 Actions Packages Projects Releases Wiki Activity

fix: crisis overlay initial focus to enabled Call 988 link (#69) #126

Closed
Rockachopa wants to merge 0 commits from burn/69-1776264183 into main
pull from: burn/69-1776264183
merge into: Timmy_Foundation:main
Conversation 2 Commits - Files Changed - +31 -1
Rockachopa commented 2026-04-15 15:10:04 +00:00
Owner
Copy Link

Closes #69

Problem

showOverlay() disabled the dismiss button for the 10-second countdown, then immediately called overlayDismissBtn.focus(). Disabled buttons cannot receive focus, so keyboard and assistive-technology users had no reliable initial focus target when the crisis overlay opened.

Changes

  • Added overlayCallLink variable referencing the .overlay-call element
  • showOverlay() now focuses the Call 988 link (always enabled) instead of the disabled dismiss button
  • Regression test verifies initial focus targets the enabled call link
  • Regression test verifies the .overlay-call JS variable is declared

Acceptance Criteria

  • Overlay sets initial focus to an enabled control (Call 988 link)
  • Regression test covers initial focus target on overlay open

Tests

All 28 tests pass (5 focus-trap tests, including 2 new ones).

Closes #69 ## Problem `showOverlay()` disabled the dismiss button for the 10-second countdown, then immediately called `overlayDismissBtn.focus()`. Disabled buttons cannot receive focus, so keyboard and assistive-technology users had no reliable initial focus target when the crisis overlay opened. ## Changes - Added `overlayCallLink` variable referencing the `.overlay-call` element - `showOverlay()` now focuses the Call 988 link (always enabled) instead of the disabled dismiss button - Regression test verifies initial focus targets the enabled call link - Regression test verifies the `.overlay-call` JS variable is declared ## Acceptance Criteria - [x] Overlay sets initial focus to an enabled control (Call 988 link) - [x] Regression test covers initial focus target on overlay open ## Tests All 28 tests pass (5 focus-trap tests, including 2 new ones).
Rockachopa added 2 commits 2026-04-15 15:10:05 +00:00
fix: crisis overlay initial focus to enabled Call 988 link (#69) c22bbbaf65
fix: crisis overlay initial focus to enabled Call 988 link (#69)
All checks were successful
Sanity Checks / sanity-test (pull_request) Successful in 9s
Details
Smoke Test / smoke (pull_request) Successful in 15s
Details
07b3f67845
Timmy approved these changes 2026-04-15 16:16:18 +00:00
Timmy left a comment
Owner
Copy Link

Review: fix: crisis overlay initial focus to enabled Call 988 link

Correct fix — focuses the always-enabled Call 988 link instead of the disabled dismiss button, which cannot receive focus. The test additions verify the new behavior and regression-guard against the old pattern.

One minor note: this overlaps with PRs #116 and #84 which fix the same issue (#69). Consider closing the duplicates.

Approved.

**Review: fix: crisis overlay initial focus to enabled Call 988 link** Correct fix — focuses the always-enabled Call 988 link instead of the disabled dismiss button, which cannot receive focus. The test additions verify the new behavior and regression-guard against the old pattern. One minor note: this overlaps with PRs #116 and #84 which fix the same issue (#69). Consider closing the duplicates. Approved.
Timmy closed this pull request 2026-04-17 01:52:39 +00:00
Timmy commented 2026-04-17 01:52:40 +00:00
Owner
Copy Link

Archived — branch unknown preserved for reference. Cherry-pick if still relevant.

Archived — branch `unknown` preserved for reference. Cherry-pick if still relevant.
All checks were successful
Sanity Checks / sanity-test (pull_request) Successful in 9s
Details
Smoke Test / smoke (pull_request) Successful in 15s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Timmy
Labels
Clear labels
backend
Backend / API
 batch-pipeline
batch-pipeline label
 content
Content, copy, testimony
 deploy
Deployment / go-live
 epic
Epic / parent issue
 frontend
Frontend / UI
 hardening
Resilience, fallback, security
 infra
Infrastructure, DevOps, deployment
 priority:critical
Must have for launch
 priority:high
Important for launch
 priority:medium
Nice to have at launch
 protocol
Crisis detection protocol
 throughput-10x
throughput-10x label
 token-masterplan
token-masterplan label
 velocity-engine
Auto-generated by velocity engine
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude codex-agent ezra gemini google grok hermes kimi manus perplexity sonnet
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/the-door#126
Delete Branch "burn/69-1776264183"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?