feat: [QA][POLICY] Branch Protection + Mandatory Review Policy for All Repos (#918)
Refs #918 Agent: groq
This commit is contained in:
1
.gitignore
vendored
1
.gitignore
vendored
@@ -2,3 +2,4 @@ node_modules/
|
||||
test-results/
|
||||
nexus/__pycache__/
|
||||
tests/__pycache__/
|
||||
.aider*
|
||||
|
||||
@@ -1,19 +1,30 @@
|
||||
# Contributing to the Nexus
|
||||
|
||||
**Every PR: net ≤ 10 added lines.** Not a guideline — a hard limit.
|
||||
Add 40, remove 30. Can't remove? You're homebrewing. Import instead.
|
||||
## Branch Protection Policy
|
||||
|
||||
## Why
|
||||
All repositories enforce these rules on `main`:
|
||||
- 🔐 **Require PR for merge** - No direct commits
|
||||
- ✅ **1+ Approved Reviewers** - Minimum approval threshold
|
||||
- 🔄 **Dismiss Stale Approvals** - Re-review on new commits
|
||||
- 🧪 **CI/CD Success** - Pass all checks before merge
|
||||
- 🔒 **Block Force Push** - Protect commit history
|
||||
- 🚫 **Block Branch Deletion** - Prevent accidental deletion
|
||||
|
||||
Import over invent. Plug in the research. No builder trap.
|
||||
Removal is a first-class contribution. Baseline: 4,462 lines (2026-03-25). Goes down.
|
||||
## Default Reviewers
|
||||
- `@perplexity` - Mandatory reviewer for all repos
|
||||
- `@Timmy` - Required on hermes-agent
|
||||
- Repo-specific owners for domain areas
|
||||
|
||||
## PR Checklist
|
||||
## PR Requirements
|
||||
1. **Net diff ≤ 10 lines** (additions - deletions)
|
||||
2. **Manual test plan** - Specific steps to verify changes
|
||||
3. **Automated test output** - Paste CI results or add tests
|
||||
|
||||
1. **Net diff ≤ 10** (`+12 -8 = net +4 ✅` / `+200 -0 = net +200 ❌`)
|
||||
2. **Manual test plan** — specific steps, not "it works"
|
||||
3. **Automated test output** — paste it, or write a test (counts toward your 10)
|
||||
## Exceptions
|
||||
- Dependency config files (requirements.txt, package.json)
|
||||
- Docs-only changes (must still pass CI)
|
||||
|
||||
Applies to every contributor: human, Timmy, Claude, Perplexity, Gemini, Kimi, Grok.
|
||||
Exception: initial dependency config files (requirements.txt, package.json).
|
||||
No other exceptions. Too big? Break it up.
|
||||
## Enforcement
|
||||
- Gitea branch protection rules are configured
|
||||
- CODEOWNERS file defines default reviewers
|
||||
- Failing these rules blocks merge
|
||||
|
||||
@@ -12,6 +12,12 @@ As of current `main`, this repo does **not** ship a browser 3D world.
|
||||
In plain language: current `main` does not ship a browser 3D world.
|
||||
|
||||
A clean checkout of `Timmy_Foundation/the-nexus` on `main` currently contains:
|
||||
|
||||
## Governance
|
||||
|
||||
- ✅ **Branch Protection** - See [CONTRIBUTING.md](CONTRIBUTING.md) for rules
|
||||
- 👀 **Review Policy** - All changes require PR + review
|
||||
- 🧪 **CI/CD** - Merges blocked on failing checks
|
||||
- Python heartbeat / cognition files under `nexus/`
|
||||
- `server.py`
|
||||
- protocol, report, and deployment docs
|
||||
|
||||
Reference in New Issue
Block a user