Compare commits

...

1 Commits

Author SHA1 Message Date
Alexander Whitestone
3fbcdd606a docs: verify #1413 already implemented
Some checks failed
CI / validate (pull_request) Failing after 1m24s
Review Approval Gate / verify-review (pull_request) Successful in 11s
CI / test (pull_request) Failing after 2m11s
2026-04-15 01:11:38 -04:00
2 changed files with 56 additions and 0 deletions

View File

@@ -0,0 +1,31 @@
# Issue #1413 Verification
Status: already implemented on `main`
## Acceptance criteria check
1.`deploy.sh` comment for `nexus-main` uses port `8765`
- Evidence: `deploy.sh:3`
2.`deploy.sh` comment for `nexus-staging` uses port `8766`
- Evidence: `deploy.sh:4`
3.`docker-compose.yml` confirms those bindings
- Evidence: `docker-compose.yml:9` is `"8765:8765"`
- Evidence: `docker-compose.yml:15` is `"8766:8765"`
## Why no code fix was needed
The issue describes stale comments (`4200` / `4201`), but the current `main` branch already contains the corrected comments:
```text
# Usage: ./deploy.sh — rebuild and restart nexus-main (port 8765)
# ./deploy.sh staging — rebuild and restart nexus-staging (port 8766)
```
## Value added in this PR
- adds `tests/test_deploy_script_ports.py` so future drift between `deploy.sh` comments and `docker-compose.yml` is caught automatically
- documents the verification outcome here so the issue can be closed without reimplementing an already-merged fix
## Recommendation
Close issue #1413 as already implemented.

View File

@@ -0,0 +1,25 @@
from pathlib import Path
NEXUS_ROOT = Path(__file__).resolve().parent.parent
def test_deploy_sh_header_comments_match_live_ports():
deploy_sh = (NEXUS_ROOT / "deploy.sh").read_text()
assert "(port 8765)" in deploy_sh, "deploy.sh should document nexus-main on port 8765"
assert "(port 8766)" in deploy_sh, "deploy.sh should document nexus-staging on port 8766"
assert "4200" not in deploy_sh, "stale 4200 comment should not remain in deploy.sh"
assert "4201" not in deploy_sh, "stale 4201 comment should not remain in deploy.sh"
def test_deploy_sh_comments_match_docker_compose_bindings():
deploy_sh = (NEXUS_ROOT / "deploy.sh").read_text().splitlines()
compose = (NEXUS_ROOT / "docker-compose.yml").read_text()
main_comment = next(line for line in deploy_sh if "nexus-main" in line and "port" in line)
staging_comment = next(line for line in deploy_sh if "nexus-staging" in line and "port" in line)
assert '"8765:8765"' in compose, "docker-compose should expose nexus-main on 8765"
assert '"8766:8765"' in compose, "docker-compose should expose nexus-staging via host port 8766"
assert "8765" in main_comment, "nexus-main deploy comment should cite 8765"
assert "8766" in staging_comment, "nexus-staging deploy comment should cite 8766"