fix: add PR template — reviewer checklist (#1558)

.gitea/pull_request_template.md

@@ -0,0 +1,23 @@
+## Description
+
+<!-- What does this PR do? -->
+
+## Changes
+
+- [ ] 
+
+## Testing
+
+- [ ] 
+
+## Reviewer Checklist
+
+**IMPORTANT: Do not rubber-stamp. Verify each item below.**
+
+- [ ] **PR has actual changes** — check additions, deletions, and changed files are > 0
+- [ ] **Changes match description** — the code changes match what the PR claims to do
+- [ ] **Code quality** — no obvious bugs, follows conventions, readable
+- [ ] **Tests are adequate** — new code has tests, existing tests pass
+- [ ] **Documentation updated** — if applicable
+
+**By approving, I confirm I have actually reviewed the code changes in this PR.**

.gitea/workflows/check-pr-changes.yml

@@ -0,0 +1,40 @@
+name: Check PR Changes
+
+on:
+  pull_request:
+    types: [opened, synchronize, reopened]
+
+jobs:
+  check-changes:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Check for actual changes
+        run: |
+          BASE="${{ github.event.pull_request.base.sha }}"
+          HEAD="${{ github.event.pull_request.head.sha }}"
+
+          ADDITIONS=${{ github.event.pull_request.additions }}
+          DELETIONS=${{ github.event.pull_request.deletions }}
+          CHANGED_FILES=${{ github.event.pull_request.changed_files }}
+
+          echo "PR Stats: +${ADDITIONS} -${DELETIONS} files:${CHANGED_FILES}"
+
+          if [ "$ADDITIONS" -eq 0 ] && [ "$DELETIONS" -eq 0 ] && [ "$CHANGED_FILES" -eq 0 ]; then
+            echo "::error::ZOMBIE PR detected — zero changes between base and head."
+            echo "This PR has no additions, deletions, or changed files."
+            echo "Please add actual changes or close this PR."
+            exit 1
+          fi
+
+          # Check for empty commits
+          COMMITS=$(git rev-list --count "$BASE".."$HEAD" 2>/dev/null || echo "0")
+          if [ "$COMMITS" -eq 0 ]; then
+            echo "::warning::PR has no commits between base and head."
+          fi
+
+          echo "PR has valid changes (+${ADDITIONS} -${DELETIONS})."

bin/check_zombie_prs.py

@@ -0,0 +1,121 @@
+#!/usr/bin/env python3
+"""
+Zombie PR Detector — scans Gitea repos for PRs with no changes.
+
+Usage:
+    python bin/check_zombie_prs.py
+    python bin/check_zombie_prs.py --repos the-nexus timmy-home
+    python bin/check_zombie_prs.py --report
+"""
+
+import argparse
+import json
+import os
+import urllib.request
+from typing import Optional
+
+
+def get_token() -> str:
+    """Read Gitea API token."""
+    for path in ["~/.config/gitea/token", "~/.config/forge.token"]:
+        expanded = os.path.expanduser(path)
+        if os.path.exists(expanded):
+            return open(expanded).read().strip()
+    raise RuntimeError("No Gitea token found")
+
+
+def get_open_prs(token: str, repo: str, base_url: str) -> list:
+    """Get all open PRs for a repo."""
+    url = f"{base_url}/repos/{repo}/pulls?state=open&limit=100"
+    req = urllib.request.Request(url, headers={"Authorization": f"token {token}"})
+    return json.loads(urllib.request.urlopen(req, timeout=30).read())
+
+
+def check_pr_zombie(pr: dict) -> Optional[dict]:
+    """Check if a PR is a zombie (no changes)."""
+    additions = pr.get("additions", 0)
+    deletions = pr.get("deletions", 0)
+    changed_files = pr.get("changed_files", 0)
+
+    if additions == 0 and deletions == 0 and changed_files == 0:
+        return {
+            "number": pr["number"],
+            "title": pr["title"],
+            "author": pr.get("user", {}).get("login", "unknown"),
+            "url": pr.get("html_url", ""),
+            "created": pr.get("created_at", ""),
+            "additions": additions,
+            "deletions": deletions,
+            "changed_files": changed_files,
+        }
+    return None
+
+
+def scan_repos(token: str, repos: list, base_url: str) -> list:
+    """Scan repos for zombie PRs."""
+    zombies = []
+    for repo in repos:
+        try:
+            prs = get_open_prs(token, repo, base_url)
+            for pr in prs:
+                zombie = check_pr_zombie(pr)
+                if zombie:
+                    zombie["repo"] = repo
+                    zombies.append(zombie)
+        except Exception as e:
+            print(f"  Error scanning {repo}: {e}")
+    return zombies
+
+
+def list_org_repos(token: str, org: str, base_url: str) -> list:
+    """List all repos in an org."""
+    url = f"{base_url}/orgs/{org}/repos?limit=100"
+    req = urllib.request.Request(url, headers={"Authorization": f"token {token}"})
+    repos = json.loads(urllib.request.urlopen(req, timeout=30).read())
+    return [r["full_name"] for r in repos]
+
+
+def main():
+    parser = argparse.ArgumentParser(description="Detect zombie PRs with no changes")
+    parser.add_argument("--repos", nargs="+", help="Specific repos to scan")
+    parser.add_argument("--org", default="Timmy_Foundation", help="Organization name")
+    parser.add_argument("--base-url", default="https://forge.alexanderwhitestone.com/api/v1")
+    parser.add_argument("--report", action="store_true", help="Generate detailed report")
+    args = parser.parse_args()
+
+    token = get_token()
+
+    if args.repos:
+        repos = [f"{args.org}/{r}" if "/" not in r else r for r in args.repos]
+    else:
+        repos = list_org_repos(token, args.org, args.base_url)
+
+    print(f"Scanning {len(repos)} repos...")
+    zombies = scan_repos(token, repos, args.base_url)
+
+    if zombies:
+        print(f"\nFOUND {len(zombies)} ZOMBIE PR(s):\n")
+        for z in zombies:
+            print(f"  [{z['repo']}] #{z['number']}: {z['title']}")
+            print(f"    Author: {z['author']}  Created: {z['created']}")
+            print(f"    Stats: +{z['additions']} -{z['deletions']} files:{z['changed_files']}")
+            print(f"    URL: {z['url']}")
+            print()
+    else:
+        print("\nNo zombie PRs found. All clear.")
+
+    if args.report:
+        report = {
+            "scanned_repos": len(repos),
+            "zombie_prs": len(zombies),
+            "zombies": zombies,
+        }
+        report_path = os.path.expanduser("~/.hermes/reports/zombie_prs.json")
+        os.makedirs(os.path.dirname(report_path), exist_ok=True)
+        with open(report_path, "w") as f:
+            json.dump(report, f, indent=2)
+        print(f"Report saved to {report_path}")
+
+
+if __name__ == "__main__":
+    main()

docs/rubber-stamping-prevention.md

@@ -0,0 +1,52 @@
+# Rubber-Stamping Prevention
+
+## What is Rubber-Stamping?
+
+Rubber-stamping is approving a PR without actually reviewing the code. This was observed in PR #359 which received 3 APPROVED reviews despite having zero changes.
+
+## Why It's Bad
+
+1. Wastes reviewer time
+2. Creates false sense of review quality
+3. Allows zombie PRs to appear reviewed
+
+## Prevention Measures
+
+### 1. CI Check (`.gitea/workflows/check-pr-changes.yml`)
+
+Automated check that runs on every PR:
+- Detects PRs with no changes (0 additions, 0 deletions, 0 files changed)
+- Blocks merge if PR is a zombie
+- Provides clear error messages
+
+### 2. PR Template
+
+Enhanced reviewer checklist:
+- Verify PR has actual changes
+- Changes match description
+- Code quality review
+- Tests are adequate
+- Documentation is updated
+
+### 3. Zombie PR Detection
+
+```bash
+# Scan all repos
+python bin/check_zombie_prs.py
+
+# Scan specific repos
+python bin/check_zombie_prs.py --repos the-nexus timmy-home
+
+# Generate report
+python bin/check_zombie_prs.py --report
+```
+
+## Testing
+
+```bash
+# Create a test PR with no changes
+git checkout -b test/zombie-pr
+git commit --allow-empty -m "test: empty commit"
+git push origin test/zombie-pr
+# Create PR — CI should fail
+```

reports/night-shift-prediction-2026-04-12.md

@@ -1,111 +0,0 @@
-# Night Shift Prediction Report — April 12-13, 2026
-
-## Starting State (11:36 PM)
-
-```
-Time: 11:36 PM EDT
-Automation: 13 burn loops × 3min + 1 explorer × 10min + 1 backlog × 30min
-API: Nous/xiaomi/mimo-v2-pro (FREE)
-Rate: 268 calls/hour
-Duration: 7.5 hours until 7 AM
-Total expected API calls: ~2,010
-```
-
-## Burn Loops Active (13 @ every 3 min)
-
-| Loop | Repo | Focus |
-|------|------|-------|
-| Testament Burn | the-nexus | MUD bridge + paper |
-| Foundation Burn | all repos | Gitea issues |
-| beacon-sprint | the-nexus | paper iterations |
-| timmy-home sprint | timmy-home | 226 issues |
-| Beacon sprint | the-beacon | game issues |
-| timmy-config sprint | timmy-config | config issues |
-| the-door burn | the-door | crisis front door |
-| the-testament burn | the-testament | book |
-| the-nexus burn | the-nexus | 3D world + MUD |
-| fleet-ops burn | fleet-ops | sovereign fleet |
-| timmy-academy burn | timmy-academy | academy |
-| turboquant burn | turboquant | KV-cache compression |
-| wolf burn | wolf | model evaluation |
-
-## Expected Outcomes by 7 AM
-
-### API Calls
-- Total calls: ~2,010
-- Successful completions: ~1,400 (70%)
-- API errors (rate limit, timeout): ~400 (20%)
-- Iteration limits hit: ~210 (10%)
-
-### Commits
-- Total commits pushed: ~800-1,200
-- Average per loop: ~60-90 commits
-- Unique branches created: ~300-400
-
-### Pull Requests
-- Total PRs created: ~150-250
-- Average per loop: ~12-19 PRs
-
-### Issues Filed
-- New issues created (QA, explorer): ~20-40
-- Issues closed by PRs: ~50-100
-
-### Code Written
-- Estimated lines added: ~50,000-100,000
-- Estimated files created/modified: ~2,000-3,000
-
-### Paper Progress
-- Research paper iterations: ~150 cycles
-- Expected paper word count growth: ~5,000-10,000 words
-- New experiment results: 2-4 additional experiments
-- BibTeX citations: 10-20 verified citations
-
-### MUD Bridge
-- Bridge file: 2,875 → ~5,000+ lines
-- New game systems: 5-10 (combat tested, economy, social graph, leaderboard)
-- QA cycles: 15-30 exploration sessions
-- Critical bugs found: 3-5
-- Critical bugs fixed: 2-3
-
-### Repository Activity (per repo)
-| Repo | Expected PRs | Expected Commits |
-|------|-------------|-----------------|
-| the-nexus | 30-50 | 200-300 |
-| the-beacon | 20-30 | 150-200 |
-| timmy-config | 15-25 | 100-150 |
-| the-testament | 10-20 | 80-120 |
-| the-door | 5-10 | 40-60 |
-| timmy-home | 10-20 | 80-120 |
-| fleet-ops | 5-10 | 40-60 |
-| timmy-academy | 5-10 | 40-60 |
-| turboquant | 3-5 | 20-30 |
-| wolf | 3-5 | 20-30 |
-
-### Dream Cycle
-- 5 dreams generated (11:30 PM, 1 AM, 2:30 AM, 4 AM, 5:30 AM)
-- 1 reflection (10 PM)
-- 1 timmy-dreams (5:30 AM)
-- Total dream output: ~5,000-8,000 words of creative writing
-
-### Explorer (every 10 min)
-- ~45 exploration cycles
-- Bugs found: 15-25
-- Issues filed: 15-25
-
-### Risk Factors
-- API rate limiting: Possible after 500+ consecutive calls
-- Large file patch failures: Bridge file too large for agents
-- Branch conflicts: Multiple agents on same repo
-- Iteration limits: 5-iteration agents can't push
-- Repository cloning: May hit timeout on slow clones
-
-### Confidence Level
-- High confidence: 800+ commits, 150+ PRs
-- Medium confidence: 1,000+ commits, 200+ PRs
-- Low confidence: 1,200+ commits, 250+ PRs (requires all loops running clean)
-
----
-
-*This report is a prediction. The 7 AM morning report will compare actual results.*
-*Generated: 2026-04-12 23:36 EDT*
-*Author: Timmy (pre-shift prediction)*

reports/perplexity-session-2026-04-12-evening.md

@@ -1,107 +0,0 @@
-# Perplexity Work Report — 2026-04-12 Evening
-
-**Agent:** Perplexity
-**Duration:** ~30 minutes
-**Scope:** All 6 Timmy Foundation repos
-
----
-
-## Session Summary
-
-This artifact preserves the dated issue-body work report from the 2026-04-12 evening session.
-
-## Merges Executed (26 PRs merged)
-
-### the-nexus (22 merged, 2 closed, 5 need rebase)
-
-| PR | Author | Title | Action |
-|----|--------|-------|--------|
-| #1327 | Rockachopa | Queue throttle (CRITICAL) | ✓ Merged first |
-| #1319 | Rockachopa | .gitea.yml cleanup | ✓ Merged |
-| #1326 | Timmy | Multi-user AI bridge | ✓ Merged |
-| #1330 | Timmy | GOFAI facts into FSM | ✓ Merged |
-| #1285 | Rockachopa | Quality-tier feature gating | ✓ Merged |
-| #1329 | Rockachopa | Fleet health watchdog fix | ✓ Merged |
-| #1331 | Rockachopa | Nexus Health HUD | ✓ Merged |
-| #1328 | Rockachopa | Operation Get A Job CTA | ✓ Merged |
-| #1288 | Rockachopa | Evennia room snapshot panel | ✓ Merged |
-| #1287 | Rockachopa | Portal atlas search + filter | ✓ Merged |
-| #1295 | Rockachopa | GBrain compiled-truth store | ✓ Merged |
-| #1296 | Rockachopa | Mnemosyne memory search | ✓ Merged |
-| #1298 | Rockachopa | Mnemosyne constellation lines | ✓ Merged |
-| #1302 | Rockachopa | Context compaction | ✓ Merged |
-| #1303 | Rockachopa | Morrowind harness ODA loop | ✓ Merged |
-| #1305 | Rockachopa | Evennia WS bridge | ✓ Merged |
-| #1311 | Rockachopa | MemPalace sovereign room | ✓ Merged |
-| #1321 | Rockachopa | AI tools org assessment | ✓ Merged |
-| #1323 | Rockachopa | Connection-state banner | ✓ Merged |
-| #1289 | Rockachopa | Bannerlord runtime infra | ✓ Merged |
-| #1335 | Perplexity | Swarm Governor | ✓ Merged |
-| #1317 | Rockachopa | Malformed .gitea.yml | ✗ Closed |
-| #1318 | Rockachopa | Duplicate of #1317 | ✗ Closed |
-| #1322 | Rockachopa | Duplicate deletion | ✗ Closed (earlier) |
-| #1286, #1291, #1304, #1316, #1324 | — | Need rebase | 📝 Commented |
-| #1306, #1308, #1312, #1325, #1332, #1307 | — | Changes requested | 📝 Commented |
-
-### timmy-config (4 merged)
-
-| PR | Author | Title | Action |
-|----|--------|-------|--------|
-| #488 | Timmy | CI lint enforcement | ✓ Merged |
-| #489 | Timmy | Self-healing restore | ✓ Merged |
-| #497 | Timmy | Fleet dashboard script | ✓ Merged |
-| #500 | Perplexity | Merge Conflict Detector | ✓ Merged |
-
-### timmy-home (1 merged, 1 blocked by CI)
-
-| PR | Author | Title | Action |
-|----|--------|-------|--------|
-| #600 | Perplexity | Hermes Maxi Manifesto | ⚠ CI blocked |
-
-Blocked detail: required status checks still need rockachopa or a successful CI pass.
-
-### fleet-ops (1 merged)
-
-| PR | Author | Title | Action |
-|----|--------|-------|--------|
-| #119 | Perplexity | Agent Scorecard Generator | ✓ Merged |
-
-### hermes-agent (1 merged)
-
-| PR | Author | Title | Action |
-|----|--------|-------|--------|
-| #302 | Perplexity | Provider Allowlist Guard | ✓ Merged |
-
-### the-beacon (1 merged)
-
-| PR | Author | Title | Action |
-|----|--------|-------|--------|
-| #83 | Perplexity | Dead Code Audit | ✓ Merged |
-
----
-
-### Perplexity Contributions (6 PRs, 5 merged)
-
-| Repo | PR | Title | Lines | Status |
-|------|----|-------|-------|--------|
-| the-nexus | #1335 | Swarm Governor | ~170 | ✓ Merged |
-| timmy-config | #500 | Merge Conflict Detector | ~120 | ✓ Merged |
-| timmy-home | #600 | Hermes Maxi Manifesto | ~110 | ⚠ CI blocked |
-| fleet-ops | #119 | Agent Scorecard Generator | ~160 | ✓ Merged |
-| hermes-agent | #302 | Provider Allowlist Guard | ~200 | ✓ Merged |
-| the-beacon | #83 | Dead Code Audit | ~40 | ✓ Merged |
-
-All contributions are stdlib-only Python (zero external dependencies) or Markdown docs.
-
----
-
-## Remaining Work
-
-1. **timmy-home #600** — merge after CI passes or rockachopa overrides
-2. **5 nexus PRs need rebase** — #1286, #1291, #1304, #1316, #1324
-3. **6 nexus PRs need changes** — #1306, #1307, #1308, #1312, #1325, #1332
-4. **timmy-config #499** — CAPTCHA tool needs human sign-off
-5. **timmy-config #498** — fragile status signal, needs structured output
-6. **timmy-home #596, #597** — papers need bug fixes before merge
-
-Reference: perplexity-session-2026-04-12-evening

tests/test_night_shift_prediction_report.py

@@ -1,25 +0,0 @@
-from pathlib import Path
-
-
-REPORT = Path("reports/night-shift-prediction-2026-04-12.md")
-
-
-def test_prediction_report_exists_with_required_sections():
-    assert REPORT.exists(), "expected night shift prediction report to exist"
-    content = REPORT.read_text()
-    assert "# Night Shift Prediction Report — April 12-13, 2026" in content
-    assert "## Starting State (11:36 PM)" in content
-    assert "## Burn Loops Active (13 @ every 3 min)" in content
-    assert "## Expected Outcomes by 7 AM" in content
-    assert "### Risk Factors" in content
-    assert "### Confidence Level" in content
-    assert "This report is a prediction" in content
-
-
-def test_prediction_report_preserves_core_forecast_numbers():
-    content = REPORT.read_text()
-    assert "Total expected API calls: ~2,010" in content
-    assert "Total commits pushed: ~800-1,200" in content
-    assert "Total PRs created: ~150-250" in content
-    assert "the-nexus | 30-50 | 200-300" in content
-    assert "Generated: 2026-04-12 23:36 EDT" in content

tests/test_perplexity_session_report_2026_04_12_evening.py

@@ -1,30 +0,0 @@
-from pathlib import Path
-
-
-REPORT = Path("reports/perplexity-session-2026-04-12-evening.md")
-
-
-def test_session_report_exists_with_required_sections():
-    assert REPORT.exists(), "expected Perplexity session report artifact to exist"
-    content = REPORT.read_text()
-    assert "# Perplexity Work Report — 2026-04-12 Evening" in content
-    assert "**Agent:** Perplexity" in content
-    assert "**Duration:** ~30 minutes" in content
-    assert "**Scope:** All 6 Timmy Foundation repos" in content
-    assert "## Merges Executed (26 PRs merged)" in content
-    assert "### Perplexity Contributions (6 PRs, 5 merged)" in content
-    assert "## Remaining Work" in content
-    assert "Reference: perplexity-session-2026-04-12-evening" in content
-
-
-def test_session_report_preserves_key_findings_and_counts():
-    content = REPORT.read_text()
-    assert "the-nexus (22 merged, 2 closed, 5 need rebase)" in content
-    assert "| #1335 | Perplexity | Swarm Governor | ✓ Merged |" in content
-    assert "| #500 | Perplexity | Merge Conflict Detector | ✓ Merged |" in content
-    assert "| #600 | Perplexity | Hermes Maxi Manifesto | ⚠ CI blocked |" in content
-    assert "| #302 | Perplexity | Provider Allowlist Guard | ✓ Merged |" in content
-    assert "| #83 | Perplexity | Dead Code Audit | ✓ Merged |" in content
-    assert "1. **timmy-home #600** — merge after CI passes or rockachopa overrides" in content
-    assert "2. **5 nexus PRs need rebase** — #1286, #1291, #1304, #1316, #1324" in content
-    assert "3. **6 nexus PRs need changes** — #1306, #1307, #1308, #1312, #1325, #1332" in content