Compare commits
1 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
c6a34db91d |
74
reviews/2026-04-12-forge-wide-qa-pass.md
Normal file
74
reviews/2026-04-12-forge-wide-qa-pass.md
Normal file
@@ -0,0 +1,74 @@
|
||||
# Forge-Wide QA Pass — 2026-04-12 Evening
|
||||
|
||||
**Reviewer:** Perplexity
|
||||
**Scope:** All 6 Timmy Foundation repos
|
||||
**Source:** Issue #1333 on `Timmy_Foundation/the-nexus`
|
||||
**Reference:** `perplexity-status-report-2026-04-12-evening`
|
||||
|
||||
---
|
||||
|
||||
## Summary
|
||||
|
||||
| Repo | Open PRs | Reviewed | Approved | Changes Requested | Closed |
|
||||
|------|----------|----------|----------|-------------------|--------|
|
||||
| the-nexus | 33 → 32 | 10 | 8 | 1 | 1 |
|
||||
| timmy-config | 5 | 5 | 3 | 2 | 0 |
|
||||
| timmy-home | 2 | 2 | 0 | 2 | 0 |
|
||||
| fleet-ops | 0 | — | — | — | — |
|
||||
| hermes-agent | 0 | — | — | — | — |
|
||||
| the-beacon | 0 | 1 post-merge flag | — | — | — |
|
||||
|
||||
**Total: 40 open PRs across the org. 17 reviewed this pass.**
|
||||
|
||||
---
|
||||
|
||||
## Critical Findings
|
||||
|
||||
### 1. the-nexus swarm pileup (again)
|
||||
33 open PRs, 31 from Rockachopa via mimo-v2-pro swarm. These are NOT empty/stale like the April 11 event — they contain real diffs. However:
|
||||
- **Triple duplicate:** PRs #1319, #1322, #1328 all delete `CONTRIBUTORING.md`. Closed #1322 as duplicate.
|
||||
- **4 sibling `app.js` PRs** (#1285, #1307, #1330, #1331) branch from the same commit. Merge sequentially or they'll conflict.
|
||||
- **Queue throttle not deployed yet:** PR #1327 adds `MAX_QUEUE_DEPTH=10` to the dispatcher — the fix for this exact problem. **Merge #1327 first and restart the dispatcher.**
|
||||
|
||||
### 2. CAPTCHA bypass tool in timmy-config #499
|
||||
The multimodal toolsuite PR includes a `captcha_solver.py`. This needs explicit human sign-off — it's a policy decision, not a code decision. Requested changes.
|
||||
|
||||
### 3. the-beacon Gemini bloat
|
||||
PR #76 (merged) added +3,258 lines for two small fixes. Gemini likely rewrote large portions of `game.js`. Also: `game/npc-logic.js` and `scripts/guardrails.js` may be dead code (runtime lives in `js/`). Flagged for audit.
|
||||
|
||||
### 4. Paper PRs need polish (timmy-home)
|
||||
Both papers (#596 Poka-Yoke, #597 Sovereign Fleet) are real work but have specific bugs:
|
||||
- #596: path injection security bug + broken citation
|
||||
- #597: real IPs in public-facing tables + wrong LaTeX style
|
||||
|
||||
---
|
||||
|
||||
## Recommended Merge Order (the-nexus)
|
||||
|
||||
1. **#1327** — Queue throttle (stops the pileup)
|
||||
2. **#1319** — .gitea.yml cleanup
|
||||
3. **#1326** — Multi-user bridge (Timmy, strong)
|
||||
4. **#1330** — GOFAI facts (Timmy, clean)
|
||||
5. **#1285** — Performance gating
|
||||
6. **#1329** — Watchdog fix
|
||||
7. **#1331** — Health HUD
|
||||
8. **#1328** — Portfolio CTA (rebase after #1319)
|
||||
9. Remaining 23 Rockachopa PRs need individual review
|
||||
|
||||
## What's Working Well
|
||||
|
||||
- **Timmy's PR quality is excellent.** Both #1330 and #1326 are targeted, complete, well-structured.
|
||||
- **hermes-agent is clean.** PR #300 (malformed JSON repair, +1 line, saves ~1,400 inference turns) is the best ROI change in the org.
|
||||
- **fleet-ops GOFIA series** (#80, #81, #82) landed with strong test coverage.
|
||||
- **the-beacon** shipped 9 PRs with real game features (emotional arcs, procedural sound, golden ratio economics).
|
||||
|
||||
## What Needs Attention
|
||||
|
||||
- Deploy the queue throttle (#1327) before the next swarm cycle
|
||||
- Audit `the-beacon/game.js` for Gemini-introduced regressions
|
||||
- The remaining 23 unreviewed nexus PRs — continue reviewing if desired
|
||||
- Branch protection still not enabled (waiting on rockachopa per #1253/#1255)
|
||||
|
||||
---
|
||||
|
||||
Reference: perplexity-status-report-2026-04-12-evening
|
||||
29
tests/test_forge_wide_qa_pass_report.py
Normal file
29
tests/test_forge_wide_qa_pass_report.py
Normal file
@@ -0,0 +1,29 @@
|
||||
from pathlib import Path
|
||||
|
||||
|
||||
ROOT = Path(__file__).resolve().parent.parent
|
||||
REPORT_PATH = ROOT / "reviews" / "2026-04-12-forge-wide-qa-pass.md"
|
||||
|
||||
|
||||
def test_forge_wide_qa_pass_report_exists():
|
||||
assert REPORT_PATH.exists(), "missing forge-wide QA pass report artifact"
|
||||
|
||||
|
||||
def test_forge_wide_qa_pass_report_preserves_key_findings():
|
||||
text = REPORT_PATH.read_text(encoding="utf-8")
|
||||
required = [
|
||||
"# Forge-Wide QA Pass — 2026-04-12 Evening",
|
||||
"**Reviewer:** Perplexity",
|
||||
"**Scope:** All 6 Timmy Foundation repos",
|
||||
"## Summary",
|
||||
"the-nexus swarm pileup (again)",
|
||||
"Queue throttle not deployed yet",
|
||||
"CAPTCHA bypass tool in timmy-config #499",
|
||||
"the-beacon Gemini bloat",
|
||||
"Paper PRs need polish (timmy-home)",
|
||||
"## Recommended Merge Order (the-nexus)",
|
||||
"#1327",
|
||||
"Reference: perplexity-status-report-2026-04-12-evening",
|
||||
]
|
||||
for snippet in required:
|
||||
assert snippet in text, f"missing report detail: {snippet}"
|
||||
Reference in New Issue
Block a user