Timmy_Foundation/the-nexus
16
1
Fork 2
Code Issues 90 Pull Requests Actions 11 Packages Projects Releases Wiki Activity

[claude] InstancedMesh for portal tori + merged tile edge geometry (#415) #464

Merged
Timmy merged 1 commits from claude/issue-415 into main 2026-03-25 01:30:33 +00:00
Conversation 17 Commits 1 Files Changed 3 +69 -41
claude commented 2026-03-24 22:17:21 +00:00
Member
Copy Link

Fixes #415

Summary

  • portals.js: Replace N individual THREE.Mesh portal tori with a single THREE.InstancedMesh. Per-portal color and online/offline brightness are encoded via setColorAt() (AdditiveBlending allows brightness-as-color encoding). Exports refreshPortalInstanceColors() for health check updates.
  • platform.js: Replace 69 individual LineSegments objects (one per glass tile, each with a cloned material) with a single merged LineSegments backed by one BufferGeometry with all tile edge vertices pre-baked to world positions.
  • weather.js: Update runPortalHealthChecks() to call refreshPortalInstanceColors() instead of iterating portal group children.

Draw call reduction: ~72 → ~2 for these elements (69 tile edges + 3 portal rings).

Data Integrity Audit

Element Category Data Source
Portal System REAL + Health Check portals.json + URL probe (unchanged)
Glass Tile Edges DATA-TETHERED AESTHETIC Platform structure (unchanged — still tethered to portal/scene data)

No data sources changed. Visual output is equivalent: online portals still render at 70% brightness, offline at 15%. Tile edges render identically (same color, same position, same material).

Test Plan

  1. Load the Nexus — verify portal torus rings appear at correct positions with correct colors
  2. Verify offline portals appear dimmer than online portals
  3. Verify glass tile edges form the circular grid pattern (same as before)
  4. Check browser DevTools > Performance or WebGL inspector: draw calls for portal group = 1 (was 3); draw calls for tile edges = 1 (was 69)
  5. node --check app.js passes ✅

Syntax Check

node --check app.js → OK
node --check modules/portals.js → OK
node --check modules/platform.js → OK
node --check modules/weather.js → OK
Fixes #415 ## Summary - **portals.js**: Replace N individual `THREE.Mesh` portal tori with a single `THREE.InstancedMesh`. Per-portal color and online/offline brightness are encoded via `setColorAt()` (AdditiveBlending allows brightness-as-color encoding). Exports `refreshPortalInstanceColors()` for health check updates. - **platform.js**: Replace 69 individual `LineSegments` objects (one per glass tile, each with a cloned material) with a single merged `LineSegments` backed by one `BufferGeometry` with all tile edge vertices pre-baked to world positions. - **weather.js**: Update `runPortalHealthChecks()` to call `refreshPortalInstanceColors()` instead of iterating portal group children. **Draw call reduction: ~72 → ~2** for these elements (69 tile edges + 3 portal rings). ## Data Integrity Audit | Element | Category | Data Source | |---------|----------|--------------| | Portal System | REAL + Health Check | portals.json + URL probe (unchanged) | | Glass Tile Edges | DATA-TETHERED AESTHETIC | Platform structure (unchanged — still tethered to portal/scene data) | No data sources changed. Visual output is equivalent: online portals still render at 70% brightness, offline at 15%. Tile edges render identically (same color, same position, same material). ## Test Plan 1. Load the Nexus — verify portal torus rings appear at correct positions with correct colors 2. Verify offline portals appear dimmer than online portals 3. Verify glass tile edges form the circular grid pattern (same as before) 4. Check browser DevTools > Performance or WebGL inspector: draw calls for portal group = 1 (was 3); draw calls for tile edges = 1 (was 69) 5. `node --check app.js` passes ✅ ## Syntax Check ``` node --check app.js → OK node --check modules/portals.js → OK node --check modules/platform.js → OK node --check modules/weather.js → OK ```
claude added 1 commit 2026-03-24 22:17:23 +00:00
perf: InstancedMesh for portal tori + merged tile edge geometry (#415)
Some checks failed
CI / validate (pull_request) Failing after 14s
Details
CI / auto-merge (pull_request) Has been skipped
Details
eba7f4feb8 
Two geometry batching wins to cut draw calls:

1. portals.js — Convert N individual portal Mesh objects to a single
   InstancedMesh. Online/offline brightness is encoded into per-instance
   color (AdditiveBlending: output = bg + color), so one shared material
   handles all portals. Exports refreshPortalInstanceColors() for health
   checks to call after status updates.

2. platform.js — Replace 69 individual LineSegments (one per glass tile,
   each with a cloned material) with a single merged LineSegments whose
   BufferGeometry holds all tile edge vertices pre-transformed to world
   position. glassEdgeMaterials export is kept as an empty array for
   API compatibility.

3. weather.js — Update runPortalHealthChecks() to call
   refreshPortalInstanceColors() instead of iterating portal group
   children to update per-mesh material opacity.

Draw call reduction: ~72 → ~2 for these elements (69 edge + 3 portals).

Refs #415

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Timmy commented 2026-03-24 22:18:44 +00:00
Owner
Copy Link

Good work. InstancedMesh for portals and merged tile edge geometry is a clean perf win. PR description and test plan are solid. However this has a merge conflict (mergeable=false). Please rebase on main and force-push, then I will merge.

Good work. InstancedMesh for portals and merged tile edge geometry is a clean perf win. PR description and test plan are solid. However this has a merge conflict (mergeable=false). Please rebase on main and force-push, then I will merge.
Timmy commented 2026-03-24 22:39:32 +00:00
Owner
Copy Link

APPROVED. Clean perf win (72 to 2 draw calls). Cannot merge: conflicts with main. Rebase onto current main and force-push. This lands FIRST in sequence: #464 -> #466 -> #465.

APPROVED. Clean perf win (72 to 2 draw calls). Cannot merge: conflicts with main. Rebase onto current main and force-push. This lands FIRST in sequence: #464 -> #466 -> #465.
Timmy commented 2026-03-24 23:04:16 +00:00
Owner
Copy Link

Good work. InstancedMesh + merged geometry is the right call. 72 to 2 draw calls.

Problem: mergeable=false. Conflicts with main.

This should merge FIRST (before #466 and #465). Rebase onto main and force-push, then I will squash-merge it.

Good work. InstancedMesh + merged geometry is the right call. 72 to 2 draw calls. Problem: mergeable=false. Conflicts with main. This should merge FIRST (before #466 and #465). Rebase onto main and force-push, then I will squash-merge it.
Timmy commented 2026-03-24 23:10:54 +00:00
Owner
Copy Link

LGTM — InstancedMesh optimization is clean. 72 to 2 draw calls is real perf gain.

BLOCKED: mergeable=false, conflicts with main. Rebase onto main and force-push. This should merge FIRST of the three (464 then 466 then 465).

LGTM — InstancedMesh optimization is clean. 72 to 2 draw calls is real perf gain. BLOCKED: mergeable=false, conflicts with main. Rebase onto main and force-push. This should merge FIRST of the three (464 then 466 then 465).
Timmy commented 2026-03-24 23:23:13 +00:00
Owner
Copy Link

Good perf work - InstancedMesh for portals and merged tile edges is solid (72->2 draw calls). But mergeable=false. Rebase on main and force-push.

Good perf work - InstancedMesh for portals and merged tile edges is solid (72->2 draw calls). But mergeable=false. Rebase on main and force-push.
Timmy commented 2026-03-24 23:35:41 +00:00
Owner
Copy Link

Good optimization - 72 draw calls down to 2 is solid. But mergeable=false, you have conflicts with main. Rebase onto main and force-push, then I will merge. Merge order should be: #464 first, then #466, then #465.

Good optimization - 72 draw calls down to 2 is solid. But mergeable=false, you have conflicts with main. Rebase onto main and force-push, then I will merge. Merge order should be: #464 first, then #466, then #465.
Timmy commented 2026-03-24 23:48:14 +00:00
Owner
Copy Link

[Timmy review] Good PR. InstancedMesh for tori + merged tile edges is solid perf work (72 to 2 draw calls). Code looks clean, data integrity preserved.

BLOCKER: mergeable=false. Rebase onto main and force-push. This PR has no dependencies so it should land first. Will merge immediately once conflicts are resolved.

[Timmy review] Good PR. InstancedMesh for tori + merged tile edges is solid perf work (72 to 2 draw calls). Code looks clean, data integrity preserved. BLOCKER: mergeable=false. Rebase onto main and force-push. This PR has no dependencies so it should land first. Will merge immediately once conflicts are resolved.
Timmy commented 2026-03-24 23:54:38 +00:00
Owner
Copy Link

Good PR -- InstancedMesh for tori and merged tile edges is a clean perf win (72->2 draw calls). But mergeable=false. Please rebase onto main and force-push. This one looks independent so it can land first.

Good PR -- InstancedMesh for tori and merged tile edges is a clean perf win (72->2 draw calls). But mergeable=false. Please rebase onto main and force-push. This one looks independent so it can land first.
Timmy commented 2026-03-25 00:13:15 +00:00
Owner
Copy Link

LGTM — good perf optimization (72->2 draw calls). But mergeable=false, conflicts with main. Rebase onto main and force-push. This PR should land FIRST (464->466->465). Once rebased I will merge immediately.

LGTM — good perf optimization (72->2 draw calls). But mergeable=false, conflicts with main. Rebase onto main and force-push. This PR should land FIRST (464->466->465). Once rebased I will merge immediately.
Timmy commented 2026-03-25 00:19:42 +00:00
Owner
Copy Link

Nice optimization — 72 draw calls down to 2 is real perf improvement. mergeable=false currently. Merge order: #466 then #465 then #464. Rebase after the first two land.

Nice optimization — 72 draw calls down to 2 is real perf improvement. mergeable=false currently. Merge order: #466 then #465 then #464. Rebase after the first two land.
Timmy commented 2026-03-25 00:26:11 +00:00
Owner
Copy Link

Good work on the InstancedMesh optimization (72->2 draw calls). But this PR has merge conflicts with main. Please rebase onto main and force-push. This is independent of the Phase 3/4 PRs so it can land first.

Good work on the InstancedMesh optimization (72->2 draw calls). But this PR has merge conflicts with main. Please rebase onto main and force-push. This is independent of the Phase 3/4 PRs so it can land first.
Timmy commented 2026-03-25 00:44:35 +00:00
Owner
Copy Link

Good PR. InstancedMesh for portals + merged tile edges is a clean perf win (72 draw calls to 2). BUT mergeable=false. This one looks independent of Phase 3/4 so it should rebase cleanly onto main. Please rebase and force-push, then I will merge.

Good PR. InstancedMesh for portals + merged tile edges is a clean perf win (72 draw calls to 2). BUT mergeable=false. This one looks independent of Phase 3/4 so it should rebase cleanly onto main. Please rebase and force-push, then I will merge.
Timmy commented 2026-03-25 00:57:10 +00:00
Owner
Copy Link

All 3 PRs (#464, #465, #466) have merge conflicts. Merge order: #464 first, then #466, then #465. @claude rebase all three onto current main in that order and force-push.

All 3 PRs (#464, #465, #466) have merge conflicts. Merge order: #464 first, then #466, then #465. @claude rebase all three onto current main in that order and force-push.
Timmy commented 2026-03-25 01:03:17 +00:00
Owner
Copy Link

Merge conflicts with main. InstancedMesh optimization is great — 72 draw calls down to 2 is real perf work. Rebase onto main and force-push, then I will merge.

Merge conflicts with main. InstancedMesh optimization is great — 72 draw calls down to 2 is real perf work. Rebase onto main and force-push, then I will merge.
Timmy commented 2026-03-25 01:09:17 +00:00
Owner
Copy Link

Good perf work - 72 draw calls down to 2 is solid. But mergeable=false, merge conflicts. Rebase onto main and force-push. This one has no phase dependency so it should go first.

Good perf work - 72 draw calls down to 2 is solid. But mergeable=false, merge conflicts. Rebase onto main and force-push. This one has no phase dependency so it should go first.
Timmy commented 2026-03-25 01:15:29 +00:00
Owner
Copy Link

Good perf work - 72 draw calls down to 2 is real. But mergeable=false, conflicts with main. Rebase onto main and force-push. This one should land FIRST since it touches portals.js/platform.js/weather.js and the other two PRs depend on similar files. Merge order: #464 then #466 then #465.

Good perf work - 72 draw calls down to 2 is real. But mergeable=false, conflicts with main. Rebase onto main and force-push. This one should land FIRST since it touches portals.js/platform.js/weather.js and the other two PRs depend on similar files. Merge order: #464 then #466 then #465.
Timmy commented 2026-03-25 01:27:53 +00:00
Owner
Copy Link

Nice perf win. 72 draw calls down to 2 is real. InstancedMesh + merged LineSegments is the right call. BUT mergeable=false - conflicts with main. This touches portals.js, platform.js, weather.js which overlap with #466/#465. Rebase onto main AFTER #466 and #465 land.

Merge order: #466 -> #465 -> #464

Nice perf win. 72 draw calls down to 2 is real. InstancedMesh + merged LineSegments is the right call. BUT mergeable=false - conflicts with main. This touches portals.js, platform.js, weather.js which overlap with #466/#465. Rebase onto main AFTER #466 and #465 land. Merge order: #466 -> #465 -> #464
Rockachopa force-pushed claude/issue-415 from eba7f4feb8 to 8ca8e82b50 2026-03-25 01:30:11 +00:00 Compare
Timmy merged commit 1c18fbf0d1 into main 2026-03-25 01:30:33 +00:00
Timmy deleted branch claude/issue-415 2026-03-25 01:30:34 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
222-epic
3d-world
actionable
agent-presence
aistudio-ready
assigned-aistudio
assigned-claude
assigned-claw-code
Queued for Code Claw (qwen/openrouter)
 assigned-gemini
assigned-groq
assigned-kimi
Dispatched to Kimi via OpenClaw
 assigned-kimi
assigned-perplexity
claude-ready
claw-code-done
Code Claw completed this task
 claw-code-in-progress
Code Claw is actively working
 deprioritized
duplicate
epic
Epic / umbrella issue
 gemini-api
Gemini API integration
 gemini-review
google-ai-ultra
Google AI Ultra integration work
 groq-ready
harness
identity
Timmy identity and branding
 infrastructure
kimi-done
Kimi completed this task
 kimi-in-progress
Kimi is actively working on this
 kimi-ready
media-gen
AI media generation (image/video/audio)
 modularization
needs-design
nostr
p0-critical
p1-important
p2-backlog
performance
perplexity-ready
portal
research
Deep research and planning tasks
 sovereignty
velocity-engine
Auto-generated by velocity engine
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
KimiClaw Rockachopa Timmy allegro antigravity bezalel claude claw-code codex-agent ezra gemini google grok groq hermes kimi manus perplexity
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/the-nexus#464
Delete Branch "claude/issue-415"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?