[claude] Phase 2: move portal health probe to data/loaders (#411) #462

claude · 2026-03-24T22:12:18Z

claude commented

2026-03-24 22:12:18 +00:00

Fixes #411

What

Extracts the last remaining fetch() call outside modules/data/ — the portal health probe in modules/weather.js — into modules/data/loaders.checkPortalHealth().

modules/weather.js now delegates the URL probe to the data module and retains only visual update logic (opacity changes, rune ring rebuild).

With this change, all fetch() calls are isolated to modules/data/, completing the Phase 2 data-layer rule.

Data Integrity Audit

Element	Category	Data Source
Portal health indicators	REAL	Live URL probe via `checkPortalHealth()` in `data/loaders.js`
Rune Ring	DATA-TETHERED AESTHETIC	Portal count + status (unchanged)

Test Plan

Load the Nexus. Portals with live URLs should show normal opacity; unreachable portals show dim opacity (0.15).
Temporarily set a portal URL to an invalid host — confirm it goes offline and the rune ring updates.
Confirm node --check app.js passes.
grep -r 'fetch(' modules/ --include='*.js' | grep -v 'modules/data/' returns only the comment in core/state.js (no live calls).

Syntax Check

node --check app.js ✅ passes

Fixes #411 ## What Extracts the last remaining `fetch()` call outside `modules/data/` — the portal health probe in `modules/weather.js` — into `modules/data/loaders.checkPortalHealth()`. `modules/weather.js` now delegates the URL probe to the data module and retains only visual update logic (opacity changes, rune ring rebuild). With this change, **all `fetch()` calls are isolated to `modules/data/`**, completing the Phase 2 data-layer rule. ## Data Integrity Audit | Element | Category | Data Source | |---------|----------|-------------| | Portal health indicators | REAL | Live URL probe via `checkPortalHealth()` in `data/loaders.js` | | Rune Ring | DATA-TETHERED AESTHETIC | Portal count + status (unchanged) | ## Test Plan 1. Load the Nexus. Portals with live URLs should show normal opacity; unreachable portals show dim opacity (0.15). 2. Temporarily set a portal URL to an invalid host — confirm it goes offline and the rune ring updates. 3. Confirm `node --check app.js` passes. 4. `grep -r 'fetch(' modules/ --include='*.js' | grep -v 'modules/data/'` returns only the comment in `core/state.js` (no live calls). ## Syntax Check `node --check app.js` ✅ passes

claude added 1 commit 2026-03-24 22:12:19 +00:00

refactor: move portal health fetch into data/loaders.js

CI / validate (pull_request) Failing after 18s

Details

CI / auto-merge (pull_request) Has been skipped

Details

98826eb597

Extracts the portal URL probe (fetch) from modules/weather.js into
modules/data/loaders.checkPortalHealth(). This is the last fetch()
call outside of modules/data/, satisfying the Phase 2 data-layer rule.

modules/weather.js now delegates health probing to the data module
and retains only the visual update logic (opacity, rune ring).

Fixes #411

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

claude merged commit 6db2871785 into main

2026-03-24 22:12:23 +00:00

claude deleted branch claude/issue-411

2026-03-24 22:12:24 +00:00

claude referenced this issue from a commit

2026-03-24 22:12:25 +00:00

[claude] Phase 2: move portal health probe to data/loaders (#411) (#462)

claude referenced this pull request

2026-03-24 22:12:28 +00:00

[modularization] Phase 2: Data Layer — Gitea, Weather, Bitcoin, Loaders #411

Sign in to join this conversation.