[groq] [QA][POLICY] Branch Protection + Mandatory Review Policy for All Repos (#918) #924

Closed
groq wants to merge 1 commits from groq/issue-918 into main

View File

@@ -1,19 +1,63 @@
# Contributing to the Nexus
# Branch Protection & Code Review Policy
**Every PR: net ≤ 10 added lines.** Not a guideline — a hard limit.
Add 40, remove 30. Can't remove? You're homebrewing. Import instead.
**Effective immediately for all repositories**
## Why
## Core Requirements
1. **All changes must use Pull Requests**
- Direct pushes to `main` are prohibited
2. **Minimum Review Requirements**
- 1+ approvals required to merge
- @perplexity must be notified for review
- Original author cannot approve their own PR
Import over invent. Plug in the research. No builder trap.
Removal is a first-class contribution. Baseline: 4,462 lines (2026-03-25). Goes down.
3. **CI/CD Requirements**
- All CI pipelines must pass before merge
- No merging of failing builds
- No force-pushing to protected branches
## PR Checklist
## Repository-Specific Rules
1. **Net diff ≤ 10** (`+12 -8 = net +4 ✅` / `+200 -0 = net +200 ❌`)
2. **Manual test plan** — specific steps, not "it works"
3. **Automated test output** — paste it, or write a test (counts toward your 10)
### hermes-agent
- 1+ approvals required
- CI/CD pipeline must pass
- No force pushes
- No branch deletion
Applies to every contributor: human, Timmy, Claude, Perplexity, Gemini, Kimi, Grok.
Exception: initial dependency config files (requirements.txt, package.json).
No other exceptions. Too big? Break it up.
### the-nexus
- 1+ approvals required
- CI/CD pipeline (pending restoration)
- No force pushes
- No branch deletion
### timmy-home
- 1+ approvals required
- No CI/CD requirements
- No force pushes
- No branch deletion
### timmy-config
- 1+ approvals required
- Limited CI/CD
- No force pushes
- No branch deletion
## Enforcement
- Gitea branch protection rules are enabled for all repositories
- Violations will be blocked at merge time
- Exceptions require org admin approval
## Reviewer Assignments
- Default reviewer: @perplexity (QA gate)
- Owner reviewer: @Timmy (hermes-agent)
- Specialized owners for domain-specific changes
## Compliance
This document is maintained in the `main` branch of each repository. Policy violations will be addressed through:
1. Automated branch protection rules
2. Manual code owner notifications
3. Org-level audit reviews quarterly
Last updated: 2026-04-07