32 lines
1.1 KiB
Markdown
32 lines
1.1 KiB
Markdown
# Issue #1413 Verification
|
|
|
|
Status: already implemented on `main`
|
|
|
|
## Acceptance criteria check
|
|
|
|
1. ✅ `deploy.sh` comment for `nexus-main` uses port `8765`
|
|
- Evidence: `deploy.sh:3`
|
|
2. ✅ `deploy.sh` comment for `nexus-staging` uses port `8766`
|
|
- Evidence: `deploy.sh:4`
|
|
3. ✅ `docker-compose.yml` confirms those bindings
|
|
- Evidence: `docker-compose.yml:9` is `"8765:8765"`
|
|
- Evidence: `docker-compose.yml:15` is `"8766:8765"`
|
|
|
|
## Why no code fix was needed
|
|
|
|
The issue describes stale comments (`4200` / `4201`), but the current `main` branch already contains the corrected comments:
|
|
|
|
```text
|
|
# Usage: ./deploy.sh — rebuild and restart nexus-main (port 8765)
|
|
# ./deploy.sh staging — rebuild and restart nexus-staging (port 8766)
|
|
```
|
|
|
|
## Value added in this PR
|
|
|
|
- adds `tests/test_deploy_script_ports.py` so future drift between `deploy.sh` comments and `docker-compose.yml` is caught automatically
|
|
- documents the verification outcome here so the issue can be closed without reimplementing an already-merged fix
|
|
|
|
## Recommendation
|
|
|
|
Close issue #1413 as already implemented.
|