59784e620c
- Add CI workflow to check for empty PRs - Update PR template with reviewer guidelines - Add zombie PR detection script - Add documentation for rubber-stamping prevention Prevents rubber-stamping of PRs with no changes by: 1. Automated CI checks that block zombie PRs 2. Clear reviewer guidelines in PR template 3. Detection script for existing zombie PRs 4. Comprehensive documentation Addresses issue #1445: process: Prevent rubber-stamping of PRs with no changes
2.7 KiB
2.7 KiB
Description
Changes Made
Files Changed
Type of Change
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- Documentation update
- Refactoring (no functional changes)
- Test updates
- CI/CD changes
Testing
Test Instructions
Checklist
- My code follows the style guidelines of this project
- I have performed a self-review of my own code
- I have commented my code, particularly in hard-to-understand areas
- I have made corresponding changes to the documentation
- My changes generate no new warnings
- I have added tests that prove my fix is effective or that my feature works
- New and existing unit tests pass locally with my changes
- Any dependent changes have been merged and published in downstream modules
Reviewer Guidelines
⚠️ Reviewers MUST verify:
- PR has actual changes - Check that the PR contains additions, deletions, or modifications
- Changes match description - Verify the changes match what's described in the PR
- Code quality - Review code for bugs, security issues, performance problems
- Tests are adequate - Ensure new code is properly tested
- Documentation is updated - Check if documentation needs updates
❌ DO NOT approve if:
- PR has 0 additions, 0 deletions, and 0 files changed (zombie PR)
- Changes don't match the PR description
- Code has obvious bugs or security issues
- No tests for new functionality
- Documentation is missing or incorrect
✅ DO approve if:
- PR has meaningful changes that match the description
- Code is clean, well-tested, and documented
- Changes follow project conventions
- No obvious issues or risks
Related Issues
- Fixes #
- Related to #
Additional Notes
By submitting this PR, I confirm that:
- I have actually reviewed the code changes
- The changes are meaningful and not a zombie PR
- I have tested the changes locally (if applicable)
- I understand that rubber-stamping (approving PRs with no changes) is prohibited