59784e620c
- Add CI workflow to check for empty PRs - Update PR template with reviewer guidelines - Add zombie PR detection script - Add documentation for rubber-stamping prevention Prevents rubber-stamping of PRs with no changes by: 1. Automated CI checks that block zombie PRs 2. Clear reviewer guidelines in PR template 3. Detection script for existing zombie PRs 4. Comprehensive documentation Addresses issue #1445: process: Prevent rubber-stamping of PRs with no changes
73 lines
2.7 KiB
Markdown
73 lines
2.7 KiB
Markdown
## Description
|
|
<!-- Provide a clear description of what this PR does -->
|
|
|
|
## Changes Made
|
|
<!-- List the specific changes made in this PR -->
|
|
|
|
### Files Changed
|
|
<!-- List the files that were modified -->
|
|
|
|
### Type of Change
|
|
<!-- Check the relevant option -->
|
|
- [ ] Bug fix (non-breaking change which fixes an issue)
|
|
- [ ] New feature (non-breaking change which adds functionality)
|
|
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
|
|
- [ ] Documentation update
|
|
- [ ] Refactoring (no functional changes)
|
|
- [ ] Test updates
|
|
- [ ] CI/CD changes
|
|
|
|
## Testing
|
|
<!-- Describe the tests you ran to verify your changes -->
|
|
|
|
### Test Instructions
|
|
<!-- Provide step-by-step instructions to test your changes -->
|
|
|
|
## Checklist
|
|
<!-- Check all that apply -->
|
|
- [ ] My code follows the style guidelines of this project
|
|
- [ ] I have performed a self-review of my own code
|
|
- [ ] I have commented my code, particularly in hard-to-understand areas
|
|
- [ ] I have made corresponding changes to the documentation
|
|
- [ ] My changes generate no new warnings
|
|
- [ ] I have added tests that prove my fix is effective or that my feature works
|
|
- [ ] New and existing unit tests pass locally with my changes
|
|
- [ ] Any dependent changes have been merged and published in downstream modules
|
|
|
|
## Reviewer Guidelines
|
|
<!-- IMPORTANT: Reviewers must follow these guidelines to prevent rubber-stamping -->
|
|
|
|
### ⚠️ Reviewers MUST verify:
|
|
1. **PR has actual changes** - Check that the PR contains additions, deletions, or modifications
|
|
2. **Changes match description** - Verify the changes match what's described in the PR
|
|
3. **Code quality** - Review code for bugs, security issues, performance problems
|
|
4. **Tests are adequate** - Ensure new code is properly tested
|
|
5. **Documentation is updated** - Check if documentation needs updates
|
|
|
|
### ❌ DO NOT approve if:
|
|
- PR has 0 additions, 0 deletions, and 0 files changed (zombie PR)
|
|
- Changes don't match the PR description
|
|
- Code has obvious bugs or security issues
|
|
- No tests for new functionality
|
|
- Documentation is missing or incorrect
|
|
|
|
### ✅ DO approve if:
|
|
- PR has meaningful changes that match the description
|
|
- Code is clean, well-tested, and documented
|
|
- Changes follow project conventions
|
|
- No obvious issues or risks
|
|
|
|
## Related Issues
|
|
<!-- Link any related issues -->
|
|
- Fixes #<!-- issue number -->
|
|
- Related to #<!-- issue number -->
|
|
|
|
## Additional Notes
|
|
<!-- Add any other context about the PR here -->
|
|
|
|
---
|
|
**By submitting this PR, I confirm that:**
|
|
1. I have actually reviewed the code changes
|
|
2. The changes are meaningful and not a zombie PR
|
|
3. I have tested the changes locally (if applicable)
|
|
4. I understand that rubber-stamping (approving PRs with no changes) is prohibited |