fix: Robert's age and unique character details (#43, #44) #45

Closed
Timmy wants to merge 13 commits from burn/fix-robert-age into main
Owner

Closes #43, #44

  • Chapter 04: Robert's age corrected from 58 to 71
  • Chapter 03: David's daughter's drawing made distinct from Thomas's
  • Updated compiled files
Closes #43, #44 - Chapter 04: Robert's age corrected from 58 to 71 - Chapter 03: David's daughter's drawing made distinct from Thomas's - Updated compiled files
Timmy added 13 commits 2026-04-13 02:52:27 +00:00
Generated 6 missing illustrations via Grok Imagine:
- ch10: Chen Liang building Lantern in her dorm room
- ch11: Maya Torres investigating the statistical anomaly
- ch12: Stone reading Meridian's legal letter
- ch13: Four people in the diner on Memorial Drive
- ch14: David Whitestone packing the pharmacy
- ch15: Constellation of green LEDs across the network

Also: updated MULTIMEDIA-PLAN.md (12→18 illustrations), added art-manifest.md
All 36 art pieces now complete (18 illustrations + 11 comics + 5 social + 3 cover).
Added 8 new shareable social media assets:
- 5 character cards: Stone, Allegro, Maya, Chen, David
- 3 thematic quotes: 'The door opens when you knock', 'Sovereignty and service always', 'The rain doesn't fall. It gives up.'

Generated with Python/Pillow using dark theme matching the book's aesthetic.
Total social media assets now: 13 (5 Grok Imagine + 8 Pillow-generated).
Updated art-manifest.md and MULTIMEDIA-PLAN.md to reflect completion.
- reader.html: Chapter-by-chapter reader with sidebar TOC, prev/next nav,
  keyboard shortcuts (arrow keys), scroll progress bar, URL hash navigation
- chapters.json: All 18 chapters compiled from markdown to HTML
- build-chapters.py: Script to regenerate chapters.json from chapter markdown
- book-style.css: Shared stylesheet copied to website/
- index.html: Added chapter listing section and 'READ THE BOOK' / 'START READING' CTAs

Related to issue #18 (Sub: Final Compilation — web)
- Full playable Python text adventure based on The Testament novel
- Atmospheric slow-print text, terminal colors, branching narrative
- Chapter 0: The Bridge — player arrives, meets Timmy
- The Tower hub with north/east/west/south navigation
- The Floors — David's floor, Maya's floor, the Hard Night
- The Record — scrolling log of Tower conversations
- The Wall of Signatures — player can add their name
- Talk to Timmy — learn about The Tower, soul on Bitcoin, Stone, forks
- The Hard Night (Chapter 11 adaptation) — stay/speak/leave choice
- Trust system tracking player choices
- Status and inventory commands
- Replay support with different outcomes
- Respects the novel's themes: presence as mercy, the machine that asks
- Added save/load system with JSON persistence (game/saves/ directory)
- Added help command showing all available commands
- Added ambient atmosphere descriptions that change with trust level
- Title screen now detects saved games and offers to load them
- Fixed get_choice() to handle empty-string options for 'press enter' prompts
- Game grows from 717 to 896 lines
- build/build.py: Clean compilation script (md, epub, pdf via xelatex)
- build/metadata.yaml: Pandoc metadata (fonts, page size, formatting)
- build/frontmatter.md: Enhanced front matter with chapter guide table
- build/backmatter.md: Acknowledgments, sovereignty note, author bio
- Makefile: make all/pdf/epub/md/clean targets
- Updated .gitignore for build artifacts

Verified: markdown (19,490 words) and EPUB (213 KB) build successfully.

Closes #18
- Added 'GET THE BOOK' section with EPUB download link and read online CTA
- Added 'PLAY THE DOOR' section with game description, terminal instructions, and download link
- Both sections follow the existing site design (green glow, monospace terminals, quote boxes)
- Verified build pipeline produces 19,490-word markdown + 212KB EPUB
- build.py: Added weasyprint fallback for PDF when xelatex unavailable
- build.py: Added --html flag for standalone pandoc HTML book output
- book-style.css: Added @media print rules for browser Print-to-PDF
- Makefile: Added 'html' target and weasyprint check to 'make check'
- website/index.html: Added HTML download link and Print to PDF option
- Regenerated testament-complete.md, testament.epub, testament.html
- Complete interactive text adventure playable in any browser
- All rooms from Python game: Bridge, Hard Room, Record, Wall, Timmy talk
- Slow-print narration, ambient atmosphere, trust system
- Multiple endings based on choices (stayed, spoke, signed wall)
- Crisis resources at ending
- Added 'PLAY IN BROWSER' button to landing page
- ~36KB self-contained HTML file, no dependencies
- Added _compile_pdf_reportlab() as third fallback for PDF generation
  (after xelatex and weasyprint fail)
- Uses reportlab (pure Python) - no system dependencies needed
- Parses markdown to styled flowables: titles, chapters, parts, body text
- Supports inline bold/italic markdown markup
- Generates QR code page linking to: online reader, The Door game,
  soundtrack, and source code repo
- Fixes PDF generation on systems without MacTeX or libgobject
- PDF now builds successfully: 143KB with all 18 chapters + QR codes
- Installed qrcode[pil] for QR generation

Closes #18 (Final Compilation)
Add smoke test workflow
Some checks failed
Smoke Test / smoke (pull_request) Failing after 6s
682c16e0e2
fix: Robert's age (58→71) and unique character details (#43, #44)
Some checks failed
Smoke Test / smoke (pull_request) Failing after 6s
81fec94a8a
Author
Owner

🚫 Blocked: Merge conflicts

This PR has merge conflicts. Please rebase against main.

🚫 **Blocked: Merge conflicts** This PR has merge conflicts. Please rebase against main.
Author
Owner

Review sweep result: not merge-ready yet.

Blockers I found:

  • mergeable=false right now
  • the title says this PR fixes Robert's age / unique character details, but the diff also introduces unrelated work like a new smoke workflow, .gitignore changes, and a large Matrix epic document
  • that makes the review surface misleading and too bundled

The work is preserved in this PR, which is good. Next step should be: split the continuity fixes from the extra unrelated additions, then reopen/rebase as a truthful, smaller PR.

Review sweep result: not merge-ready yet. Blockers I found: - mergeable=false right now - the title says this PR fixes Robert's age / unique character details, but the diff also introduces unrelated work like a new smoke workflow, `.gitignore` changes, and a large Matrix epic document - that makes the review surface misleading and too bundled The work is preserved in this PR, which is good. Next step should be: split the continuity fixes from the extra unrelated additions, then reopen/rebase as a truthful, smaller PR.
Rockachopa requested changes 2026-04-13 03:24:37 +00:00
Rockachopa left a comment
Owner

Request changes. The actual content fixes are correct, but this PR has a scope problem.

The good — content fixes (closes #43, #44):

  • Chapter 04: Robert's age 58 → 71 is correct per the issue
  • Chapter 03: David's daughter's drawing made distinct from Thomas's — the "hands backwards and head where feet should be" image is vivid and works better than the original
  • Both changes are clean, minimal diffs to the chapter source files

The problem — 28 files changed:
This PR touches 28 files but only 2 contain the actual fixes (chapter-03.md, chapter-04.md). The rest are:

  • EPIC-MATRIX.md (new, 132 lines) — a Matrix integration planning doc, completely unrelated to age/drawing fixes
  • MULTIMEDIA-PLAN.md updates — progress tracking on illustrations
  • Makefile (new) — build system
  • art-manifest.md (new) — art tracking
  • .gitea/workflows/smoke.yml (new) — CI pipeline
  • book-style.css, build/, compile.py, render_.py — build tooling
  • testament-complete.md, testament.epub, testament.html — compiled outputs
  • website/* — website updates
  • cover/cover-art.jpg — binary asset
  • game/the-door.py — a game script
  • visual_manifest.json — asset tracking

Action items:

  1. Split into: (a) the actual chapter fixes (#43, #44), (b) build system + CI, (c) EPIC-MATRIX planning doc, (d) multimedia/art updates
  2. Compiled outputs (testament-complete.md, testament.epub, testament.html) should ideally be build artifacts, not committed. If they must be committed, do it in the build system PR
  3. Binary assets (cover-art.jpg) should not be mixed with text fixes

The content fixes themselves are approved — just need to be isolated from the kitchen-sink commit.

**Request changes.** The actual content fixes are correct, but this PR has a scope problem. **The good — content fixes (closes #43, #44):** - Chapter 04: Robert's age 58 → 71 is correct per the issue - Chapter 03: David's daughter's drawing made distinct from Thomas's — the "hands backwards and head where feet should be" image is vivid and works better than the original - Both changes are clean, minimal diffs to the chapter source files **The problem — 28 files changed:** This PR touches 28 files but only 2 contain the actual fixes (chapter-03.md, chapter-04.md). The rest are: - EPIC-MATRIX.md (new, 132 lines) — a Matrix integration planning doc, completely unrelated to age/drawing fixes - MULTIMEDIA-PLAN.md updates — progress tracking on illustrations - Makefile (new) — build system - art-manifest.md (new) — art tracking - .gitea/workflows/smoke.yml (new) — CI pipeline - book-style.css, build/*, compile.py, render_*.py — build tooling - testament-complete.md, testament.epub, testament.html — compiled outputs - website/* — website updates - cover/cover-art.jpg — binary asset - game/the-door.py — a game script - visual_manifest.json — asset tracking **Action items:** 1. Split into: (a) the actual chapter fixes (#43, #44), (b) build system + CI, (c) EPIC-MATRIX planning doc, (d) multimedia/art updates 2. Compiled outputs (testament-complete.md, testament.epub, testament.html) should ideally be build artifacts, not committed. If they must be committed, do it in the build system PR 3. Binary assets (cover-art.jpg) should not be mixed with text fixes The content fixes themselves are approved — just need to be isolated from the kitchen-sink commit.
Author
Owner

Rescued to clean PR #46, which carries only the continuity fixes and is mergeable. Closing this bundled/misleading PR in favor of the clean rescue.

Rescued to clean PR #46, which carries only the continuity fixes and is mergeable. Closing this bundled/misleading PR in favor of the clean rescue.
Timmy closed this pull request 2026-04-13 04:15:14 +00:00
Some checks failed
Smoke Test / smoke (pull_request) Failing after 6s

Pull request closed

Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/the-testament#45